Re: [PATCH] boot: fix missing dependency for BOOTMETH_ANDROID

[Mattijs Korpershoek <mkorpershoek@kernel.org>]

Hi Quentin,

Thank you for the patch.

On Thu, Dec 18, 2025 at 13:19, Quentin Schulz <foss+uboot@0leil.net> wrote:

> From: Quentin Schulz <quentin.schulz@cherry.de>
>
> The code depends on set_avendor_bootimg_addr and set_abootimg_addr
> functions which are only defined in cmd/abootimg.c, only built when
> CMD_ABOOTIMG=y so let's add a dependency.
>
> It should be "depends on" to be properly implemented, but we get a
> circular dependency otherwise:
> boot/Kconfig:566:error: recursive dependency detected!
> boot/Kconfig:566:	symbol BOOTMETH_ANDROID depends on CMD_ABOOTIMG
> cmd/Kconfig:504:	symbol CMD_ABOOTIMG depends on ANDROID_BOOT_IMAGE
> boot/Kconfig:7:	symbol ANDROID_BOOT_IMAGE is selected by BOOTMETH_ANDROID
>
> so instead we do a select. It is safe because CMD_ABOOTIMG depends on
> ANDROID_BOOT_IMAGE which we select here as well.
>
> Fixes: 125d9f3306ea ("bootstd: Add a bootmeth for Android")
> Signed-off-by: Quentin Schulz <quentin.schulz@cherry.de>

Reviewed-by: Mattijs Korpershoek <mkorpershoek@kernel.org>

> ---
>  boot/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/boot/Kconfig b/boot/Kconfig
> index 245e120c70b..aa135a4e1a5 100644
> --- a/boot/Kconfig
> +++ b/boot/Kconfig
> @@ -568,6 +568,7 @@ config BOOTMETH_ANDROID
>  	depends on X86 || ARM || SANDBOX
>  	depends on CMDLINE
>  	select ANDROID_BOOT_IMAGE
> +	select CMD_ABOOTIMG
>  	select CMD_BCB
>  	imply CMD_FASTBOOT
>  	imply FASTBOOT if !NET_LWIP
>
> ---
> base-commit: 47b50fb1125c539d80ed3e7f739c02c6486e1b52
> change-id: 20251218-bootmeth_android-deps-a16555d168e5
>
> Best regards,
> -- 
> Quentin Schulz <quentin.schulz@cherry.de>