From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 276FECCD182 for ; Thu, 2 Oct 2025 16:25:22 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v4M74-0004v7-VN; Thu, 02 Oct 2025 12:25:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v4M6y-0004tE-Q4 for qemu-arm@nongnu.org; Thu, 02 Oct 2025 12:24:57 -0400 Received: from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1v4M6s-0003fU-1F for qemu-arm@nongnu.org; Thu, 02 Oct 2025 12:24:56 -0400 Received: by mail-wr1-x42c.google.com with SMTP id ffacd0b85a97d-414f48bd785so756513f8f.1 for ; Thu, 02 Oct 2025 09:24:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1759422283; x=1760027083; darn=nongnu.org; h=content-transfer-encoding:mime-version:message-id:date:user-agent :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=m99izO4r9jgab72834xowzWE5+08Sb+hWHqm6S4fLGE=; b=wiQOEeKuwukyIlu6nUqvgwRodIfen0iXfXTJnjDqr7FBiRbTgZO8Msnnn6qsjWS9m7 vGn7DHErNACwVHYMaZ1QGc3YsNewNgMB13SSIyfslVe/8ZoyHYog+rD/MGEs80EghUvw blzu8kSmoERpabT+qkAsRI2LfcjUo+sGYuCX7wayaH2ZMpXqF+gEPnYcyZujdEwAPCj8 8QDyItNZ0rexKjlKoJr/WobUGnIW5nUsUQIUE8U1WiBGdZmal6Fh6xa0K3b+cLszlzF9 lC7uof9qk6RRDP31BRZrIqz5PnnYVz0WtIYJl4b2pBcLGPJpgV9NmRdA6Iy6sw3D7abW J1Vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759422283; x=1760027083; h=content-transfer-encoding:mime-version:message-id:date:user-agent :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=m99izO4r9jgab72834xowzWE5+08Sb+hWHqm6S4fLGE=; b=Cxb3wh04pRW2j/AfNSbfw2+ttuGRzuLGXnDYFWcdWVxpWkpLmaVe68Pvn5aiTT77Sl 7OJNYQ3F0g8WrGwwiJCps8lHn6XE9E7QeOao8BC8iEG5eMhM62phsHAZ/Mqj0Cr5gjcC K9CIBZe0HJylOMwDzT+jQnsKO7xP7lErmxW7/pOOpsmp65di08IJ9pJEUYseU2hdR7sP RywbBO/e6Aga9UcFf1j1I42uakmZhuquHXXVURvc9Ylvag7yytn7WGKQvXwm7NSzRbBg ramwBGGglIAVFCnWnacfgtPab5eUeZZeqf1VH48M/aNRSKnswBF7eDEbWpYnzeKYQdI0 Jqsg== X-Forwarded-Encrypted: i=1; AJvYcCULzSPDT+A781mBwBBmXuW12xWGoMYNCdMhEks42gxekaRVguXt6c3Il4w9DIRdUIhYYDCtgS6Stw==@nongnu.org X-Gm-Message-State: AOJu0YwseBM/4eoJg4vLO7B1uzyqIq5jkYcgP+bo8/YCOb4bxPedwF5I D0W7QnA3fribF0P3r55+QM4scNlatxUY6X5iVraj8tA45VDLu4rdsOeODoXJHaLf7ys= X-Gm-Gg: ASbGncsPfqi4lJCAcnraghsZDyKeL+QW33nhZ0X6h5Ktk2n6rRaMa1aHT+6sNW3u0GL gAvviHxo8CirwtZ7MCtC2L0GpUv3keoazCGqKIBTO8GyTkiBCMtsezgdv5rW6SxyRS3b7YuiqGK zVmm2JhgOPBUR5Eok0fBOmTzNL/qQXxO6YaGSTZNACBu5eFaQQjeGzg2Mrb5piSYBI+gl3PVV0H ZFxpipxt65YgPEdf8Ucj8AwieR1IdBGN4D/I9PKCU3yEtcl7DqSMiP6RbyA1XL0dZU+iXBtM6UD gFGzSNuXkkJvoiG00fmyyEmzU4Xcb4gr8shcDT2PR2eIJ5s/tuXSpjJJizQSWp6WFq+wrxBun7z ReZHHMokMXCzkFxIqgw5RrhqZDugaIfjns2OYs3bDpSFNAqG4y20= X-Google-Smtp-Source: AGHT+IEK80UwgNjV22g47ZXnJP8YbgrgOlOSagQEfbQaiK/6SJsmQK5+2by+KwdInLbXIryPhytPug== X-Received: by 2002:a5d:5d0d:0:b0:3fb:9950:b9fe with SMTP id ffacd0b85a97d-4255781a8bbmr5534879f8f.47.1759422283145; Thu, 02 Oct 2025 09:24:43 -0700 (PDT) Received: from draig.lan ([185.126.160.19]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4255d8e9719sm4383031f8f.31.2025.10.02.09.24.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Oct 2025 09:24:42 -0700 (PDT) Received: from draig (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 663115F809; Thu, 02 Oct 2025 17:24:41 +0100 (BST) From: =?utf-8?Q?Alex_Benn=C3=A9e?= To: Daniel P. =?utf-8?Q?Berrang=C3=A9?= Cc: Gustavo Romero , qemu-devel@nongnu.org, thuth@redhat.com, qemu-arm@nongnu.org Subject: Re: [PATCH v5 4/9] tests/functional: Add GDB class In-Reply-To: ("Daniel P. =?utf-8?Q?Berrang?= =?utf-8?Q?=C3=A9=22's?= message of "Thu, 2 Oct 2025 14:11:54 +0100") References: <20251002020432.54443-1-gustavo.romero@linaro.org> <20251002020432.54443-5-gustavo.romero@linaro.org> User-Agent: mu4e 1.12.14-dev1; emacs 30.1 Date: Thu, 02 Oct 2025 17:24:41 +0100 Message-ID: <875xcxgtkm.fsf@draig.linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::42c; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x42c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org Sender: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org Daniel P. Berrang=C3=A9 writes: > On Thu, Oct 02, 2025 at 02:04:27AM +0000, Gustavo Romero wrote: >> Add GDB class, which provides methods to run GDB commands and capture >> their output. The GDB class is a wrapper around the pygdbmi module and >> interacts with GDB via GDB's machine interface (MI). >>=20 >> Acked-by: Thomas Huth >> Signed-off-by: Gustavo Romero >> --- >> tests/functional/qemu_test/__init__.py | 1 + >> tests/functional/qemu_test/gdb.py | 88 ++++++++++++++++++++++++++ >> 2 files changed, 89 insertions(+) >> create mode 100644 tests/functional/qemu_test/gdb.py > > >> diff --git a/tests/functional/qemu_test/gdb.py b/tests/functional/qemu_t= est/gdb.py >> new file mode 100644 >> index 0000000000..05e4c29c2a >> --- /dev/null >> +++ b/tests/functional/qemu_test/gdb.py >> @@ -0,0 +1,88 @@ >> +# SPDX-License-Identifier: GPL-2.0-or-later >> +# >> +# A simple interface module built around pygdbmi for handling GDB comma= nds. >> +# >> +# Copyright (c) 2025 Linaro Limited >> +# >> +# Author: >> +# Gustavo Romero >> +# >> +# This work is licensed under the terms of the GNU GPL, version 2 or >> +# later. See the COPYING file in the top-level directory. > > Please remove these two lines - they should not be included in any > newly authored files - SPDX alone is desired. I can clean that up when I pull this to save another round trip from Gustavo. > > If that is removed, then > > Reviewed-by: Daniel P. Berrang=C3=A9 > > > With regards, > Daniel --=20 Alex Benn=C3=A9e Virtualisation Tech Lead @ Linaro