Re: [PATCH 6/8] cpus: properly kick CPUs out of inner execution loop

["Alex Bennée" <alex.bennee@linaro.org>]

Paolo Bonzini <pbonzini@redhat.com> writes:

> Now that cpu_exit() actually kicks all accelerators, use it whenever
> the message to another thread is processed in qemu_wait_io_event()
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
<snip>
> --- a/hw/ppc/spapr_hcall.c
> +++ b/hw/ppc/spapr_hcall.c
> @@ -509,8 +509,8 @@ static target_ulong h_cede(PowerPCCPU *cpu, SpaprMachineState *spapr,
>      if (!cpu_has_work(cs)) {
>          cs->halted = 1;
>          cs->exception_index = EXCP_HLT;
> -        qatomic_set(&cs->exit_request, 1);
>          ppc_maybe_interrupt(env);
> +        cpu_exit(env);

Should be cs

>      }
>  
>      return H_SUCCESS;
> @@ -531,8 +531,8 @@ static target_ulong h_confer_self(PowerPCCPU *cpu)
>      }
>      cs->halted = 1;
>      cs->exception_index = EXCP_HALTED;
> -    qatomic_set(&cs->exit_request, 1);
>      ppc_maybe_interrupt(&cpu->env);
> +    cpu_exit(&cpu->env);

Should be cs

<snip>

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro