From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C63DEC3ABDD for ; Mon, 19 May 2025 21:22:45 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uH7w3-0000z6-P2; Mon, 19 May 2025 17:22:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uH7w2-0000yq-Kv for qemu-devel@nongnu.org; Mon, 19 May 2025 17:22:10 -0400 Received: from smtp-out2.suse.de ([2a07:de40:b251:101:10:150:64:2]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uH7w0-0005YP-P7 for qemu-devel@nongnu.org; Mon, 19 May 2025 17:22:10 -0400 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 86668204E6; Mon, 19 May 2025 21:22:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1747689726; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QWK1RLjS6vODHQ0XyqHSPVEDVi1HwoMyMkucXv6300U=; b=MM7UHxkfpTsr21/4SGrwQQlnspMs3Y8JOzsJ4Bv/qD3jIDSNzV4L/HF6YFiE/J34H4HOWp YDWz8SKWKnLBUyttGvl65VJer6sxkZulDOJXGVAA44r6msBPpwcdC8sSTdzH9kmgn8HjdF 5TpYqeuvfjsuGlsc86MtldH+IW6RubQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1747689726; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QWK1RLjS6vODHQ0XyqHSPVEDVi1HwoMyMkucXv6300U=; b=TRC/JH4RpueJxjVcoChAO4cAjeumRTbOoMOtqL2lQEdSjzHgcN5pUsLmHdekiGIKghZ7dS 2y8x8R1sUW/N7OAg== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=MM7UHxkf; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="TRC/JH4R" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1747689726; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QWK1RLjS6vODHQ0XyqHSPVEDVi1HwoMyMkucXv6300U=; b=MM7UHxkfpTsr21/4SGrwQQlnspMs3Y8JOzsJ4Bv/qD3jIDSNzV4L/HF6YFiE/J34H4HOWp YDWz8SKWKnLBUyttGvl65VJer6sxkZulDOJXGVAA44r6msBPpwcdC8sSTdzH9kmgn8HjdF 5TpYqeuvfjsuGlsc86MtldH+IW6RubQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1747689726; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QWK1RLjS6vODHQ0XyqHSPVEDVi1HwoMyMkucXv6300U=; b=TRC/JH4RpueJxjVcoChAO4cAjeumRTbOoMOtqL2lQEdSjzHgcN5pUsLmHdekiGIKghZ7dS 2y8x8R1sUW/N7OAg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id F38DD13A30; Mon, 19 May 2025 21:22:05 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id i2HkK/2gK2jVJQAAD6G6ig (envelope-from ); Mon, 19 May 2025 21:22:05 +0000 From: Fabiano Rosas To: Steve Sistare , qemu-devel@nongnu.org Cc: Alex Williamson , Cedric Le Goater , Yi Liu , Eric Auger , Zhenzhong Duan , "Michael S. Tsirkin" , Marcel Apfelbaum , Peter Xu , Steve Sistare Subject: Re: [PATCH V3 25/42] migration: cpr_get_fd_param helper In-Reply-To: <1747063973-124548-26-git-send-email-steven.sistare@oracle.com> References: <1747063973-124548-1-git-send-email-steven.sistare@oracle.com> <1747063973-124548-26-git-send-email-steven.sistare@oracle.com> Date: Mon, 19 May 2025 18:22:03 -0300 Message-ID: <875xhw70uc.fsf@suse.de> MIME-Version: 1.0 Content-Type: text/plain X-Spamd-Result: default: False [-1.98 / 50.00]; BAYES_HAM(-1.97)[94.87%]; SUSPICIOUS_RECIPS(1.50)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; URIBL_BLOCKED(0.00)[oracle.com:email,suse.de:mid,suse.de:email,suse.de:dkim,imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; TO_DN_SOME(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; FREEMAIL_CC(0.00)[redhat.com,intel.com,gmail.com,oracle.com]; DKIM_TRACE(0.00)[suse.de:+]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; MID_RHS_MATCH_FROM(0.00)[]; RCPT_COUNT_SEVEN(0.00)[11]; RCVD_COUNT_TWO(0.00)[2]; FROM_HAS_DN(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; TAGGED_RCPT(0.00)[]; MISSING_XM_UA(0.00)[]; DWL_DNSWL_BLOCKED(0.00)[suse.de:dkim]; ASN(0.00)[asn:25478, ipnet:::/0, country:RU]; RCVD_VIA_SMTP_AUTH(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:mid, suse.de:email, suse.de:dkim, imap1.dmz-prg2.suse.org:rdns, imap1.dmz-prg2.suse.org:helo, oracle.com:email] X-Rspamd-Action: no action X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Rspamd-Queue-Id: 86668204E6 Received-SPF: pass client-ip=2a07:de40:b251:101:10:150:64:2; envelope-from=farosas@suse.de; helo=smtp-out2.suse.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Steve Sistare writes: > Add the helper function cpr_get_fd_param, to use when preserving > a file descriptor that is opened externally and passed to QEMU. > cpr_get_fd_param returns a descriptor number either from a QEMU > command-line parameter, from a getfd command, or from CPR state. > > When a descriptor is passed to new QEMU via SCM_RIGHTS, its number > changes. Hence, during CPR, the command-line parameter is ignored > in new QEMU, and over-ridden by the value found in CPR state. > > Similarly, if the descriptor was originally specified by a getfd > command in old QEMU, the fd number is not known outside of QEMU, > and it changes when sent to new QEMU via SCM_RIGHTS. Hence the > user cannot send getfd to new QEMU, but when the user sends a > hotplug command that references the fd, cpr_get_fd_param finds > its value in CPR state. > > Signed-off-by: Steve Sistare Reviewed-by: Fabiano Rosas