From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E4E9CC3ABC9 for ; Thu, 15 May 2025 13:02:46 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uFYEJ-0005DH-Pr; Thu, 15 May 2025 09:02:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uFYEF-00053n-Bu for qemu-devel@nongnu.org; Thu, 15 May 2025 09:02:28 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uFYED-0001CB-EQ for qemu-devel@nongnu.org; Thu, 15 May 2025 09:02:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747314144; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cZ1tz3XlQsOvZzC6xq/m+22FocNZ6aBalbh6ECN310k=; b=dCsSOtQgbLjugz47FQQDLiJ6AOjoPcyOeWCuOeuUW922PsAaWiaHMvkITHT5JenOIvDxJ8 IxH6PbYHV1aoXly5OI2HexnlAPd5CLCajCDuVilzFyBqsZ89ADRg6KOJtPhuqi1wuoOEee exX6gd8LKCLFDFAbKzHbRNL9NEXLTY4= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-394-TenvsM4wNrmQy4FYsGcj5A-1; Thu, 15 May 2025 09:02:23 -0400 X-MC-Unique: TenvsM4wNrmQy4FYsGcj5A-1 X-Mimecast-MFC-AGG-ID: TenvsM4wNrmQy4FYsGcj5A_1747314142 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id ABE311800980; Thu, 15 May 2025 13:02:21 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.45.242.27]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D4F1319560AD; Thu, 15 May 2025 13:02:20 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 504ED21E6768; Thu, 15 May 2025 15:02:18 +0200 (CEST) From: Markus Armbruster To: Mario Fleischmann Cc: qemu-devel@nongnu.org, alex.bennee@linaro.org, philmd@linaro.org, christian.boenig@lauterbach.com Subject: Re: [PATCH v2 07/20] mcd: Implement target initialization API In-Reply-To: <20250430052741.21145-8-mario.fleischmann@lauterbach.com> (Mario Fleischmann's message of "Wed, 30 Apr 2025 07:27:28 +0200") References: <20250430052741.21145-1-mario.fleischmann@lauterbach.com> <20250430052741.21145-8-mario.fleischmann@lauterbach.com> Date: Thu, 15 May 2025 15:02:18 +0200 Message-ID: <875xi2yqlh.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -37 X-Spam_score: -3.8 X-Spam_bar: --- X-Spam_report: (-3.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.686, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Mario Fleischmann writes: > The target initialization API ensures that the requested and provided > MCD versions are compatible. > > * implement mcd_initialize_f and mcd_qry_error_info_f in mcdserver > * implement QMP stub functionality > * add QTest > > Thanks to the QMP integration in QTest, function arguments and results > can be (de)serialized automatically. > > Signed-off-by: Mario Fleischmann [...] > diff --git a/qapi/mcd.json b/qapi/mcd.json > index 701fd03..7b42a74 100644 > --- a/qapi/mcd.json > +++ b/qapi/mcd.json > @@ -4,3 +4,186 @@ > ## > # = Multi-Core Debug (MCD) API > ## > + > + > +## > +# == Definition of Structures > +## > + > + > +## > +# @MCDAPIVersion: > +# > +# Structure type containing the MCD API version information of the tool. > +# > +# @v-api-major: API major version. > +# @v-api-minor: API minor version. > +# @author: API name of the author of this MCD API version. > +# > +# Since: 9.1 > +## > +{ 'struct': 'MCDAPIVersion', > + 'data': { > + 'v-api-major': 'uint16', > + 'v-api-minor': 'uint16', > + 'author': 'str' } } > + > + > +## > +# @MCDImplVersionInfo: > +# > +# Structure type containing the MCD API implementation information. > +# > +# @v-api: Implemented API version. > +# @v-imp-major: Major version number of this implementation. > +# @v-imp-minor: Minor version number of this implementation. > +# @v-imp-build: Build number of this implementation. > +# @vendor: Name of vendor of the implementation. > +# @date: String from __DATE__ macro at compile time. > +# > +# Since: 9.1 > +## > +{ 'struct': 'MCDImplVersionInfo', > + 'data': { > + 'v-api' : 'MCDAPIVersion', > + 'v-imp-major': 'uint16', > + 'v-imp-minor': 'uint16', > + 'v-imp-build': 'uint16', > + 'vendor' : 'str', > + 'date' : 'str' } } > + > + > +## > +# @MCDErrorInfo: > +# > +# Structure type containing the error status and error event notification. > +# > +# @return-status: Return status from the last API call. > +# @error-code: Detailed error code from the last API call. > +# @error-events: Detailed event code from the last API call. > +# @error-str: Detailed error text string from the last API call. > +# > +# Since: 9.1 > +## > +{ 'struct': 'MCDErrorInfo', > + 'data': { > + 'return-status': 'uint32', > + 'error-code' : 'uint32', > + 'error-events' : 'uint32', > + 'error-str' : 'str' }} > + > + > +## > +# == Target Initialization API > +## > + > + > +## > +# @MCDInitializeResult: > +# > +# Return value of @mcd-initialize. > +# > +# @return-status: Return code. > +# > +# @impl-info: Information about the QEMU build, its version and the version of > +# the implemented MCD API. > +# > +# Since: 9.1 > +## > +{ 'struct': 'MCDInitializeResult', > + 'data': { > + 'return-status': 'uint32', > + '*impl-info' : 'MCDImplVersionInfo' } } > + > + > +## > +# @mcd-initialize: > +# > +# Function initializing the interaction between a tool-side implementation and > +# target-side implementation. > +# > +# @version-req: MCD API version as requested by an upper layer. > +# > +# Returns: @MCDInitializeResult > +# > +# Since: 9.1 > +# > +# .. qmp-example:: > +# :title: Check compatibility with MCD server > +# > +# -> { "execute": "mcd-initialize", > +# "arguments": { "version-req": { "v-api-major": 1, > +# "v-api-minor": 1, > +# "author": "" } } } > +# <- { > +# "return": { > +# "impl-info": { > +# "v-api": { > +# "v-api-minor": 1, > +# "v-api-major": 1, > +# "author": "QEMU Release" > +# }, > +# "vendor": "QEMU", > +# "v-imp-minor": 2, > +# "v-imp-major": 9, > +# "v-imp-build": 0, > +# "date": "Dec 18 2024" > +# }, > +# "return-status": 0 > +# } > +# } > +## > +{ 'command': 'mcd-initialize', > + 'data': { 'version-req': 'MCDAPIVersion' }, > + 'returns': 'MCDInitializeResult' } > + > + > +## > +# @mcd-exit: > +# > +# Function cleaning up all core and server connections from a tool. > +# > +# Since: 9.1 > +## > +{ 'command': 'mcd-exit' } > + > + > +## > +# == Core Connection API > +## > + > + > +## > +# @mcd-qry-error-info: > +# > +# Function allowing the access to detailed error and/or event information after > +# an API call. > +# > +# Returns: @MCDErrorInfo > +# > +# Since: 9.1 > +# > +# .. qmp-example:: > +# :title: Incompatible MCD versions > +# > +# -> { "execute": "mcd-initialize", > +# "arguments": { "version-req": { "v-api-major": 2, > +# "v-api-minor": 0, > +# "author": "" } } } > +# <- { > +# "return": { > +# "return-status": 3 > +# } > +# } > +# -> { "execute": "mcd-qry-error-info" } > +# <- { > +# "return": { > +# "error-str": "incompatible versions", > +# "error-code": 3840, > +# "error-events": 0, > +# "return-status": 3 > +# } > +# } > +## > +{ 'command': 'mcd-qry-error-info', > + 'returns': 'MCDErrorInfo' } You define some types under "Definition of Structures", and some elsewhere. How do you decide what goes where? Hmm, looks like you mirror mcd/mcd_api.h. Correct? [...]