From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 227DB246326 for ; Tue, 13 May 2025 15:57:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747151824; cv=none; b=CeQt+ELee+I9T+5+jPuOa4c55MzO31WWYi7sSzOZpWp/43luNgRMe40tah3Zqsh/E/qHXzli2JAK2oFB1s3dvfrQWSUOsaaskDivtaUJQpYC1ECpFfGDNh0CduaDeSECdDQS0DkwQcuqy1fEJ0NYrTHYwzR1NaALCEoarvtg1I0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747151824; c=relaxed/simple; bh=+NIiUEJPN2RDQsBXtaOyprTrd6+qmqtYcS2yrq9Jl+Y=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=c+NdXP90zWtVd5drGZ+jWk4SortVTll+XyHcNHfHkTEPcnH3D2CXzQLzpVNQnohB+A5QW+6xD+bztwP36X5ViwMHySrlMysWJm6CPLVutZoEp5uh/yPESkfJAW7l5bHaoWxQQ99G9/lchD2CYIZAe+4n4xujnwyS1H8t/Q6hyf8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=ePqPqhg4; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ePqPqhg4" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747151820; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=R4b+q5DZaq+brNYajdSGnOlZv1xADptKpVhan1d0w/M=; b=ePqPqhg47lpW8yfebl/mRuVUTJAgikobszBBQQlUam9V0Tidqhau+BHNzfG7/2Zim9X7aZ p110h3OAH+18Po9yXWXLkqXDg7JOShVWV5BBN6KOsvmkmphzW49snBdHpGJyAL919XhEqC lk/ow/4CkOx8xtOrS1f9b5rmE59keLU= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-344-VdcnpdnAO2uV663BGQNMMg-1; Tue, 13 May 2025 11:56:56 -0400 X-MC-Unique: VdcnpdnAO2uV663BGQNMMg-1 X-Mimecast-MFC-AGG-ID: VdcnpdnAO2uV663BGQNMMg_1747151812 Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 5CB36195DE45; Tue, 13 May 2025 15:56:51 +0000 (UTC) Received: from localhost (dhcp-192-216.str.redhat.com [10.33.192.216]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id ECD791955E74; Tue, 13 May 2025 15:56:48 +0000 (UTC) From: Cornelia Huck To: =?utf-8?Q?Daniel_P=2E_Berrang=C3=A9?= Cc: eric.auger.pro@gmail.com, eric.auger@redhat.com, qemu-devel@nongnu.org, qemu-arm@nongnu.org, kvmarm@lists.linux.dev, peter.maydell@linaro.org, richard.henderson@linaro.org, alex.bennee@linaro.org, maz@kernel.org, oliver.upton@linux.dev, sebott@redhat.com, shameerali.kolothum.thodi@huawei.com, armbru@redhat.com, abologna@redhat.com, jdenemar@redhat.com, agraf@csgraf.de, shahuang@redhat.com, mark.rutland@arm.com, philmd@linaro.org, pbonzini@redhat.com Subject: Re: [PATCH for-10.1 v5 02/13] arm/cpu: Store aa64isar0/aa64zfr0 into the idregs arrays In-Reply-To: Organization: "Red Hat GmbH, Sitz: Werner-von-Siemens-Ring 12, D-85630 Grasbrunn, Handelsregister: Amtsgericht =?utf-8?Q?M=C3=BCnchen=2C?= HRB 153243, =?utf-8?Q?Gesch=C3=A4ftsf=C3=BChrer=3A?= Ryan Barnhart, Charles Cachera, Michael O'Neill, Amy Ross" References: <20250409144304.912325-1-cohuck@redhat.com> <20250409144304.912325-3-cohuck@redhat.com> User-Agent: Notmuch/0.38.3 (https://notmuchmail.org) Date: Tue, 13 May 2025 17:56:46 +0200 Message-ID: <875xi4pkqp.fsf@redhat.com> Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 On Tue, May 13 2025, Daniel P. Berrang=C3=A9 wrote: > On Wed, Apr 09, 2025 at 04:42:53PM +0200, Cornelia Huck wrote: >> From: Eric Auger >>=20 >> Also add kvm add accessors for storing host features into idregs. >>=20 >> Reviewed-by: Richard Henderson >> Reviewed-by: Sebastian Ott >> Signed-off-by: Eric Auger >> Signed-off-by: Cornelia Huck >> --- >> target/arm/cpu-features.h | 57 ++++++++++++++++++++------------------- >> target/arm/cpu-sysregs.h | 4 +++ >> target/arm/cpu.c | 10 +++---- >> target/arm/cpu.h | 2 -- >> target/arm/cpu64.c | 8 +++--- >> target/arm/helper.c | 6 +++-- >> target/arm/hvf/hvf.c | 3 ++- >> target/arm/kvm.c | 30 ++++++++++++++++++--- >> target/arm/tcg/cpu64.c | 44 ++++++++++++++++++------------ >> 9 files changed, 101 insertions(+), 63 deletions(-) > >> diff --git a/target/arm/cpu-sysregs.h b/target/arm/cpu-sysregs.h >> index 7877a3b06a8e..e89a1105904c 100644 >> --- a/target/arm/cpu-sysregs.h >> +++ b/target/arm/cpu-sysregs.h >> @@ -39,4 +39,8 @@ extern const uint32_t id_register_sysreg[NUM_ID_IDX]; >>=20=20 >> int get_sysreg_idx(ARMSysRegs sysreg); >>=20=20 >> +#ifdef CONFIG_KVM >> +uint64_t idregs_sysreg_to_kvm_reg(ARMSysRegs sysreg); >> +#endif > > This breaks the build when KVM is disabled, and/or not available > on the build target architecture > > In file included from ../target/arm/cpu.h:35, > from /var/home/berrange/src/virt/qemu/include/hw/arm/dig= ic.h:21, > from ../hw/arm/digic_boards.c:31: > /var/home/berrange/src/virt/qemu/target/arm/cpu-sysregs.h:42:8: error: at= tempt to use poisoned =E2=80=98CONFIG_KVM=E2=80=99 > 42 | #ifdef CONFIG_KVM > | ^ > In file included from /var/home/berrange/src/virt/qemu/include/exec/poiso= n.h:7, > from /var/home/berrange/src/virt/qemu/include/qemu/osdep= .h:38, > from ../hw/arm/digic_boards.c:26: > ./config-poison.h:185:20: note: poisoned here > 185 | #pragma GCC poison CONFIG_KVM > | ^~~~~~~~~~ > ninja: build stopped: subcommand failed. I have already fixed that one in v6.