All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: "Philippe Mathieu-Daudé" <philmd@linaro.org>,
	qemu-devel@nongnu.org, "John Snow" <jsnow@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Michael Roth" <michael.roth@amd.com>,
	"Daniel P.Berrangé" <berrange@redhat.com>,
	"Stefan Hajnoczi" <stefanha@gmail.com>
Subject: Re: [PATCH] Drop support for Python 3.8
Date: Wed, 30 Apr 2025 12:45:09 +0200	[thread overview]
Message-ID: <875ximdj2i.fsf@pond.sub.org> (raw)
In-Reply-To: <5d0e0b69-cbbc-4fa4-a847-fdc8603a8122@redhat.com> (Thomas Huth's message of "Wed, 30 Apr 2025 09:57:24 +0200")

Thomas Huth <thuth@redhat.com> writes:

>  Hi!
>
> On 25/04/2025 17.13, Markus Armbruster wrote:
>> Philippe Mathieu-Daudé <philmd@linaro.org> writes:
>>> On 25/4/25 14:07, Thomas Huth wrote:
>>>> From: Thomas Huth <thuth@redhat.com>
>>>> Python 3.8 went "end of life" in October 2024 and Fedora 42 dropped
>>>> this version already, so the "python" CI job is currently failing.
>>>> Thus it's time to drop support for this Python version in QEMU, too.
> ...
>>>>    if test -z "${PYTHON}"; then
>>>>        # A bare 'python' is traditionally python 2.x, but some distros
>>>>        # have it as python 3.x, so check in both places.
>>>> -    for binary in python3 python python3.12 python3.11 \
>>>> -                          python3.10 python3.9 python3.8; do
>>>> +    for binary in python3 python python3.13 python3.12 python3.11 \
>>>
>>> The 3.13 test was missing in commit 45b14be9b63 ("python: enable testing
>>> for 3.13"). Preferably adding in a preliminary commit, otherwise mention
>>> in this patch description
>
> Yes, I'll add a sentence to the patch description!
>
>>> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>
> Thanks!
>
>> Yes.  The patch looks good to me otherwise.  But John knows a lot more
>> about this stuff than I do; would be good to get his blessing.
>
> Seems like John is currently away from keyboard / busy with other stuff? I think we should go ahead and include this patch to get the CI green again, so I'll add it to my next pull request. If there is still anything that needs to be done on top, it can be done in another patch later.

Makes sense.  I assume you'll amend the commit message to address
Philippe's review.



  reply	other threads:[~2025-04-30 10:45 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-25 12:07 [PATCH] Drop support for Python 3.8 Thomas Huth
2025-04-25 12:12 ` Daniel P. Berrangé
2025-04-25 13:03 ` Philippe Mathieu-Daudé
2025-04-25 15:13   ` Markus Armbruster
2025-04-30  7:57     ` Thomas Huth
2025-04-30 10:45       ` Markus Armbruster [this message]
2025-05-05 22:49         ` John Snow
2025-05-06 13:56           ` Paolo Bonzini
2025-05-06 14:16           ` Thomas Huth
2025-05-06 19:49             ` John Snow
2025-05-07  5:35               ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875ximdj2i.fsf@pond.sub.org \
    --to=armbru@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=berrange@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=michael.roth@amd.com \
    --cc=pbonzini@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@gmail.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.