Re: [PATCH] [for-10.1] qapi/block-core: derpecate some block-job- APIs

[Markus Armbruster <armbru@redhat.com>]

Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru> writes:

> On 04.04.25 17:13, Markus Armbruster wrote:

[...]

>> So, auto-finalize=true is silently ignored when another job in the same
>> transaction has auto-finalize=false?
>
> Yes, at least, it looks like so:
>
> static void job_completed_txn_success_locked(Job *job)
> {
>
> [...]
>
>      /* If no jobs need manual finalization, automatically do so */
>      if (job_txn_apply_locked(job, job_needs_finalize_locked) == 0) {
>          job_do_finalize_locked(job);
>      }
> }

Silently ignoring what the user specified is not okay whether the user's
instructions make sense or not.

Fixing this UI bug would break usage that relies on it.  Should we care?

[...]