From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AFE2DC02187 for ; Thu, 16 Jan 2025 14:24:33 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tYQmS-0007gr-6K; Thu, 16 Jan 2025 09:23:32 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tYQmQ-0007gi-MI for qemu-devel@nongnu.org; Thu, 16 Jan 2025 09:23:30 -0500 Received: from smtp-out2.suse.de ([2a07:de40:b251:101:10:150:64:2]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tYQmP-0006em-51 for qemu-devel@nongnu.org; Thu, 16 Jan 2025 09:23:30 -0500 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 94D621F796; Thu, 16 Jan 2025 14:23:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1737037406; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HPuVsNK4Heej1uZ/S6iv4YyXmJX5xL30N2O/SUypzvI=; b=KM5B6SvTCdD2gRxcaT+u6HD9wV01qq/C30JXyjxcQQpFEh5B63VnWJfDL9xiYM9EEPgOis ekPUtOPk0d4xKRIzEJRYuLtNWKQ8gY5PqcjVRRAU0RTzFcnfdWj2bH48nvID+HtKivlXut 5GY6RhkmeWYr8HIMSf3dfLJ6/JMXqy8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1737037406; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HPuVsNK4Heej1uZ/S6iv4YyXmJX5xL30N2O/SUypzvI=; b=KV5k9y0RYbf7Ua+NO8PTYRMLRhao++sDEi+Pq3/4zGOIhFL2l+iTbvXd+upV2MWFALU6Bm yrJIYSDNRWD+rQAQ== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=KM5B6SvT; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=KV5k9y0R DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1737037406; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HPuVsNK4Heej1uZ/S6iv4YyXmJX5xL30N2O/SUypzvI=; b=KM5B6SvTCdD2gRxcaT+u6HD9wV01qq/C30JXyjxcQQpFEh5B63VnWJfDL9xiYM9EEPgOis ekPUtOPk0d4xKRIzEJRYuLtNWKQ8gY5PqcjVRRAU0RTzFcnfdWj2bH48nvID+HtKivlXut 5GY6RhkmeWYr8HIMSf3dfLJ6/JMXqy8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1737037406; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HPuVsNK4Heej1uZ/S6iv4YyXmJX5xL30N2O/SUypzvI=; b=KV5k9y0RYbf7Ua+NO8PTYRMLRhao++sDEi+Pq3/4zGOIhFL2l+iTbvXd+upV2MWFALU6Bm yrJIYSDNRWD+rQAQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 0E46F13A57; Thu, 16 Jan 2025 14:23:25 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id cS2YL10WiWdRFgAAD6G6ig (envelope-from ); Thu, 16 Jan 2025 14:23:25 +0000 From: Fabiano Rosas To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Cc: Thomas Huth , Peter Xu , "Michael S. Tsirkin" , Markus Armbruster , Paolo Bonzini , =?utf-8?Q?Daniel_P_=2E_Berrang=C3=A9?= , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Subject: Re: [RFC PATCH] hw/rtc/mc146818rtc: Drop pre-v3 migration stream support In-Reply-To: <20250115210048.25396-1-philmd@linaro.org> References: <20250115210048.25396-1-philmd@linaro.org> Date: Thu, 16 Jan 2025 11:23:23 -0300 Message-ID: <875xmeg7ms.fsf@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 94D621F796 X-Rspamd-Action: no action X-Spamd-Result: default: False [-4.22 / 50.00]; BAYES_HAM(-2.71)[98.72%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_TLS_ALL(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; MISSING_XM_UA(0.00)[]; TO_DN_SOME(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; MID_RHS_MATCH_FROM(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_SEVEN(0.00)[9]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:mid,suse.de:email,linaro.org:email]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Server: rspamd1.dmz-prg2.suse.org Received-SPF: pass client-ip=2a07:de40:b251:101:10:150:64:2; envelope-from=farosas@suse.de; helo=smtp-out2.suse.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Philippe Mathieu-Daud=C3=A9 writes: > mc146818rtc's migration stream is at version 3 since commit > 56038ef6234 ("RTC: Update the RTC clock only when reading it") > from 12 years ago, released in QEMU v1.3.0! > No versioned machines are that old, we can safely remove > support for older streams and the qdev_set_legacy_instance_id() > call. > > Signed-off-by: Philippe Mathieu-Daud=C3=A9 > --- > RFC to check whether my reasoning is correct or not. > > Goal is to remove qdev_set_legacy_instance_id() globally. Go for it Reviewed-by: Fabiano Rosas