All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: Gustavo Sousa <gustavo.sousa@intel.com>,
	intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/display: remove unused for_each_crtc()
Date: Tue, 03 Dec 2024 12:36:15 +0200	[thread overview]
Message-ID: <875xo15a00.fsf@intel.com> (raw)
In-Reply-To: <173314475855.2905.12006003723478227624@intel.com>

On Mon, 02 Dec 2024, Gustavo Sousa <gustavo.sousa@intel.com> wrote:
> Quoting Jani Nikula (2024-12-02 09:54:37-03:00)
>>This is essentially a duplicate of drm_for_each_crtc() anyway. Remove.
>
> And it looks like commit 08dfd243abac ("drm/i915: Clean up
> intel_fbdev_init_bios() a bit") was the one that made it unused.
>
>>
>>Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> Reviewed-by: Gustavo Sousa <gustavo.sousa@intel.com>

Thanks for the review, pushed to din.

BR,
Jani.

>
>>---
>> drivers/gpu/drm/i915/display/intel_display.h | 3 ---
>> 1 file changed, 3 deletions(-)
>>
>>diff --git a/drivers/gpu/drm/i915/display/intel_display.h b/drivers/gpu/drm/i915/display/intel_display.h
>>index caef04f655c5..49a246feb1ae 100644
>>--- a/drivers/gpu/drm/i915/display/intel_display.h
>>+++ b/drivers/gpu/drm/i915/display/intel_display.h
>>@@ -238,9 +238,6 @@ enum phy_fia {
>>         for ((__phy) = PHY_A; (__phy) < I915_MAX_PHYS; (__phy)++)        \
>>                 for_each_if((__phys_mask) & BIT(__phy))
>> 
>>-#define for_each_crtc(dev, crtc) \
>>-        list_for_each_entry(crtc, &(dev)->mode_config.crtc_list, head)
>>-
>> #define for_each_intel_plane(dev, intel_plane) \
>>         list_for_each_entry(intel_plane,                        \
>>                             &(dev)->mode_config.plane_list,        \
>>-- 
>>2.39.5
>>

-- 
Jani Nikula, Intel

  reply	other threads:[~2024-12-03 10:36 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-02 12:54 [PATCH] drm/i915/display: remove unused for_each_crtc() Jani Nikula
2024-12-02 13:03 ` ✓ CI.Patch_applied: success for " Patchwork
2024-12-02 13:03 ` ✓ CI.checkpatch: " Patchwork
2024-12-02 13:04 ` ✓ CI.KUnit: " Patchwork
2024-12-02 13:05 ` [PATCH] " Gustavo Sousa
2024-12-03 10:36   ` Jani Nikula [this message]
2024-12-02 13:29 ` ✓ CI.Build: success for " Patchwork
2024-12-02 13:32 ` ✓ CI.Hooks: " Patchwork
2024-12-02 13:33 ` ✗ CI.checksparse: warning " Patchwork
2024-12-02 13:55 ` ✓ Xe.CI.BAT: success " Patchwork
2024-12-02 14:30 ` ✓ i915.CI.BAT: " Patchwork
2024-12-02 14:56 ` ✗ Xe.CI.Full: failure " Patchwork
2024-12-02 17:30 ` ✗ i915.CI.Full: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875xo15a00.fsf@intel.com \
    --to=jani.nikula@intel.com \
    --cc=gustavo.sousa@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.