All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sam James <sam@gentoo.org>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: <git@vger.kernel.org>,  Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 0/2] C23 compatibility
Date: Sun, 17 Nov 2024 02:43:11 +0000	[thread overview]
Message-ID: <875xompolc.fsf@gentoo.org> (raw)
In-Reply-To: <20241117013149.576671-1-sandals@crustytoothpaste.net> (brian m. carlson's message of "Sun, 17 Nov 2024 01:31:47 +0000")

"brian m. carlson" <sandals@crustytoothpaste.net> writes:

> Most of our code works fine in C23, but there are some new additions to
> the standard that conflict with either our struct tags or functions.
> With this series, the code compiles and passes the testsuite with
> -std=c23 on GCC 14.2.0.
>
> brian m. carlson (2):
>   index-pack: rename struct thread_local
>   reflog: rename unreachable
>
>  builtin/index-pack.c | 10 +++++-----
>  reflog.c             |  4 ++--
>  2 files changed, 7 insertions(+), 7 deletions(-)

Thank you for the fast response! It both works and the fixes look
correct.

For the series:
Tested-by: Sam James <sam@gentoo.org>
Reviewed-by: Sam James <sam@gentoo.org>

  parent reply	other threads:[~2024-11-17  2:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-16 23:18 Build failure with -std=gnu23 (GCC 15 default) Sam James
2024-11-17  1:31 ` [PATCH 0/2] C23 compatibility brian m. carlson
2024-11-17  1:31   ` [PATCH 1/2] index-pack: rename struct thread_local brian m. carlson
2024-11-17  1:31   ` [PATCH 2/2] reflog: rename unreachable brian m. carlson
2024-11-17  2:43   ` Sam James [this message]
2024-11-18  7:45   ` [PATCH 0/2] C23 compatibility Patrick Steinhardt
2024-11-18  9:58     ` Jeff King
2024-11-18 22:11     ` brian m. carlson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875xompolc.fsf@gentoo.org \
    --to=sam@gentoo.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=sandals@crustytoothpaste.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.