From: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
To: John Garry <john.g.garry@oracle.com>, linux-ext4@vger.kernel.org
Cc: Theodore Ts'o <tytso@mit.edu>, Jan Kara <jack@suse.cz>,
"Darrick J . Wong" <djwong@kernel.org>,
Christoph Hellwig <hch@infradead.org>,
Ojaswin Mujoo <ojaswin@linux.ibm.com>,
Dave Chinner <david@fromorbit.com>,
linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v2 4/4] ext4: Do not fallback to buffered-io for DIO atomic write
Date: Tue, 29 Oct 2024 14:52:27 +0530 [thread overview]
Message-ID: <875xpbmffw.fsf@gmail.com> (raw)
In-Reply-To: <fff46380-1e01-473d-860e-19d5a02a7d1c@oracle.com>
John Garry <john.g.garry@oracle.com> writes:
> On 27/10/2024 18:17, Ritesh Harjani (IBM) wrote:
>> iomap can return -ENOTBLK if pagecache invalidation fails.
>> Let's make sure if -ENOTBLK is ever returned for atomic
>> writes than we fail the write request (-EIO) instead of
>> fallback to buffered-io.
>>
>> Reviewed-by: Darrick J. Wong <djwong@kernel.org>
>> Signed-off-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
>
> I am not sure if you plan on dropping this patch...
>
As discussed in the other thread, EXT4 has got a fallback to buffered-io
logic at certain places including during short DIO writes unlike XFS
which never fallsback to buffered-io in case of short DIO writes.
Let me send another patch for this one.
Thanks for the review.
-ritesh
prev parent reply other threads:[~2024-10-29 9:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-27 18:17 [PATCH v2 0/4] ext4: Add atomic writes support for DIO Ritesh Harjani (IBM)
2024-10-27 18:17 ` [PATCH v2 1/4] ext4: Add statx support for atomic writes Ritesh Harjani (IBM)
2024-10-29 8:54 ` John Garry
2024-10-29 9:29 ` Ritesh Harjani
2024-10-29 15:27 ` Ritesh Harjani
2024-10-27 18:17 ` [PATCH v2 2/4] ext4: Check for atomic writes support in write iter Ritesh Harjani (IBM)
2024-10-29 8:55 ` John Garry
2024-10-27 18:17 ` [PATCH v2 3/4] ext4: Support setting FMODE_CAN_ATOMIC_WRITE Ritesh Harjani (IBM)
2024-10-29 8:56 ` John Garry
2024-10-27 18:17 ` [PATCH v2 4/4] ext4: Do not fallback to buffered-io for DIO atomic write Ritesh Harjani (IBM)
2024-10-29 8:57 ` John Garry
2024-10-29 9:22 ` Ritesh Harjani [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875xpbmffw.fsf@gmail.com \
--to=ritesh.list@gmail.com \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=john.g.garry@oracle.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=ojaswin@linux.ibm.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.