From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: "José Roberto de Souza" <jose.souza@intel.com>
Cc: <igt-dev@lists.freedesktop.org>
Subject: Re: [PATCH i-g-t v2 3/4] xe/oa: Update scripts to support BMG
Date: Tue, 03 Sep 2024 12:52:25 -0700 [thread overview]
Message-ID: <875xrczf9i.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20240903132436.8337-3-jose.souza@intel.com>
On Tue, 03 Sep 2024 06:24:35 -0700, José Roberto de Souza wrote:
>
Thanks for the patches Jose. This is also:
Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
Though one more change is needed, at least in IGT, to use BMG, here:
In lib/xe/xe_oa.c:
struct intel_xe_perf *
intel_xe_perf_for_devinfo(uint32_t device_id,
{
...
} else if (intel_graphics_ver(device_id) >= IP_VER(20, 0)) {
intel_xe_perf_load_metrics_lnl(perf);
...
}
If this is not needed for Mesa, I can make the change for IGT. But for now
this series is R-b'd.
next prev parent reply other threads:[~2024-09-03 20:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-03 13:24 [PATCH i-g-t v2 1/4] tests/xe_oa: Drop TestOa from metric_set() José Roberto de Souza
2024-09-03 13:24 ` [PATCH i-g-t v2 2/4] xe/oa: Update oa-lnl.xml José Roberto de Souza
2024-09-03 19:48 ` Dixit, Ashutosh
2024-09-03 13:24 ` [PATCH i-g-t v2 3/4] xe/oa: Update scripts to support BMG José Roberto de Souza
2024-09-03 19:52 ` Dixit, Ashutosh [this message]
2024-09-03 20:55 ` Souza, Jose
2024-09-03 13:24 ` [PATCH i-g-t v2 4/4] xe/oa: Add oa-bmg.xml José Roberto de Souza
2024-09-03 19:48 ` Dixit, Ashutosh
2024-09-03 19:48 ` [PATCH i-g-t v2 1/4] tests/xe_oa: Drop TestOa from metric_set() Dixit, Ashutosh
2024-09-03 21:10 ` ✓ CI.xeBAT: success for series starting with [i-g-t,v2,1/4] tests/xe_oa: Drop TestOa from metric_set() (rev2) Patchwork
2024-09-03 21:16 ` ✓ Fi.CI.BAT: " Patchwork
2024-09-04 0:07 ` ✓ CI.xeFULL: " Patchwork
2024-09-05 6:17 ` ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875xrczf9i.wl-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=jose.souza@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.