All of lore.kernel.org
 help / color / mirror / Atom feed
From: Toon claes <toon@iotcl.com>
To: Justin Tobler <jltobler@gmail.com>, Toon Claes <toon@iotcl.com>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH v2 1/3] clone: remove double bundle list clear code
Date: Fri, 02 Aug 2024 17:45:34 +0200	[thread overview]
Message-ID: <875xsj9bdt.fsf@gitlab.com> (raw)
In-Reply-To: <ypkmgjgobu2tn36o7qzultltknaz35qysrfe4y4kce67uysdxk@edmxls7p36mx>

Justin Tobler <jltobler@gmail.com> writes:

> From the commit message though, I thought the added test might have
> something to do with the changes to when `transport->bundles` was freed.
> I wonder if it would be a good idea to expland on this further in the
> commit message. Or since the added test is somewhat unrelated to this
> patch, maybe it should be a separate patch?

I added this test case because I wanted to debug the code path where the
remote advertises bundle URIs, all other test cases use --bundle-uri.
This helped me to debug the code and understand where the
`transport->bundles` are freed. Although this test case does not fully
touch the code path of the code that's removed, but it was close enough
to hack a few extra lines and understand what happens. Since I wrote
that test anyway, I felt I might as well submit it.

-- 
Toon

  reply	other threads:[~2024-08-02 15:45 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-22  8:07 [PATCH] fetch: use bundle URIs when having creationToken heuristic Toon Claes
2024-07-22 18:40 ` Junio C Hamano
2024-07-24 14:49 ` [PATCH v2 0/3] " Toon Claes
2024-07-24 14:49   ` [PATCH v2 1/3] clone: remove double bundle list clear code Toon Claes
2024-07-26  8:51     ` Karthik Nayak
2024-07-26 21:52     ` Justin Tobler
2024-08-02 15:45       ` Toon claes [this message]
2024-07-24 14:49   ` [PATCH v2 2/3] transport: introduce transport_has_remote_bundle_uri() Toon Claes
2024-07-26  8:58     ` Karthik Nayak
2024-07-26 15:25       ` Junio C Hamano
2024-07-24 14:49   ` [PATCH v2 3/3] fetch: use bundle URIs when having creationToken heuristic Toon Claes
2024-07-26  9:06     ` Karthik Nayak
2024-07-26 12:50     ` Patrick Steinhardt
2024-08-02 13:46       ` Toon claes
2024-08-22  7:12         ` Patrick Steinhardt
2024-09-27  9:04 ` [PATCH] builtin/clone: teach git-clone(1) the --ref= argument Toon Claes
2024-09-27  9:04   ` [PATCH v2] " Toon Claes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875xsj9bdt.fsf@gitlab.com \
    --to=toon@iotcl.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jltobler@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.