From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 549B2C27C4F for ; Thu, 13 Jun 2024 13:50:50 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sHkqF-0002Ny-0A; Thu, 13 Jun 2024 09:50:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sHkqC-0002N8-LN for qemu-devel@nongnu.org; Thu, 13 Jun 2024 09:50:12 -0400 Received: from smtp-out2.suse.de ([2a07:de40:b251:101:10:150:64:2]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sHkqB-0006K8-0c for qemu-devel@nongnu.org; Thu, 13 Jun 2024 09:50:12 -0400 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id BCF015D432; Thu, 13 Jun 2024 13:50:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1718286609; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Z+VfAKDwQdFrGxc/PUJ9jXLuC1oYqUlNhhBRXKmiFg8=; b=VKysfbWLAcuBIt4Rs0VmWShbob3khIL9M3t9wDmZWqgur2/uFzx2XOzupkv5ne74Ed0czF kXOHKk4a0Lw4IB+Z3rHDq+udXbQ2rMO/L+OgxJB0rd7hyJjk+o86SP9u9BtAEqRMpy1ZzQ shJJSTybfTddeyKCF67TSDNbZpg1hjY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1718286609; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Z+VfAKDwQdFrGxc/PUJ9jXLuC1oYqUlNhhBRXKmiFg8=; b=yOl7OsD88bSbl+9in1UtYJdcCDz7Mfxpyie+TOfZn89rXeU3mjm7279xYZOTwh2I5ebwvv zwkI9vShg7SbRnDA== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=j7bs1+Kz; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=0Rm4kR3S DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1718286607; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Z+VfAKDwQdFrGxc/PUJ9jXLuC1oYqUlNhhBRXKmiFg8=; b=j7bs1+KzNeSYP7KEkNY28VcSXS7I3yRWEY91SqUQZV6+boXdm4QkFKlx2tq7L7CZJWhN/F 44rbjgyKytxnhFJCuEN0MT/ow/wC8aDtUBJ9BZLc0IBCbc4mB27jMfabIFfNsJKfQrFkKE PEZkTbQcDkuIdhiK8jZj87i9xnf4RBI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1718286607; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Z+VfAKDwQdFrGxc/PUJ9jXLuC1oYqUlNhhBRXKmiFg8=; b=0Rm4kR3S5u1mNwg4tbZzphbCUgC2Iz3RgFM5LKXvRM4eS2gSSHpuD68FQSE+RIPm/NXlsD Y+VZQhG07BSQVrBw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 4396213A87; Thu, 13 Jun 2024 13:50:07 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id N9CyAg/5amYiQgAAD6G6ig (envelope-from ); Thu, 13 Jun 2024 13:50:07 +0000 From: Fabiano Rosas To: Peter Xu , qemu-devel@nongnu.org Cc: Jiri Denemark , Prasad Pandit , Bandan Das , peterx@redhat.com Subject: Re: [PATCH 1/4] migration/multifd: Avoid the final FLUSH in complete() In-Reply-To: <20240612144228.1179240-2-peterx@redhat.com> References: <20240612144228.1179240-1-peterx@redhat.com> <20240612144228.1179240-2-peterx@redhat.com> Date: Thu, 13 Jun 2024 10:50:04 -0300 Message-ID: <875xudc5pv.fsf@suse.de> MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Queue-Id: BCF015D432 X-Spamd-Result: default: False [-4.34 / 50.00]; BAYES_HAM(-2.83)[99.25%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_TLS_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.de:+]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:106:10:150:64:167:received,2a07:de40:b281:104:10:150:64:97:from]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; RCPT_COUNT_FIVE(0.00)[6]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; MISSING_XM_UA(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email, suse.de:dkim, imap1.dmz-prg2.suse.org:helo, imap1.dmz-prg2.suse.org:rdns] X-Rspamd-Action: no action X-Rspamd-Server: rspamd1.dmz-prg2.suse.org Received-SPF: pass client-ip=2a07:de40:b251:101:10:150:64:2; envelope-from=farosas@suse.de; helo=smtp-out2.suse.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Peter Xu writes: > We always do the flush when finishing one round of scan, and during > complete() phase we should scan one more round making sure no dirty page > existed. In that case we shouldn't need one explicit FLUSH at the end of > complete(), as when reaching there all pages should have been flushed. > > Signed-off-by: Peter Xu Reviewed-by: Fabiano Rosas