From: "Toke Høiland-Jørgensen" <toke@toke.dk>
To: Kalle Valo <kvalo@kernel.org>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/3] wifi: ath9k: ath9k_set_moredata(): fix sparse warnings
Date: Thu, 21 Mar 2024 19:37:37 +0100 [thread overview]
Message-ID: <875xxfh1n2.fsf@toke.dk> (raw)
In-Reply-To: <20240320170656.3534265-2-kvalo@kernel.org>
Kalle Valo <kvalo@kernel.org> writes:
> From: Kalle Valo <quic_kvalo@quicinc.com>
>
> Sparse warns:
>
> drivers/net/wireless/ath/ath9k/xmit.c:1677:20: warning: incorrect type in initializer (different base types)
> drivers/net/wireless/ath/ath9k/xmit.c:1677:20: expected unsigned short [usertype] mask
> drivers/net/wireless/ath/ath9k/xmit.c:1677:20: got restricted __le16 [usertype]
> drivers/net/wireless/ath/ath9k/xmit.c:1681:17: warning: restricted __le16 degrades to integer
> drivers/net/wireless/ath/ath9k/xmit.c:1682:42: warning: restricted __le16 degrades to integer
> drivers/net/wireless/ath/ath9k/xmit.c:1682:36: warning: incorrect type in assignment (different base types)
> drivers/net/wireless/ath/ath9k/xmit.c:1682:36: expected restricted __le16 [usertype] frame_control
> drivers/net/wireless/ath/ath9k/xmit.c:1682:36: got int
>
> Fix ath9k_set_moredata() to use __le16 with masks and use if statement instead
> of multiply operator.
>
> Compile tested only.
>
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Acked-by: Toke Høiland-Jørgensen <toke@toke.dk>
next prev parent reply other threads:[~2024-03-21 18:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-20 17:06 [PATCH 0/3] wifi: ath9k: fix remaining sparse warnings Kalle Valo
2024-03-20 17:06 ` [PATCH 1/3] wifi: ath9k: ath9k_set_moredata(): fix " Kalle Valo
2024-03-20 17:34 ` Jeff Johnson
2024-03-21 18:37 ` Toke Høiland-Jørgensen [this message]
2024-03-25 10:51 ` Kalle Valo
2024-03-20 17:06 ` [PATCH 2/3] wifi: ath9k: fix ath9k_use_msi declaration Kalle Valo
2024-03-20 17:34 ` Jeff Johnson
2024-03-21 18:37 ` Toke Høiland-Jørgensen
2024-03-20 17:06 ` [PATCH 3/3] wifi: ath9k: eeprom: fix sparse endian warnings Kalle Valo
2024-03-20 17:34 ` Jeff Johnson
2024-03-21 18:37 ` Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875xxfh1n2.fsf@toke.dk \
--to=toke@toke.dk \
--cc=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.