From: Kurt Kanzenbach <kurt@linutronix.de>
To: YiFei Zhu <zhuyifei@google.com>, Yonghong Song <yonghong.song@linux.dev>
Cc: bpf@vger.kernel.org, Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Stanislav Fomichev <sdf@google.com>,
Martin KaFai Lau <martin.lau@linux.dev>,
Andrii Nakryiko <andrii@kernel.org>,
Song Liu <songliubraving@fb.com>
Subject: Re: [PATCH bpf] selftests/bpf: Relax time_tai test for equal timestamps in tai_forward
Date: Tue, 19 Dec 2023 10:57:43 +0100 [thread overview]
Message-ID: <875y0u4iqw.fsf@kurt> (raw)
In-Reply-To: <CAA-VZP=7s4S73CDGWApatHoFRE1Gv1AQKJKXi=Nqf5dBU50OoQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 968 bytes --]
On Tue Dec 12 2023, YiFei Zhu wrote:
>> > diff --git a/tools/testing/selftests/bpf/prog_tests/time_tai.c b/tools/testing/selftests/bpf/prog_tests/time_tai.c
>> > index a31119823666..f45af1b0ef2c 100644
>> > --- a/tools/testing/selftests/bpf/prog_tests/time_tai.c
>> > +++ b/tools/testing/selftests/bpf/prog_tests/time_tai.c
>> > @@ -56,7 +56,7 @@ void test_time_tai(void)
>> > ASSERT_NEQ(ts2, 0, "tai_ts2");
>> >
>> > /* TAI is moving forward only */
>> > - ASSERT_GT(ts2, ts1, "tai_forward");
>> > + ASSERT_GE(ts2, ts1, "tai_forward");
>>
>> Can we guard the new change with arm64 specific macro?
>
> Problem with this is that I'm not sure what other architectures could
> be affected. AFAICT from the test, what it cares about is that time is
> moving forwards rather than going backwards, so I thought GE is good
> enough for what it's testing for.
Yes, exactly. The time must not go backwards. Checking for GE is
fine. Thanks for fixing this.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]
next prev parent reply other threads:[~2023-12-19 9:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-12 18:29 [PATCH bpf] selftests/bpf: Relax time_tai test for equal timestamps in tai_forward YiFei Zhu
2023-12-12 21:39 ` Yonghong Song
2023-12-12 21:52 ` YiFei Zhu
2023-12-13 0:01 ` Andrii Nakryiko
2023-12-19 9:57 ` Kurt Kanzenbach [this message]
2023-12-13 0:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875y0u4iqw.fsf@kurt \
--to=kurt@linutronix.de \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=martin.lau@linux.dev \
--cc=sdf@google.com \
--cc=songliubraving@fb.com \
--cc=yonghong.song@linux.dev \
--cc=zhuyifei@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.