From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a17:906:cf90:b0:9bd:85f7:2662 with SMTP id um16csp1065859ejb; Fri, 20 Oct 2023 01:34:48 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH9I4Fl7BcFhDA9HMxWy0ziU/QBL5qN+Wj3JUSfL8nNu8LemgRkWPP1E33ijcAiIKrLiDvn X-Received: by 2002:a05:622a:191f:b0:405:45e1:de14 with SMTP id w31-20020a05622a191f00b0040545e1de14mr1230482qtc.27.1697790888444; Fri, 20 Oct 2023 01:34:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697790888; cv=none; d=google.com; s=arc-20160816; b=xSTyU26K5NWWXE0O9ej5tjks0rXl2uiZOadQt45PkxBnXxnvUiv65TeYZt3zhq9BxU PM8As2p9cUymwFmWYH4ncqJyxwBSz4WYKqpusD/rdc8eFINTRcwL/YoFkWQpEddOD7LJ YMsKwxgGDORtbJIEV8pj1zaE3v1QWJ11k6VZDpQy0SgknGoPKOfRQr0KxczbRmigozjE vXmEHfHPwrvZOXnKx40ZIJ+2Tq7FkBZluVN4NZwRS4Yc8hXWbNVQ4697gdb5ng1TJbgU VjM8tl8TgIKnkyiAQE4AH4e7eRIPGFTlbAK1p2p6lD6KE3ZrgdC8RdtUO7zQSWTGIq82 o+NQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:dkim-signature; bh=ExjKUgn7axteSCEOabWgquodqKYCjk/OCBBPC9x63g4=; fh=o3kaWeSVHD0lAvrj8JuJPxnxZn4rnrdXfjGdDLMTnfM=; b=GqVlUexQOG1uy17BR5z8gFmEx9W3WKuj2TSdinLJNlQXtY47Cf8zJcAArT8uuumAHK fsjOwNvMK4Why6DaasyuaBaQU0dkxt9OdYWUs3sFGakAKT8iOvv9+HX1knzIKhPLMBlj vD51UhFtiVA9IkXb5q32MyGrnx9PS5IpqRlcBJkpXx5fN+rOcoCXuFDKVdkhwMN588U2 iP3Lk7MrpP0VQRuo0s9UCA886/aAw2Yxo4J29UclXM36kml7BIKrKneoXn3GABaIRUpo G2eNs8cdAYexGZkscKwXoiq7GNwcF5k2WtZicKvZ6VLcvxxkYrzMc8dmjLk9wbDPJCpA OPVQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=JWPKZBw8; spf=pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id x18-20020a05622a001200b00419894fe568si920877qtw.343.2023.10.20.01.34.48 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 20 Oct 2023 01:34:48 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=JWPKZBw8; spf=pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qtkxR-0000IK-0I; Fri, 20 Oct 2023 04:34:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qtkxI-00008Z-Oj for qemu-devel@nongnu.org; Fri, 20 Oct 2023 04:34:04 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qtkxH-0002oZ-8Z for qemu-devel@nongnu.org; Fri, 20 Oct 2023 04:34:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1697790842; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ExjKUgn7axteSCEOabWgquodqKYCjk/OCBBPC9x63g4=; b=JWPKZBw80TXiLeS2g4vPUQL8/4tcTUryceENRk5cZfNwuKxmfBTatpaENeHH1UyhBYxuUt 1tiH5KDVlDI1S3ZGKOEroOgUnnMbD2B2WrjM8Oci5lm4/G/xT/mBAWfOxOH9Z2pHW1EwSt sCOCr4j1/BKw4bmtld7T4k4R2dYLswI= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-74-Esz6OVCDNQuLDrNUykpu6Q-1; Fri, 20 Oct 2023 04:33:51 -0400 X-MC-Unique: Esz6OVCDNQuLDrNUykpu6Q-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id BE61088D023; Fri, 20 Oct 2023 08:33:50 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.193.56]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9C3568CEF; Fri, 20 Oct 2023 08:33:50 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 9433A21E6A1F; Fri, 20 Oct 2023 10:33:49 +0200 (CEST) From: Markus Armbruster To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Cc: qemu-devel@nongnu.org, qemu-arm@nongnu.org, qemu-ppc@nongnu.org, qemu-block@nongnu.org, qemu-s390x@nongnu.org, Juan Quintela , Peter Xu , Leonardo Bras Subject: Re: [PATCH v2 10/22] qapi: Correct error message for 'vcpu_dirty_limit' parameter References: <20231005045041.52649-1-philmd@linaro.org> <20231005045041.52649-11-philmd@linaro.org> Date: Fri, 20 Oct 2023 10:33:49 +0200 In-Reply-To: <20231005045041.52649-11-philmd@linaro.org> ("Philippe =?utf-8?Q?Mathieu-Daud=C3=A9=22's?= message of "Thu, 5 Oct 2023 06:50:27 +0200") Message-ID: <875y318zgy.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.5 Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org Sender: qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org X-TUID: DppGOWTHJFNu Philippe Mathieu-Daud=C3=A9 writes: > QERR_INVALID_PARAMETER_VALUE is defined as: > > #define QERR_INVALID_PARAMETER_VALUE \ > "Parameter '%s' expects %s" > > The current error is formatted as: > > "Parameter 'vcpu_dirty_limit' expects is invalid, it must greater then = 1 MB/s" > > Replace by: > > "Parameter 'vcpu_dirty_limit' is invalid, it must greater then 1 MB/s" > > Signed-off-by: Philippe Mathieu-Daud=C3=A9 > --- > migration/options.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/migration/options.c b/migration/options.c > index 1d1e1321b0..79fce0c3a9 100644 > --- a/migration/options.c > +++ b/migration/options.c > @@ -1163,9 +1163,8 @@ bool migrate_params_check(MigrationParameters *para= ms, Error **errp) >=20=20 > if (params->has_vcpu_dirty_limit && > (params->vcpu_dirty_limit < 1)) { > - error_setg(errp, QERR_INVALID_PARAMETER_VALUE, > - "vcpu_dirty_limit", > - "is invalid, it must greater then 1 MB/s"); > + error_setg(errp, "Parameter 'vcpu_dirty_limit' is invalid," > + " it must greater then 1 MB/s"); > return false; > } Make that "greater than", please. Arrgh, the unit is MB/s even in QMP: # @vcpu-dirty-limit: Dirtyrate limit (MB/s) during live migration. # Defaults to 1. (Since 8.1) Should be Bytes. Escaped review, and now it's too late to fix.