From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9B4F4E810DA for ; Wed, 27 Sep 2023 12:24:29 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qlTaX-0007xO-Mx; Wed, 27 Sep 2023 08:24:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qlTaS-0007uL-Tn for qemu-devel@nongnu.org; Wed, 27 Sep 2023 08:24:16 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qlTaR-0002nl-HZ for qemu-devel@nongnu.org; Wed, 27 Sep 2023 08:24:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695817454; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fkPbW5nK1t6WuZ/lQ2EPw+lhIlDJWc2QhNDzqMKU2k0=; b=I1R5j++xdsgRgSRIHJY68UxNVK/8xklyS6iIgpP1nNK5CczbuiNL2ItCiWIH1ZTnZXtafl p7RjQqxNTrKxT6r9O6EdZtrpXewJBzZ2cdzi9AhFtolLfr+dY0xg7oPasUo26UTQAxVPWo 2mUzOc9YtK0BK++fDHyZXCpCpOBXxLw= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-418-7fHjaLetPOak5YA1IFy6Lg-1; Wed, 27 Sep 2023 08:24:10 -0400 X-MC-Unique: 7fHjaLetPOak5YA1IFy6Lg-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 11DC63C108E3; Wed, 27 Sep 2023 12:24:10 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.192.25]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 97D772026D4B; Wed, 27 Sep 2023 12:24:09 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 73B5E21E6900; Wed, 27 Sep 2023 14:24:08 +0200 (CEST) From: Markus Armbruster To: Thomas Huth Cc: Gurchetan Singh , qemu-devel@nongnu.org, Markus Armbruster , marcandre.lureau@redhat.com, akihiko.odaki@gmail.com, ray.huang@amd.com, alex.bennee@linaro.org, shentey@gmail.com, hi@alyssa.is, ernunes@redhat.com, manos.pitsidianakis@linaro.org, philmd@linaro.org, mark.cave-ayland@ilande.co.uk Subject: Re: [PATCH v13 6/9] gfxstream + rutabaga: add initial support for gfxstream References: <20230829003629.410-1-gurchetansingh@chromium.org> <20230829003629.410-7-gurchetansingh@chromium.org> <921df90e-418b-5442-e84b-7ead3e75501a@redhat.com> Date: Wed, 27 Sep 2023 14:24:08 +0200 In-Reply-To: <921df90e-418b-5442-e84b-7ead3e75501a@redhat.com> (Thomas Huth's message of "Wed, 27 Sep 2023 13:45:45 +0200") Message-ID: <875y3vdct3.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Thomas Huth writes: [...] >> +static Property virtio_gpu_rutabaga_properties[] = { >> + DEFINE_PROP_STRING("capset_names", VirtIOGPURutabaga, capset_names), >> + DEFINE_PROP_STRING("wayland_socket_path", VirtIOGPURutabaga, >> + wayland_socket_path), > > FWIW, it seems to be more common to use "-" instead of "_" to separate words in properties ... so I'd like to suggest to replace the underscores in the strings here. Please separate words with '-', not '_', except where existing properties all use '_'.