From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 04AE3C83F3D for ; Thu, 31 Aug 2023 20:17:46 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AB31510E6DC; Thu, 31 Aug 2023 20:17:46 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id D93B710E6DC for ; Thu, 31 Aug 2023 20:17:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1693513064; x=1725049064; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=tMOynBb4DZ4rzgpysZBxCPtOtO5fiAzgYX7lPm4zIC0=; b=NVkNFukMMFOe2BoFVsyQJOFr93AtYKRQXyY5kxHnkUOKT792kvSs7b2Z Vsm1bxQjR0gst6lmuHAJ4Ni0S9k4TOvEinjHZAd4Xu1Ci3P5BY98HFfX3 szrbRMiBBPAsBwsVNFbGjlJRzuBiNR5/5+M+Ef6H9SF0ni0Hs0LxHWwE6 0CQtrljSui4+AVwtm+RoM+FEAGhwosphJ70YtJttL/wsmOfbbl/Tv0zGX r0VZd5+Odjpfof4l37C3f4UGQzuAeFWIApR+N1AbH5E1RdgUCbY6oxaZZ OHMg/iYBgLnlCHQtK2SvwlEMJwNHP5i3ayGG3zH6gNGN5pDdc+wVEtX17 g==; X-IronPort-AV: E=McAfee;i="6600,9927,10819"; a="440040667" X-IronPort-AV: E=Sophos;i="6.02,217,1688454000"; d="scan'208";a="440040667" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Aug 2023 13:17:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10819"; a="733264078" X-IronPort-AV: E=Sophos;i="6.02,217,1688454000"; d="scan'208";a="733264078" Received: from adixit-mobl.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.212.199.173]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Aug 2023 13:17:33 -0700 Date: Thu, 31 Aug 2023 13:12:52 -0700 Message-ID: <875y4v0y4b.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Rodrigo Vivi In-Reply-To: References: <20230808013159.38811-1-ashutosh.dixit@intel.com> <20230808013159.38811-2-ashutosh.dixit@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Subject: Re: [Intel-xe] [PATCH 01/10] drm/xe/oa: Introduce OA uapi X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Francois Dugast , intel-xe@lists.freedesktop.org Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Thu, 31 Aug 2023 12:55:14 -0700, Rodrigo Vivi wrote: > Hi Rodrigo, > On Tue, Aug 22, 2023 at 10:31:06AM +0200, Francois Dugast wrote: > > Hi Ashutosh, > > > > On Mon, Aug 07, 2023 at 06:31:50PM -0700, Ashutosh Dixit wrote: > > > OA uapi allows userspace to: > > > * Read streams of performance counters written by hardware > > > * Configure (and reconfigure) which sets of perf counters are captured as > > > part of OA streams > > > * Configure other properties (such as format and periodicity) of such > > > captures. > > > * Query associated parameters such as OA unit timestamp freq, oa_unit_id's > > > for hw engines and OA ioctl version > > > > Please document the uapi structures, not only their members. Also it would > > be nice to explicit somewhere what OA stands for, maybe in the commit > > message as well. > > Besides that, we need true API like documentation with examples showing > how this is used. Please! Sorry, not following. What sort of "examples"? Are there similar examples in xe_drm.h, could you please point them out so we know what to add. Or you mean examples outside xe_drm.h, e.g. in Documentation/ e.g.? The IGT series was also posted along with the kernel series here: https://patchwork.freedesktop.org/series/121082/ That has plenty of examples but probably that's not what you mean? Thanks. -- Ashutosh