All of lore.kernel.org
 help / color / mirror / Atom feed
From: Baruch Siach <baruch@tkos.co.il>
To: Kees Cook <keescook@chromium.org>
Cc: Eric Biederman <ebiederm@xmission.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] elf: correct note name comment
Date: Sun, 25 Jun 2023 06:44:09 +0300	[thread overview]
Message-ID: <875y7c5hgd.fsf@tarshish> (raw)
In-Reply-To: <202306230934.C235D5751@keescook>

Hi Kees,

On Fri, Jun 23 2023, Kees Cook wrote:
> On Fri, Jun 23, 2023 at 08:50:11AM +0300, Baruch Siach wrote:
>> NT_PRFPREG note is named "CORE". Correct the comment accordingly.
>> 
>> Fixes: 00e19ceec80b ("ELF: Add ELF program property parsing support")
>> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
>> ---
>> 
>> v2: Swap "CORE" and "LINUX" as noted by Kees
>> ---
>>  include/uapi/linux/elf.h | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>> 
>> diff --git include/uapi/linux/elf.h include/uapi/linux/elf.h
>> index ac3da855fb19..4d1c8d46e7f0 100644
>> --- include/uapi/linux/elf.h
>> +++ include/uapi/linux/elf.h
>
> Hi, I took this patch, but it seems something is misconfigured on your
> end for patch generation -- normally I'd expect to need "-p1", not "-p0"
> to apply patches. Are you using "git format-patch" to produce these
> patches?

I recently enabled diff.noprefix for easier copying of file names from
git-diff output. I have now noticed the git-format-patch is also
affected, and that it breaks the default git-am -p1. So I have reverted
diff.noprefix to its default.

Sorry for the inconvenience, and thanks for letting me know.

baruch

-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -


      reply	other threads:[~2023-06-25  3:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-23  5:50 [PATCH v2] elf: correct note name comment Baruch Siach
2023-06-23 16:36 ` Kees Cook
2023-06-25  3:44   ` Baruch Siach [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875y7c5hgd.fsf@tarshish \
    --to=baruch@tkos.co.il \
    --cc=ebiederm@xmission.com \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.