From: John Ogness <john.ogness@linutronix.de>
To: Doug Anderson <dianders@chromium.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Petr Mladek <pmladek@suse.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org, Jiri Slaby <jirislaby@kernel.org>,
Vijaya Krishna Nivarthi <quic_vnivarth@quicinc.com>,
linux-serial@vger.kernel.org
Subject: Re: [PATCH tty v1 4/8] serial: core: lock port for start_rx() in uart_resume_port()
Date: Fri, 26 May 2023 10:15:51 +0206 [thread overview]
Message-ID: <875y8f1pkg.fsf@jogness.linutronix.de> (raw)
In-Reply-To: <CAD=FV=WSKaihdow4Bbr6SSuUXL3s1u3it-=0Gkh95q=bwZuqnA@mail.gmail.com>
On 2023-05-25, Doug Anderson <dianders@chromium.org> wrote:
>> Seems right, but shouldn't you also fix the call to stop_rx() that
>> the same commit cfab87c2c271 ("serial: core: Introduce callback for
>> start_rx and do stop_rx in suspend only if this callback
>> implementation is present.") added? That one is also missing the
>> lock, right?
>
> Ah, I see. You did that in a separate patch and I wasn't CCed. I guess
> I would have just put the two in one patch, but I don't feel that
> strongly.
Actually stop_rx() was introduced in a different commit. The commit you
reference just changed it a bit. My other patch uses a different Fixes
tag.
Also, I was concerned about packing too much new spin locking in a
single commit in the hopes it will help with any bisecting issues.
> Reviewed-by: Douglas Anderson <dianders@chromium.org>
Thanks!
John
next prev parent reply other threads:[~2023-05-26 8:12 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-25 9:31 [PATCH tty v1 0/8] synchronize UART_IER access against console write John Ogness
2023-05-25 9:31 ` John Ogness
2023-05-25 9:31 ` John Ogness
2023-05-25 9:31 ` [PATCH tty v1 1/8] serial: 8250: lock port in startup() callbacks John Ogness
2023-05-25 9:31 ` [PATCH tty v1 2/8] serial: core: lock port for stop_rx() in uart_suspend_port() John Ogness
2023-05-25 17:47 ` Vijaya Krishna Nivarthi (Temp) (QUIC)
2023-05-25 20:37 ` Doug Anderson
2023-05-25 9:31 ` [PATCH tty v1 3/8] serial: 8250: lock port for stop_rx() in omap8250_irq() John Ogness
2023-05-26 9:00 ` Tony Lindgren
2023-05-25 9:31 ` [PATCH tty v1 4/8] serial: core: lock port for start_rx() in uart_resume_port() John Ogness
2023-05-25 16:07 ` Doug Anderson
2023-05-25 20:38 ` Doug Anderson
2023-05-26 8:09 ` John Ogness [this message]
2023-05-25 9:31 ` [PATCH tty v1 5/8] serial: 8250: lock port for rx_dma() callback John Ogness
2023-05-25 9:31 ` [PATCH tty v1 6/8] serial: 8250: lock port for omap8250_restore_regs() John Ogness
2023-05-25 9:31 ` [PATCH tty v1 7/8] serial: 8250: lock port for UART_IER access in omap8250_irq() John Ogness
2023-05-26 9:01 ` Tony Lindgren
2023-05-25 9:31 ` [PATCH tty v1 8/8] serial: 8250: synchronize and annotate UART_IER access John Ogness
2023-05-25 9:31 ` John Ogness
2023-05-25 9:31 ` John Ogness
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875y8f1pkg.fsf@jogness.linutronix.de \
--to=john.ogness@linutronix.de \
--cc=dianders@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=quic_vnivarth@quicinc.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.