From: Markus Armbruster <armbru@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>
Cc: "Markus Armbruster" <armbru@redhat.com>,
qemu-devel@nongnu.org, qemu-ppc@nongnu.org,
"David Gibson" <david@gibson.dropbear.id.au>,
"Greg Kurz" <groug@kaod.org>,
qemu-arm@nongnu.org, "Xiaojuan Yang" <yangxiaojuan@loongson.cn>,
"Cédric Le Goater" <clg@kaod.org>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Daniel Henrique Barboza" <danielhb413@gmail.com>,
"Song Gao" <gaosong@loongson.cn>,
"Richard Henderson" <richard.henderson@linaro.org>
Subject: Re: [PATCH v3 4/4] target/ppc: Restrict 'qapi-commands-machine.h' to system emulation
Date: Thu, 23 Feb 2023 14:42:16 +0100 [thread overview]
Message-ID: <875ybs4hxj.fsf@pond.sub.org> (raw)
In-Reply-To: <20230223124340.95367-5-philmd@linaro.org> ("Philippe Mathieu-Daudé"'s message of "Thu, 23 Feb 2023 13:43:40 +0100")
Philippe Mathieu-Daudé <philmd@linaro.org> writes:
> Since commit a0e61807a3 ("qapi: Remove QMP events and commands from
> user-mode builds") we don't generate the "qapi-commands-machine.h"
> header in a user-emulation-only build.
>
> Move the QMP functions from cpu_init.c (which is always compiled) to
> monitor.c (which is only compiled when system-emulation is selected).
> Note ppc_cpu_class_by_name() is used by both file units, so we expose
> its prototype in "cpu-qom.h".
My comment on PATCH 1 applies.
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> Reviewed-by: Cédric Le Goater <clg@kaod.org>
next prev parent reply other threads:[~2023-02-23 13:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-23 12:43 [PATCH v3 0/4] target: Restrict 'qapi-commands-machine.h' to system emulation Philippe Mathieu-Daudé
2023-02-23 12:43 ` [PATCH v3 1/4] target/arm: " Philippe Mathieu-Daudé
2023-02-23 13:40 ` Markus Armbruster
2023-02-23 12:43 ` [PATCH v3 2/4] target/i386: " Philippe Mathieu-Daudé
2023-02-23 12:43 ` [PATCH v3 3/4] target/loongarch: " Philippe Mathieu-Daudé
2023-02-23 13:41 ` Markus Armbruster
2023-02-23 12:43 ` [PATCH v3 4/4] target/ppc: " Philippe Mathieu-Daudé
2023-02-23 13:42 ` Markus Armbruster [this message]
2023-02-23 13:49 ` [PATCH v3 0/4] target: " Markus Armbruster
2023-02-23 15:56 ` Philippe Mathieu-Daudé
2023-02-23 15:58 ` Philippe Mathieu-Daudé
2023-02-23 16:25 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875ybs4hxj.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=clg@kaod.org \
--cc=danielhb413@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=gaosong@loongson.cn \
--cc=groug@kaod.org \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=yangxiaojuan@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.