From: Thomas Gleixner <tglx@linutronix.de>
To: Sergey Shtylyov <s.shtylyov@omp.ru>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] irq: ipi: fix NULL pointer deref in irq_data_get_affinity_mask()
Date: Thu, 09 Feb 2023 11:49:37 +0100 [thread overview]
Message-ID: <875ycb2jwe.ffs@tglx> (raw)
In-Reply-To: <774e2812-2856-f146-b8b3-e4f772c5e38a@omp.ru>
On Wed, Feb 08 2023 at 21:35, Sergey Shtylyov wrote:
> On 8/17/22 11:00 PM, Sergey Shtylyov wrote:
>
>> Iff ipi_send_{mask|single}() get called with e.g. an invalid IRQ #, all the
>> local variables there will be NULL -- the problem is that ipi_send_verify()
>> (that's called first thing) doesn't verify its 'data' parameter, resulting
>> in a kernel oops in irq_data_get_affinity_mask() as the passed NULL pointer
>> gets dereferenced. Add a missing NULL check in ipi_send_verify()...
>>
>> Found by Linux Verification Center (linuxtesting.org) with the SVACE static
>> analysis tool.
>>
>> Fixes: 3b8e29a82dd1 ("genirq: Implement ipi_send_mask/single()")
>> Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
>
> Patch fell thru the cracks? :-/
Obviously :)
/me goes to find trash tongs to pick it up
next prev parent reply other threads:[~2023-02-09 10:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-17 20:00 [PATCH] irq: ipi: fix NULL pointer deref in irq_data_get_affinity_mask() Sergey Shtylyov
2023-02-08 18:35 ` Sergey Shtylyov
2023-02-09 10:49 ` Thomas Gleixner [this message]
2023-02-19 10:20 ` Sergey Shtylyov
2023-02-20 12:55 ` [tip: irq/urgent] genirq/ipi: Fix " tip-bot2 for Sergey Shtylyov
2023-02-24 10:37 ` Sergey Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875ycb2jwe.ffs@tglx \
--to=tglx@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=s.shtylyov@omp.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.