From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0F9FDC433FE for ; Wed, 30 Nov 2022 01:47:55 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D568F10E405; Wed, 30 Nov 2022 01:47:53 +0000 (UTC) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4C7F510E405 for ; Wed, 30 Nov 2022 01:47:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1669772870; x=1701308870; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=Jj++Vd+bXXv4jlPKhUCQVrCROY0pef4tBWPjQ2tnP68=; b=Q7uGuRRdoi84ckB9JYz7f2njWLrfNBhNDRl/k6CfDEwFasDqpdJW+IRx 3POrsMX03aCJijuHyfeUMEF/qYXaieVcAxGcOme2ivO03NgbUet2KKm+0 PWzFSOtYL51SyfnmyTJtc07IYc0rOlfGZ8vurrshUlgt46hZlEtQdvvtP JdqZ3/Unzp26IMesgmtFlF4/cPVlxF2QDlwHvhR4vy5CO4GuHwHZ4lES3 qYteYN31/LDWPMwyTRec/5Krx7OTim3tsF0WsgoG6aSz1SJimEsE7cPmY SfLJLYAwyGA32nFkw6AYUQJPlZHhH3jq2zk6gHwYGtDw7GyVw+7QQ2GQT g==; X-IronPort-AV: E=McAfee;i="6500,9779,10546"; a="302883572" X-IronPort-AV: E=Sophos;i="5.96,204,1665471600"; d="scan'208";a="302883572" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Nov 2022 17:47:49 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10546"; a="646140743" X-IronPort-AV: E=Sophos;i="5.96,204,1665471600"; d="scan'208";a="646140743" Received: from adixit-mobl.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.209.22.21]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Nov 2022 17:47:49 -0800 Date: Tue, 29 Nov 2022 17:47:46 -0800 Message-ID: <875yex43i5.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Umesh Nerlige Ramappa In-Reply-To: <877czd44x2.wl-ashutosh.dixit@intel.com> References: <20221129012146.995006-1-umesh.nerlige.ramappa@intel.com> <877czd44x2.wl-ashutosh.dixit@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Subject: Re: [Intel-gfx] [PATCH] drm/i915/mtl: Add support for 32 bit OAG formats in MTL X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, 29 Nov 2022 17:17:13 -0800, Dixit, Ashutosh wrote: > > > @@ -4746,6 +4772,7 @@ static void oa_init_supported_formats(struct i915_perf *perf) > > break; > > > > case INTEL_DG2: > > + case INTEL_METEORLAKE: > > oa_format_add(perf, I915_OAR_FORMAT_A32u40_A4u32_B8_C8); > > oa_format_add(perf, I915_OA_FORMAT_A24u40_A14u32_B8_C8); > > Do these formats also need to be added? Sorry! > oa_format_add(perf, I915_OAR_FORMAT_A32u40_A4u32_B8_C8); > oa_format_add(perf, I915_OA_FORMAT_A24u40_A14u32_B8_C8); These two are the same as above. > oa_format_add(perf, I915_OAR_FORMAT_A36u64_B8_C8); > oa_format_add(perf, I915_OA_FORMAT_A38u64_R2u64_B8_C8); And it seems these are not 32 bit (where 32 bit refers to the header size). > Or these are not considered OAG formats? So it's ok, no changes needed here. > > > break; > Thanks. > -- > Ashutosh