From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0A370C07E9D for ; Mon, 26 Sep 2022 08:53:43 +0000 (UTC) Received: from localhost ([::1]:42036 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ocjry-0007XT-De for qemu-devel@archiver.kernel.org; Mon, 26 Sep 2022 04:53:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59026) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ocjpj-0006BI-Ju for qemu-devel@nongnu.org; Mon, 26 Sep 2022 04:51:32 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:30205) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ocjpg-0002G6-Iv for qemu-devel@nongnu.org; Mon, 26 Sep 2022 04:51:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1664182279; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=uyBzdAwRWqAbk70tf84bEM5XJ7b5caFmRlbgcgPre8o=; b=HycEaD1c6Mstiokqw37fXxDgFVQXm63vbWuyudBJoRF4a5K1flqOORMN0V9uj1McZ4rdzg HEQKwoEraXUxlRAZvkcCv2WFFOFLBLtULV15Xpfl4JWOhSJSvcO0GSzLnMvAYm9GG1zQtI J2O7L5E0QdArVf2jqOj6D4YeoQ26xJ8= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-321-8LHp6RlwM8-rmncO57yTqA-1; Mon, 26 Sep 2022 04:51:15 -0400 X-MC-Unique: 8LHp6RlwM8-rmncO57yTqA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 56B85800B30; Mon, 26 Sep 2022 08:51:15 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.192.163]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EC78DC15BA4; Mon, 26 Sep 2022 08:51:14 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id D72F321E691D; Mon, 26 Sep 2022 10:51:13 +0200 (CEST) From: Markus Armbruster To: Bryce Mills Cc: "qemu-devel@nongnu.org" , Gerd Hoffmann Subject: Re: [PATCH] gtk: Add show_menubar=on|off command line option. References: Date: Mon, 26 Sep 2022 10:51:13 +0200 In-Reply-To: (Bryce Mills's message of "Sat, 24 Sep 2022 21:09:25 +0000") Message-ID: <875yhabjsu.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Bryce Mills writes: > The patch adds "show_menubar" command line option for GTK UI similar to > "show_tabs". This option allows to hide menu bar initially, it still can > be toggled by shortcut and other shortcuts still work. > > (First-time contributor) > > Signed-off-by: Bryce Mills > --- > qapi/ui.json | 6 +++++- > qemu-options.hx | 4 +++- > ui/gtk.c | 15 ++++++++++----- > 3 files changed, 18 insertions(+), 7 deletions(-) > > diff --git a/qapi/ui.json b/qapi/ui.json > index 286c5731d1..124975d724 100644 > --- a/qapi/ui.json > +++ b/qapi/ui.json > @@ -1200,12 +1200,16 @@ > # by default. > # Since 7.1 > # > +# @show-menubar: Display the main window menubar > +# Since 8.0 Please mention the default. Not your patch's fault: @grab-on-hover and @show-tabs should mention their default. > +# > # Since: 2.12 > ## > { 'struct' : 'DisplayGTK', > 'data' : { '*grab-on-hover' : 'bool', > '*zoom-to-fit' : 'bool', > - '*show-tabs' : 'bool' } } > + '*show-tabs' : 'bool', > + '*show-menubar' : 'bool' } } > > ## > # @DisplayEGLHeadless: [...]