From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 88A97ECAAD5 for ; Mon, 12 Sep 2022 08:08:34 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 45E9810E0C7; Mon, 12 Sep 2022 08:08:33 +0000 (UTC) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0681910E0C7 for ; Mon, 12 Sep 2022 08:08:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1662970109; x=1694506109; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=s7Jug/OnMCFhyd1q5xTwD79VDV4Ia8xhw4W5pOzqF7Q=; b=MEQ3TLzhtGQqdzXYsWqlKQN6v/HSr6ZXa+EqgMZF6JhqI93PqNdMegbg bHFtC1tvf3MoTovSMSXr9bhAz2nQwRbJL78FZEU+En2FibAlzT7X9pjCp yxFXhZchY68EXuY+Q2r9v/irFkMxvl84mrbBYhU2nOgZ6ukP0GWGzWoVv nZbEAHNnGTqr42ycjWKRJzxiYbf8sAWOCd1h3Xyf99ydgjb12VG8QkxRA eY3o8rGrfftXLgEazNz56LkULMkbweS9VETTqgJk4aT2tu7zYZKJMAy+G pcdybe7kn4KYlHidbTeLsBz9CI4vbIbIqNgeSBj6BlQfmup+SRzV4xn2X Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10467"; a="277544365" X-IronPort-AV: E=Sophos;i="5.93,308,1654585200"; d="scan'208";a="277544365" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Sep 2022 01:08:28 -0700 X-IronPort-AV: E=Sophos;i="5.93,308,1654585200"; d="scan'208";a="646358310" Received: from abijaz-mobl.ger.corp.intel.com (HELO localhost) ([10.252.58.140]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Sep 2022 01:08:24 -0700 From: Jani Nikula To: Hamza Mahfooz , linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/bridge: it6505: use drm_debug_enabled() in it6505_debug_print() In-Reply-To: <20220910224816.15058-1-someguy@effective-light.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20220910224816.15058-1-someguy@effective-light.com> Date: Mon, 12 Sep 2022 11:08:19 +0300 Message-ID: <875yht6mmk.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jonas Karlman , David Airlie , Allen Chen , Hamza Mahfooz , dri-devel@lists.freedesktop.org, Neil Armstrong , Hermes Wu , Jernej Skrabec , Andrzej Hajda , AngeloGioacchino Del Regno , Robert Foss , Laurent Pinchart Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Sat, 10 Sep 2022, Hamza Mahfooz wrote: > As made mention of in commit 9f0ac028410f ("drm/print: rename drm_debug > to __drm_debug to discourage use"), we shouldn't explicitly refer to > __drm_debug in this context. So, use drm_debug_enabled() instead. > > Fixes: b5c84a9edcd4 ("drm/bridge: add it6505 driver") > Signed-off-by: Hamza Mahfooz Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/bridge/ite-it6505.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/bridge/ite-it6505.c b/drivers/gpu/drm/bridge/ite-it6505.c > index 4b673c4792d7..875f87c576cb 100644 > --- a/drivers/gpu/drm/bridge/ite-it6505.c > +++ b/drivers/gpu/drm/bridge/ite-it6505.c > @@ -554,7 +554,7 @@ static void it6505_debug_print(struct it6505 *it6505, unsigned int reg, > struct device *dev = &it6505->client->dev; > int val; > > - if (likely(!(__drm_debug & DRM_UT_DRIVER))) > + if (!drm_debug_enabled(DRM_UT_DRIVER)) > return; > > val = it6505_read(it6505, reg); -- Jani Nikula, Intel Open Source Graphics Center From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08789ECAAD5 for ; Mon, 12 Sep 2022 08:08:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229610AbiILIIn (ORCPT ); Mon, 12 Sep 2022 04:08:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41604 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229712AbiILIId (ORCPT ); Mon, 12 Sep 2022 04:08:33 -0400 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5FC6F2B24B for ; Mon, 12 Sep 2022 01:08:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1662970111; x=1694506111; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=s7Jug/OnMCFhyd1q5xTwD79VDV4Ia8xhw4W5pOzqF7Q=; b=ethQGijyqTohSm8m8ZEA7E4M8X2FtWC2R9X1m1iBUIK7W4rqzlkvMf6T vmC3MEsc/6IN2Sljtcu86DmsaMXPJnopB9yWBkFQAYuwgMNLjJMiLO7tY E09LuuCTsOp1z1TGexyGipC/7L+ZZrgNZL3OeGbKMKDYQxLMObonR8IDK tQ2l/TaL4XQiZJ/cmy/rWWHm+4SNAS0zmZUYFpk5KQzy6ea2ewXuNgNN9 QLyp3AVQpF2S6V9WiHFKSkiCosgei7p9dUyJ+rhdW1jVSeAv2rjwzJFhL MJwlyp2gvMwW7fMZPQ9Fw/fBi8y1XIHfHWBl2hg5TqfaO71IxA5ztHdZU Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10467"; a="296545692" X-IronPort-AV: E=Sophos;i="5.93,308,1654585200"; d="scan'208";a="296545692" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Sep 2022 01:08:28 -0700 X-IronPort-AV: E=Sophos;i="5.93,308,1654585200"; d="scan'208";a="646358310" Received: from abijaz-mobl.ger.corp.intel.com (HELO localhost) ([10.252.58.140]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Sep 2022 01:08:24 -0700 From: Jani Nikula To: Hamza Mahfooz , linux-kernel@vger.kernel.org Cc: Hamza Mahfooz , Jernej Skrabec , Jonas Karlman , David Airlie , Allen Chen , dri-devel@lists.freedesktop.org, Neil Armstrong , Robert Foss , Hermes Wu , Laurent Pinchart , Andrzej Hajda , AngeloGioacchino Del Regno Subject: Re: [PATCH] drm/bridge: it6505: use drm_debug_enabled() in it6505_debug_print() In-Reply-To: <20220910224816.15058-1-someguy@effective-light.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20220910224816.15058-1-someguy@effective-light.com> Date: Mon, 12 Sep 2022 11:08:19 +0300 Message-ID: <875yht6mmk.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 10 Sep 2022, Hamza Mahfooz wrote: > As made mention of in commit 9f0ac028410f ("drm/print: rename drm_debug > to __drm_debug to discourage use"), we shouldn't explicitly refer to > __drm_debug in this context. So, use drm_debug_enabled() instead. > > Fixes: b5c84a9edcd4 ("drm/bridge: add it6505 driver") > Signed-off-by: Hamza Mahfooz Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/bridge/ite-it6505.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/bridge/ite-it6505.c b/drivers/gpu/drm/bridge/ite-it6505.c > index 4b673c4792d7..875f87c576cb 100644 > --- a/drivers/gpu/drm/bridge/ite-it6505.c > +++ b/drivers/gpu/drm/bridge/ite-it6505.c > @@ -554,7 +554,7 @@ static void it6505_debug_print(struct it6505 *it6505, unsigned int reg, > struct device *dev = &it6505->client->dev; > int val; > > - if (likely(!(__drm_debug & DRM_UT_DRIVER))) > + if (!drm_debug_enabled(DRM_UT_DRIVER)) > return; > > val = it6505_read(it6505, reg); -- Jani Nikula, Intel Open Source Graphics Center