From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53884C43334 for ; Fri, 10 Jun 2022 07:48:36 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id A8DF24B3C2; Fri, 10 Jun 2022 03:48:35 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@kernel.org Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cdBgAxvk9Eee; Fri, 10 Jun 2022 03:48:34 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 613D54B3BC; Fri, 10 Jun 2022 03:48:34 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 517304B3BC for ; Fri, 10 Jun 2022 03:48:33 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Rl4v+G18khif for ; Fri, 10 Jun 2022 03:48:32 -0400 (EDT) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 0D8094B3B1 for ; Fri, 10 Jun 2022 03:48:31 -0400 (EDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0924662005; Fri, 10 Jun 2022 07:48:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 689C6C34114; Fri, 10 Jun 2022 07:48:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1654847310; bh=/SSyOqIVFQI+dmFlHOcPAt+HQ7s+mI3SernZbSQfbuo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=nWG7q2OkeMoWBf8e+DwDHOUXu0j+RKG7K8o2PW9SvvtYI7GPTEgP93O21bROU1/+o A99x1lFOTPdeoeJfRcm07sNn4LVMfFj2LwXv6hfI5ZL2r/dLBRzMyi/50f001dz6a4 Fcr32ZDVHGhCx5c5DICeK2mmkHFZdaB6Pwe0zaZ95pTp7okb3n8z9fFmqKcPn47eWg J7VuQoS9HjSMj1tH6Ec6J8IDwLqt2HkLhlRHUczlt6WmNKcy+ndaRgB3Z86vGq+hYl BKIdMxatu3L97ZtpZWFK9ncvsWCruyealYwrIv4aW2fQWBG3lhLUgfNKt8iSITjgRr RekSMnBWKQDyw== Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nzZNb-00H4OH-Tz; Fri, 10 Jun 2022 08:48:28 +0100 Date: Fri, 10 Jun 2022 08:48:27 +0100 Message-ID: <875yl93qno.wl-maz@kernel.org> From: Marc Zyngier To: Reiji Watanabe Subject: Re: [PATCH 06/18] KVM: arm64: Add three sets of flags to the vcpu state In-Reply-To: References: <20220528113829.1043361-1-maz@kernel.org> <20220528113829.1043361-7-maz@kernel.org> <87fske46tp.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: reijiw@google.com, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel-team@android.com, will@kernel.org, broonie@kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Cc: kvm@vger.kernel.org, kernel-team@android.com, Mark Brown , Will Deacon , kvmarm@lists.cs.columbia.edu, Linux ARM X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Thu, 09 Jun 2022 18:24:39 +0100, Reiji Watanabe wrote: > > I've just realized that GUEST_HAS_PTRAUTH (cflags) is used by > hypervisor code (kvm_hyp_handle_ptrauth and get_pvm_id_aa64isar{1,2}). > Shouldn't GUEST_HAS_PTRAUTH be handled as iflags ? > Or, in choosing one of these three for a flag, is immutability (once > the vcpu has run) the highest priority, followed by whether or not > it is used by hypervisor code ? It can be construed that most configuration flags are also input flags to the hypervisor, as they will eventually affect its behaviour. But the fact that a flag is immutable once the vcpu has run is a clear criterion for a configuration flag. Thanks, M. -- Without deviation from the norm, progress is not possible. _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8953AC433EF for ; Fri, 10 Jun 2022 07:49:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KrgN/qQ7KcxAb6dJptyNYa3G1u6bolhEVI9OGCwgDpM=; b=wU4D2kFaz7YoK2 z41kIyafk0vUXArpJ1KzPdt2jyzhmKO9Fo7gq9CLktZiAiOOXXwEpXKsgRVrCjjKNKXm9xjVP18h/ DNsxHPMIHa5IBKMs4Oddm3LWse1XKOfiwbaoFWIYMEmvd93xFvbSt7kuAk21jIklTn9OKTwNydetE kzKKxGzDe+zRlYa3u+Jphp3Cus9DuIRighn+3FoSHB2Zed/WAiAl9i/rXzVjlGHSnzh2fXUGbsIQo 8Utz5F0c4GspteV+IXfXO5nbqWWjEAr6AOsl9OIDRV6ZM9yveXZ76P4nxwICROhhn+bxsUBe3fooj tZYyVS2/ZChIsuSavXxQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nzZNi-006YQa-LC; Fri, 10 Jun 2022 07:48:34 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nzZNf-006YOC-LK for linux-arm-kernel@lists.infradead.org; Fri, 10 Jun 2022 07:48:32 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0924662005; Fri, 10 Jun 2022 07:48:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 689C6C34114; Fri, 10 Jun 2022 07:48:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1654847310; bh=/SSyOqIVFQI+dmFlHOcPAt+HQ7s+mI3SernZbSQfbuo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=nWG7q2OkeMoWBf8e+DwDHOUXu0j+RKG7K8o2PW9SvvtYI7GPTEgP93O21bROU1/+o A99x1lFOTPdeoeJfRcm07sNn4LVMfFj2LwXv6hfI5ZL2r/dLBRzMyi/50f001dz6a4 Fcr32ZDVHGhCx5c5DICeK2mmkHFZdaB6Pwe0zaZ95pTp7okb3n8z9fFmqKcPn47eWg J7VuQoS9HjSMj1tH6Ec6J8IDwLqt2HkLhlRHUczlt6WmNKcy+ndaRgB3Z86vGq+hYl BKIdMxatu3L97ZtpZWFK9ncvsWCruyealYwrIv4aW2fQWBG3lhLUgfNKt8iSITjgRr RekSMnBWKQDyw== Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nzZNb-00H4OH-Tz; Fri, 10 Jun 2022 08:48:28 +0100 Date: Fri, 10 Jun 2022 08:48:27 +0100 Message-ID: <875yl93qno.wl-maz@kernel.org> From: Marc Zyngier To: Reiji Watanabe Cc: kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, Linux ARM , kernel-team@android.com, Will Deacon , Mark Brown Subject: Re: [PATCH 06/18] KVM: arm64: Add three sets of flags to the vcpu state In-Reply-To: References: <20220528113829.1043361-1-maz@kernel.org> <20220528113829.1043361-7-maz@kernel.org> <87fske46tp.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: reijiw@google.com, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel-team@android.com, will@kernel.org, broonie@kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220610_004831_754654_D103563E X-CRM114-Status: GOOD ( 17.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 09 Jun 2022 18:24:39 +0100, Reiji Watanabe wrote: > > I've just realized that GUEST_HAS_PTRAUTH (cflags) is used by > hypervisor code (kvm_hyp_handle_ptrauth and get_pvm_id_aa64isar{1,2}). > Shouldn't GUEST_HAS_PTRAUTH be handled as iflags ? > Or, in choosing one of these three for a flag, is immutability (once > the vcpu has run) the highest priority, followed by whether or not > it is used by hypervisor code ? It can be construed that most configuration flags are also input flags to the hypervisor, as they will eventually affect its behaviour. But the fact that a flag is immutable once the vcpu has run is a clear criterion for a configuration flag. Thanks, M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2945C433EF for ; Fri, 10 Jun 2022 07:48:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346980AbiFJHsi (ORCPT ); Fri, 10 Jun 2022 03:48:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60332 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239154AbiFJHsc (ORCPT ); Fri, 10 Jun 2022 03:48:32 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6D70815D2FD for ; Fri, 10 Jun 2022 00:48:31 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 091F761F42 for ; Fri, 10 Jun 2022 07:48:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 689C6C34114; Fri, 10 Jun 2022 07:48:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1654847310; bh=/SSyOqIVFQI+dmFlHOcPAt+HQ7s+mI3SernZbSQfbuo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=nWG7q2OkeMoWBf8e+DwDHOUXu0j+RKG7K8o2PW9SvvtYI7GPTEgP93O21bROU1/+o A99x1lFOTPdeoeJfRcm07sNn4LVMfFj2LwXv6hfI5ZL2r/dLBRzMyi/50f001dz6a4 Fcr32ZDVHGhCx5c5DICeK2mmkHFZdaB6Pwe0zaZ95pTp7okb3n8z9fFmqKcPn47eWg J7VuQoS9HjSMj1tH6Ec6J8IDwLqt2HkLhlRHUczlt6WmNKcy+ndaRgB3Z86vGq+hYl BKIdMxatu3L97ZtpZWFK9ncvsWCruyealYwrIv4aW2fQWBG3lhLUgfNKt8iSITjgRr RekSMnBWKQDyw== Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nzZNb-00H4OH-Tz; Fri, 10 Jun 2022 08:48:28 +0100 Date: Fri, 10 Jun 2022 08:48:27 +0100 Message-ID: <875yl93qno.wl-maz@kernel.org> From: Marc Zyngier To: Reiji Watanabe Cc: kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, Linux ARM , kernel-team@android.com, Will Deacon , Mark Brown Subject: Re: [PATCH 06/18] KVM: arm64: Add three sets of flags to the vcpu state In-Reply-To: References: <20220528113829.1043361-1-maz@kernel.org> <20220528113829.1043361-7-maz@kernel.org> <87fske46tp.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: reijiw@google.com, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel-team@android.com, will@kernel.org, broonie@kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Thu, 09 Jun 2022 18:24:39 +0100, Reiji Watanabe wrote: > > I've just realized that GUEST_HAS_PTRAUTH (cflags) is used by > hypervisor code (kvm_hyp_handle_ptrauth and get_pvm_id_aa64isar{1,2}). > Shouldn't GUEST_HAS_PTRAUTH be handled as iflags ? > Or, in choosing one of these three for a flag, is immutability (once > the vcpu has run) the highest priority, followed by whether or not > it is used by hypervisor code ? It can be construed that most configuration flags are also input flags to the hypervisor, as they will eventually affect its behaviour. But the fact that a flag is immutable once the vcpu has run is a clear criterion for a configuration flag. Thanks, M. -- Without deviation from the norm, progress is not possible.