From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: Zhengchao Shao <shaozhengchao@huawei.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
bpf@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com
Cc: ast@kernel.org, daniel@iogearbox.net, hawk@kernel.org,
john.fastabend@gmail.com, andrii@kernel.org, kafai@fb.com,
songliubraving@fb.com, yhs@fb.com, kpsingh@kernel.org,
bigeasy@linutronix.de, imagedong@tencent.com, petrm@nvidia.com,
memxor@gmail.com, arnd@arndb.de, weiyongjun1@huawei.com,
shaozhengchao@huawei.com, yuehaibing@huawei.com
Subject: Re: [PATCH bpf-next] bpf/xdp: Can't detach BPF XDP prog if not exist
Date: Wed, 04 May 2022 13:19:49 +0200 [thread overview]
Message-ID: <875ymlwnmy.fsf@toke.dk> (raw)
In-Reply-To: <20220504035207.98221-1-shaozhengchao@huawei.com>
Zhengchao Shao <shaozhengchao@huawei.com> writes:
> if user sets nonexistent xdp_flags to detach xdp prog, kernel should
> return err and tell user that detach failed with detail info.
>
> Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
I kinda see your point, but this will change user-visible behaviour that
applications might be relying on, so I don't think we can make this
change at this stage. Why can't your application just query the link for
whether a program is attached?
-Toke
next prev parent reply other threads:[~2022-05-04 11:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-04 3:52 [PATCH bpf-next] bpf/xdp: Can't detach BPF XDP prog if not exist Zhengchao Shao
2022-05-04 11:19 ` Toke Høiland-Jørgensen [this message]
2022-05-05 8:21 ` 答复: " shaozhengchao
2022-05-05 14:27 ` Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875ymlwnmy.fsf@toke.dk \
--to=toke@redhat.com \
--cc=andrii@kernel.org \
--cc=arnd@arndb.de \
--cc=ast@kernel.org \
--cc=bigeasy@linutronix.de \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=imagedong@tencent.com \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kpsingh@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=memxor@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=shaozhengchao@huawei.com \
--cc=songliubraving@fb.com \
--cc=weiyongjun1@huawei.com \
--cc=yhs@fb.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.