From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BA3AEC433EF for ; Mon, 28 Mar 2022 18:36:32 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2ABF810E287; Mon, 28 Mar 2022 18:36:32 +0000 (UTC) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id E090510E246; Mon, 28 Mar 2022 18:36:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1648492590; x=1680028590; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=yzeVvCY6eqwG29hVG/giVQ00H2WTTuSc9twI97r1Ap8=; b=ZO2VNwVETm+XQq7Wk6Dhp4fErg1pvoL4EWNYAGAe11n/LEIQNKoj024w a8BAkFA1231gKc4gmjSpmrWjMVoPxFuEq8toqMJCkaebXHEN9Z4nDXiDr WGG/r+0rh66P0634XBkz8optsh9Q035rVf5i1Ci2omNgHYKgJjdeFwbF4 ngXEHMRs/1LjRv9QVJ4Y3JmISuLYw9kl/8AbUJl42xpE4eWJ6TG/rLbX/ XeBKtajdNJKvBMAKMeYwjkXJ0uSSRwSnDENsZDXn4zDeF2rSwd6IamjwM 505JWbpSDXj7Mux9Xai97Bc1F7l1yb9NglipHqELEVYkBvkJII3UtPLwE g==; X-IronPort-AV: E=McAfee;i="6200,9189,10300"; a="322264360" X-IronPort-AV: E=Sophos;i="5.90,218,1643702400"; d="scan'208";a="322264360" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Mar 2022 11:36:30 -0700 X-IronPort-AV: E=Sophos;i="5.90,218,1643702400"; d="scan'208";a="546070526" Received: from aysivtso-mobl.ccr.corp.intel.com (HELO localhost) ([10.252.62.56]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Mar 2022 11:36:28 -0700 From: Jani Nikula To: Emil Velikov In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: Date: Mon, 28 Mar 2022 21:36:19 +0300 Message-ID: <875ynxexgc.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Intel-gfx] [PATCH v3 00/12] drm/edid: constify EDID parsing, with fixes X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Intel Graphics Development , ML dri-devel Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Mon, 28 Mar 2022, Emil Velikov wrote: > On Mon, 28 Mar 2022 at 15:34, Jani Nikula wrote: >> >> v3 of https://patchwork.freedesktop.org/series/101787/ and >> https://patchwork.freedesktop.org/series/101862/ >> >> I screwed up with the struct renamings in v2, so there's some falling >> back to v1 and general confusion here. Sorry. >> > > The mutation and casting was doing my head - thanks for sorting this out. > > IMHO in the future we might want to (re)move the final mutation - > header fixup - out of drm_edid_is_valid (drm_edid_block_valid really). > Say by making it explicit and applying on DP only (as per the inline > spec mention). > But that is for another day. Yes, there's a bunch more things to do, and patches will follow! > As-is the series is: > Reviewed-by: Emil Velikov Thanks! BR, Jani. > > HTH > Emil -- Jani Nikula, Intel Open Source Graphics Center From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CCE76C433FE for ; Mon, 28 Mar 2022 18:36:33 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C464810E771; Mon, 28 Mar 2022 18:36:32 +0000 (UTC) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id E090510E246; Mon, 28 Mar 2022 18:36:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1648492590; x=1680028590; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=yzeVvCY6eqwG29hVG/giVQ00H2WTTuSc9twI97r1Ap8=; b=ZO2VNwVETm+XQq7Wk6Dhp4fErg1pvoL4EWNYAGAe11n/LEIQNKoj024w a8BAkFA1231gKc4gmjSpmrWjMVoPxFuEq8toqMJCkaebXHEN9Z4nDXiDr WGG/r+0rh66P0634XBkz8optsh9Q035rVf5i1Ci2omNgHYKgJjdeFwbF4 ngXEHMRs/1LjRv9QVJ4Y3JmISuLYw9kl/8AbUJl42xpE4eWJ6TG/rLbX/ XeBKtajdNJKvBMAKMeYwjkXJ0uSSRwSnDENsZDXn4zDeF2rSwd6IamjwM 505JWbpSDXj7Mux9Xai97Bc1F7l1yb9NglipHqELEVYkBvkJII3UtPLwE g==; X-IronPort-AV: E=McAfee;i="6200,9189,10300"; a="322264360" X-IronPort-AV: E=Sophos;i="5.90,218,1643702400"; d="scan'208";a="322264360" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Mar 2022 11:36:30 -0700 X-IronPort-AV: E=Sophos;i="5.90,218,1643702400"; d="scan'208";a="546070526" Received: from aysivtso-mobl.ccr.corp.intel.com (HELO localhost) ([10.252.62.56]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Mar 2022 11:36:28 -0700 From: Jani Nikula To: Emil Velikov Subject: Re: [PATCH v3 00/12] drm/edid: constify EDID parsing, with fixes In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: Date: Mon, 28 Mar 2022 21:36:19 +0300 Message-ID: <875ynxexgc.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Intel Graphics Development , ML dri-devel Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, 28 Mar 2022, Emil Velikov wrote: > On Mon, 28 Mar 2022 at 15:34, Jani Nikula wrote: >> >> v3 of https://patchwork.freedesktop.org/series/101787/ and >> https://patchwork.freedesktop.org/series/101862/ >> >> I screwed up with the struct renamings in v2, so there's some falling >> back to v1 and general confusion here. Sorry. >> > > The mutation and casting was doing my head - thanks for sorting this out. > > IMHO in the future we might want to (re)move the final mutation - > header fixup - out of drm_edid_is_valid (drm_edid_block_valid really). > Say by making it explicit and applying on DP only (as per the inline > spec mention). > But that is for another day. Yes, there's a bunch more things to do, and patches will follow! > As-is the series is: > Reviewed-by: Emil Velikov Thanks! BR, Jani. > > HTH > Emil -- Jani Nikula, Intel Open Source Graphics Center