From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a05:6512:204:0:0:0:0 with SMTP id a4csp2891871lfo; Tue, 15 Mar 2022 06:59:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxiVw4IMHA1jVo0DCZGKuuX1M3BGTdOG21wsghaTM22PNBYb67Vs4He7/isF1z1B55C2bVD X-Received: by 2002:a05:622a:1a24:b0:2e0:722c:b13a with SMTP id f36-20020a05622a1a2400b002e0722cb13amr22369708qtb.519.1647352771987; Tue, 15 Mar 2022 06:59:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1647352771; cv=none; d=google.com; s=arc-20160816; b=SONdGHW5jdvB99egaZjzuboW6IJ+IOH8YOStkdANippijiJ8n0yHlF13egv+52w+vq yqldTyGyEF7Wo2SPATtxkARsRfecX/Zmj75Pe0iTea9VEDoO/6BzUccALfU2wMiWeBh4 KGI7MFCJtqfIUVH8OxtD44v1Px5FawyB20f9YTTv5a5YZxjp9ua1vbxhG/ci8+G2Yqjd wbYbbIlHYGVCYUUSdddHkbWdBcZEN2UQhcvWxgwkeqqqudRr92vIBqFLMYaww9hjqI0C 3oqv/BRRNv5M5sfddNznbmpCU16Znd27RgzwAqBjcQxUvy/LlTwU8UoIvo7KVYMJWTX+ msrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:dkim-signature; bh=10cE4rX5AbTqcs0aOxAVWmDdYLmGBY4pMBpqNlvJA4U=; b=l7kIWEvBFGn2zoVz+li6A0ED4RHP8d+g4brA5Mr6o123M93itww1LbNpROa8jrConH FHave05Ccj7dTogAyeBFAKpeZzWwNJ/C9fk2ngNumO8plAObwrSEhW/PnqePAnahiSW6 Kq1Z4Hc+1RGKhL1E3dDQrrVQw5Vj1yDMT1XwL5fh7DZU+qG1rSk1P7L0LCtKu7+9/XlI lFf4nCfYVywlyZT5lPtIt0oCnGug1Kyvbjhi/jowd/vbAXw8a1d1285CaXTOCQIvAKov gCGM8qwuZjOJnrYZ/4eqsCm2gTCx1nuFel381NUYOWKkOK+Fu89l/YT4UFMlKSP+6+N6 m76A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=WYCmK2Ic; spf=pass (google.com: domain of armbru@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=armbru@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com. [170.10.129.124]) by mx.google.com with ESMTPS id gi15-20020a056214248f00b00440abc3b9a6si2871727qvb.231.2022.03.15.06.59.31 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 15 Mar 2022 06:59:31 -0700 (PDT) Received-SPF: pass (google.com: domain of armbru@redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=WYCmK2Ic; spf=pass (google.com: domain of armbru@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=armbru@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1647352771; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=10cE4rX5AbTqcs0aOxAVWmDdYLmGBY4pMBpqNlvJA4U=; b=WYCmK2IcLNHwAKFunA/FTv3SAsln3J9aZDgV1sewl6qRTnsW12ZIHChi+YbUwtGIRci7AU uGTqRwhG/ydrVMuBKKLcqkNzkFd3F7yDNN4ZcMbHcTah4xT+NZeFdMmldjFoTGVIHGg/6w HnvwJ0PnC6QiKOKyvM6x6BmpnwY2g7I= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-297-Upv_Mb-OOSWIHvms5WArsw-1; Tue, 15 Mar 2022 09:59:27 -0400 X-MC-Unique: Upv_Mb-OOSWIHvms5WArsw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E16CB3C18527; Tue, 15 Mar 2022 13:59:25 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.36.112.3]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6292CC50943; Tue, 15 Mar 2022 13:59:25 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 1623721E6821; Tue, 15 Mar 2022 14:59:24 +0100 (CET) From: Markus Armbruster To: Alex =?utf-8?Q?Benn=C3=A9e?= Cc: qemu-devel@nongnu.org, Paolo Bonzini , Richard Henderson , Gerd Hoffmann , Christian Schoenebeck , "Gonglei (Arei)" , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , "Michael S. Tsirkin" , Igor Mammedov , Ani Sinha , Laurent Vivier , Amit Shah , Peter Maydell , Stefano Stabellini , Anthony Perard , Paul Durrant , =?utf-8?Q?Herv=C3=A9?= Poussineau , Aleksandar Rikalo , Corey Minyard , Patrick Venture , Eduardo Habkost , Marcel Apfelbaum , Peter Xu , Jason Wang , =?utf-8?Q?C=C3=A9dric?= Le Goater , Daniel Henrique Barboza , David Gibson , Greg Kurz , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Jean-Christophe Dubois , Keith Busch , Klaus Jensen , Yuval Shaia , Yoshinori Sato , Magnus Damm , Fabien Chouteau , KONRAD Frederic , Mark Cave-Ayland , Artyom Tarasenko , Alex Williamson , Eric Auger , Max Filippov , Juan Quintela , "Dr. David Alan Gilbert" , Konstantin Kostiuk , Michael Roth , Daniel P. =?utf-8?Q?Berrang=C3=A9?= , Pavel Dovgalyuk , David Hildenbrand , Wenchao Wang , Colin Xu , Kamil Rytarowski , Reinoud Zandijk , Sunil Muthuswamy , Cornelia Huck , Thomas Huth , Eric Blake , Vladimir Sementsov-Ogievskiy , John Snow , kvm@vger.kernel.org, qemu-arm@nongnu.org, xen-devel@lists.xenproject.org, qemu-ppc@nongnu.org, qemu-block@nongnu.org, haxm-team@intel.com, qemu-s390x@nongnu.org Subject: Re: [PATCH 3/3] Use g_new() & friends where that makes obvious sense References: <20220314160108.1440470-1-armbru@redhat.com> <20220314160108.1440470-4-armbru@redhat.com> <87y21c401e.fsf@linaro.org> Date: Tue, 15 Mar 2022 14:59:24 +0100 In-Reply-To: <87y21c401e.fsf@linaro.org> ("Alex =?utf-8?Q?Benn=C3=A9e=22's?= message of "Mon, 14 Mar 2022 22:52:52 +0000") Message-ID: <875yofl3k3.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.8 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=armbru@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-TUID: jCDqUuHtO89e Alex Benn=C3=A9e writes: > Markus Armbruster writes: > >> g_new(T, n) is neater than g_malloc(sizeof(T) * n). It's also safer, >> for two reasons. One, it catches multiplication overflowing size_t. >> Two, it returns T * rather than void *, which lets the compiler catch >> more type errors. >> > >> diff --git a/semihosting/config.c b/semihosting/config.c >> index 137171b717..6d48ec9566 100644 >> --- a/semihosting/config.c >> +++ b/semihosting/config.c >> @@ -98,7 +98,7 @@ static int add_semihosting_arg(void *opaque, >> if (strcmp(name, "arg") =3D=3D 0) { >> s->argc++; >> /* one extra element as g_strjoinv() expects NULL-terminated ar= ray */ >> - s->argv =3D g_realloc(s->argv, (s->argc + 1) * sizeof(void *)); >> + s->argv =3D g_renew(void *, s->argv, s->argc + 1); > > This did indeed break CI because s->argv is an array of *char: > > ../semihosting/config.c:101:17: error: assignment to =E2=80=98const char = **=E2=80=99 from incompatible pointer type =E2=80=98void **=E2=80=99 [-Werr= or=3Dincompatible-pointer-types] > 101 | s->argv =3D g_renew(void *, s->argv, s->argc + 1); > | ^ > cc1: all warnings being treated as errors > > So it did the job of type checking but failed to build ;-) You found a hole in my compile testing, thanks! I got confused about the configuration of my build trees. Catching such mistakes is what CI is for :) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5BE2EC433FE for ; Tue, 15 Mar 2022 14:01:44 +0000 (UTC) Received: from localhost ([::1]:44600 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nU7k7-0000kb-BE for qemu-devel@archiver.kernel.org; Tue, 15 Mar 2022 10:01:43 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47422) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nU7i0-0007lY-A0 for qemu-devel@nongnu.org; Tue, 15 Mar 2022 09:59:32 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:25068) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nU7hx-0002On-VO for qemu-devel@nongnu.org; Tue, 15 Mar 2022 09:59:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1647352768; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=10cE4rX5AbTqcs0aOxAVWmDdYLmGBY4pMBpqNlvJA4U=; b=dPlxka4zEBhVE44lmG/hniRYfPwYBOwUk+ho4yKdzQUCLW2PicxuEIzSzdNWaqYNkTyKqx lDKIFILtzKmCXG3aNcdnYM5IsT9HTtlajMmGeYhrlJikKxKBVMzir7QLGflGu2jL0Jxi8+ G0zFvG7JYiMtltPPuBCnG+KtbKOhGn4= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-297-Upv_Mb-OOSWIHvms5WArsw-1; Tue, 15 Mar 2022 09:59:27 -0400 X-MC-Unique: Upv_Mb-OOSWIHvms5WArsw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E16CB3C18527; Tue, 15 Mar 2022 13:59:25 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.36.112.3]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6292CC50943; Tue, 15 Mar 2022 13:59:25 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 1623721E6821; Tue, 15 Mar 2022 14:59:24 +0100 (CET) From: Markus Armbruster To: Alex =?utf-8?Q?Benn=C3=A9e?= Subject: Re: [PATCH 3/3] Use g_new() & friends where that makes obvious sense References: <20220314160108.1440470-1-armbru@redhat.com> <20220314160108.1440470-4-armbru@redhat.com> <87y21c401e.fsf@linaro.org> Date: Tue, 15 Mar 2022 14:59:24 +0100 In-Reply-To: <87y21c401e.fsf@linaro.org> ("Alex =?utf-8?Q?Benn=C3=A9e=22's?= message of "Mon, 14 Mar 2022 22:52:52 +0000") Message-ID: <875yofl3k3.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.8 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=armbru@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Daniel Henrique Barboza , kvm@vger.kernel.org, "Michael S. Tsirkin" , Jason Wang , Christian Schoenebeck , qemu-devel@nongnu.org, Peter Xu , Klaus Jensen , KONRAD Frederic , Konstantin Kostiuk , Gerd Hoffmann , Ani Sinha , Reinoud Zandijk , Eric Blake , Sunil Muthuswamy , Stefano Stabellini , xen-devel@lists.xenproject.org, Yoshinori Sato , Juan Quintela , Paul Durrant , Magnus Damm , Kamil Rytarowski , "Gonglei \(Arei\)" , =?utf-8?Q?Herv=C3=A9?= Poussineau , Michael Roth , Anthony Perard , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Artyom Tarasenko , Laurent Vivier , Aleksandar Rikalo , Amit Shah , Mark Cave-Ayland , haxm-team@intel.com, Richard Henderson , Greg Kurz , Fabien Chouteau , Yuval Shaia , Thomas Huth , Eric Auger , Alex Williamson , qemu-arm@nongnu.org, =?utf-8?Q?C=C3=A9dric?= Le Goater , Pavel Dovgalyuk , Paolo Bonzini , Keith Busch , qemu-ppc@nongnu.org, David Hildenbrand , John Snow , David Gibson , Eduardo Habkost , Vladimir Sementsov-Ogievskiy , "Daniel P. =?utf-8?Q?Berrang=C3=A9?=" , qemu-block@nongnu.org, Max Filippov , qemu-s390x@nongnu.org, Patrick Venture , Cornelia Huck , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Jean-Christophe Dubois , Corey Minyard , Wenchao Wang , Igor Mammedov , "Dr. David Alan Gilbert" , Colin Xu Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Alex Benn=C3=A9e writes: > Markus Armbruster writes: > >> g_new(T, n) is neater than g_malloc(sizeof(T) * n). It's also safer, >> for two reasons. One, it catches multiplication overflowing size_t. >> Two, it returns T * rather than void *, which lets the compiler catch >> more type errors. >> > >> diff --git a/semihosting/config.c b/semihosting/config.c >> index 137171b717..6d48ec9566 100644 >> --- a/semihosting/config.c >> +++ b/semihosting/config.c >> @@ -98,7 +98,7 @@ static int add_semihosting_arg(void *opaque, >> if (strcmp(name, "arg") =3D=3D 0) { >> s->argc++; >> /* one extra element as g_strjoinv() expects NULL-terminated ar= ray */ >> - s->argv =3D g_realloc(s->argv, (s->argc + 1) * sizeof(void *)); >> + s->argv =3D g_renew(void *, s->argv, s->argc + 1); > > This did indeed break CI because s->argv is an array of *char: > > ../semihosting/config.c:101:17: error: assignment to =E2=80=98const char = **=E2=80=99 from incompatible pointer type =E2=80=98void **=E2=80=99 [-Werr= or=3Dincompatible-pointer-types] > 101 | s->argv =3D g_renew(void *, s->argv, s->argc + 1); > | ^ > cc1: all warnings being treated as errors > > So it did the job of type checking but failed to build ;-) You found a hole in my compile testing, thanks! I got confused about the configuration of my build trees. Catching such mistakes is what CI is for :)