From: Markus Armbruster <armbru@redhat.com>
To: Fabian Holler <fabian.holler@simplesurance.de>
Cc: Eric Blake <eblake@redhat.com>,
qemu-devel@nongnu.org,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Juan Quintela <quintela@redhat.com>
Subject: Re: [PATCH v2] qapi/migration: Fix examples document wrong field name for arguments
Date: Wed, 23 Feb 2022 08:51:31 +0100 [thread overview]
Message-ID: <875yp6ggvw.fsf@pond.sub.org> (raw)
In-Reply-To: <20220222170116.63105-1-fabian.holler@simplesurance.de> (Fabian Holler's message of "Tue, 22 Feb 2022 18:01:16 +0100")
Fabian Holler <fabian.holler@simplesurance.de> writes:
> The examples for the snapshot-* and calc-dirty-rate commands document
> that arguments for the commands are passed in a 'data' field.
> This is wrong, passing them in a "data" field results in
> the error:
> {"error": {"class": "GenericError", "desc": "QMP input member 'data'
> is unexpected"}}
> Arguments are expected to be passed in an field called "arguments".
>
> Replace "data" with "arguments" in the snapshot-* and calc-dirty-rate
> command examples.
>
> Signed-off-by: Fabian Holler <fabian.holler@simplesurance.de>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Queued, thanks!
prev parent reply other threads:[~2022-02-23 7:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-22 17:01 [PATCH v2] qapi/migration: Fix examples document wrong field name for arguments Fabian Holler
2022-02-23 7:51 ` Markus Armbruster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875yp6ggvw.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=fabian.holler@simplesurance.de \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.