From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id CCCE310E340 for ; Tue, 25 Jan 2022 23:50:45 +0000 (UTC) Date: Tue, 25 Jan 2022 15:50:44 -0800 Message-ID: <875yq7pe7f.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" In-Reply-To: <20211207131013.27252-1-zbigniew.kempczynski@intel.com> References: <20211207131013.27252-1-zbigniew.kempczynski@intel.com> MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=ISO-8859-2 Content-Transfer-Encoding: quoted-printable Subject: Re: [igt-dev] [PATCH i-g-t] tests/gem_exec_fence: Adopt to use no-reloc in three syncobj subtests List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Zbigniew =?ISO-8859-2?Q?Kempczy=F1ski?= Cc: igt-dev@lists.freedesktop.org List-ID: On Tue, 07 Dec 2021 05:10:13 -0800, Zbigniew Kempczy=F1ski wrote: > > Three subtests: > - syncobj-timeline-chain-engines > - syncobj-stationary-timeline-chain-engines > - syncobj-backward-timeline-chain-engines > were not previously rewritten to use no-reloc. > > Using allocator is not necessary in this case, we need to softpin > only counter object. Offsets for all batches are chosen by the > kernel as they location within gpu vm doesn't matter. OK, because of I915_EXEC_NO_RELOC etc. Also, s/they/their/ Sorry for the delay in getting to this. The patch looks correct: Reviewed-by: Ashutosh Dixit