From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 85E1FC433F5 for ; Tue, 30 Nov 2021 22:41:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EVJ5iYMA0iW/jz6RBHqJy9HEKNvQPvbqPxzzWwB7cKA=; b=OroNNfEY3pkSxV 4X1Rx4AhbSbqrpKKbNrw9FH+zww9wsPOoYfTDC9Ti1RSBoSrIpiLkbuvZWjpWalnEaTIWTrMweQ1I MJRhXwGFs4qNCYTfFs3Jv2mCFWSj01pzGwmGf3moOu8RqzxhZ0ZRTJjtwzzVRzHKxHHsxYSR6DQS2 csEYqAY8PwZUcQW3HE2wN9Jk3Sbd9uivkdI/CdWjfT5uhrbVaNMd9RIvGKXaHFAkQMMtuJ4CcmiPQ 2sENWiKKCiKVXKuHU23HecQ7z0uoiC65Tlh5bknIgcHdnxc5Q50WH88sl45Fln9VZQ5qzKNGty7qg 2OYHR/DDCep1T9aOA+dQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1msBoc-0075u4-6e; Tue, 30 Nov 2021 22:41:34 +0000 Received: from galois.linutronix.de ([193.142.43.55]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1msBoZ-0075tC-UO for ath11k@lists.infradead.org; Tue, 30 Nov 2021 22:41:33 +0000 From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1638312089; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1bOw8HEe7jHxyt1BTzbWx6wvk9iJpbF5Gn0Kg7y1Blo=; b=2IrmNv3Iea3b/0P87xEGqZAZmwL1onSUMGqd0zxtDIRJLTynmNSC7uxIH8L/l5dtLj/5OD JagFWx3aJMiS1LFIeYftEfo0Ur2kNjTtrOTkBnBmsBzvAxM9ucbFfqPVN5bViblbdfTyHh DmsunGG30VGceQJj3KLRF3KIyBTUwjdi6+cIFEZFOGwVLxR6/Qv+GDEs3kZsbO3Sb5vEY4 CGDmi02z+2/4fP0CRSLAGmUXhnn/6DLG04oqIJtIelaVlS8RIp1r9e2Sxk09e7hCcOFzEs b9sVLSs/CWxPIfpw834x9ILDVWh3TWdsOj5JuMEeZ6q+sN/NVCvFkfOxPIzp8w== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1638312089; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1bOw8HEe7jHxyt1BTzbWx6wvk9iJpbF5Gn0Kg7y1Blo=; b=wP+0RlPVEZMaKpggmpseYFDjn/awmzpDeY9BMit0WIgaUAvSVTefpWgNK6fro3P2SJv3Ar 0+sa+FEk57SExTAA== To: =?utf-8?Q?C=C3=A9dric?= Le Goater , LKML Cc: linux-hyperv@vger.kernel.org, Paul Mackerras , sparclinux@vger.kernel.org, Wei Liu , Ashok Raj , Marc Zygnier , x86@kernel.org, Christian Borntraeger , Bjorn Helgaas , Jason Gunthorpe , linux-pci@vger.kernel.org, xen-devel@lists.xenproject.org, ath11k@lists.infradead.org, Kevin Tian , Heiko Carstens , Alex Williamson , Megha Dey , Juergen Gross , Thomas Bogendoerfer , Greg Kroah-Hartman , linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [patch 05/22] genirq/msi: Fixup includes In-Reply-To: <87czmhb8gq.ffs@tglx> References: <20211126222700.862407977@linutronix.de> <20211126223824.382273262@linutronix.de> <87tufud4m3.ffs@tglx> <524d9b84-caa8-dd6f-bb5e-9fc906d279c0@kaod.org> <87czmhb8gq.ffs@tglx> Date: Tue, 30 Nov 2021 23:41:28 +0100 Message-ID: <875ys9b71j.ffs@tglx> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211130_144132_143286_A8D8F98B X-CRM114-Status: GOOD ( 10.40 ) X-BeenThere: ath11k@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "ath11k" Errors-To: ath11k-bounces+ath11k=archiver.kernel.org@lists.infradead.org T24gVHVlLCBOb3YgMzAgMjAyMSBhdCAyMzoxMCwgVGhvbWFzIEdsZWl4bmVyIHdyb3RlOgoKPiBP biBUdWUsIE5vdiAzMCAyMDIxIGF0IDIyOjQ4LCBDw6lkcmljIExlIEdvYXRlciB3cm90ZToKPj4g T24gMTEvMjkvMjEgMjI6MzgsIFRob21hcyBHbGVpeG5lciB3cm90ZToKPj4+IE9uIE1vbiwgTm92 IDI5IDIwMjEgYXQgMDg6MzMsIEPDqWRyaWMgTGUgR29hdGVyIHdyb3RlOgo+Pj4gdGhhbmtzIGZv ciBoYXZpbmcgYSBsb29rLiBJIGZpeGVkIHVwIHRoaXMgYW5kIG90aGVyIGZhbGxvdXQgYW5kIHB1 c2hlZCBvdXQgYW4KPj4+IHVwZGF0ZWQgc2VyaWVzIChhbGwgNCBwYXJ0cykgdG86Cj4+PiAKPj4+ ICAgICAgICAgIGdpdDovL2dpdC5rZXJuZWwub3JnL3B1Yi9zY20vbGludXgva2VybmVsL2dpdC90 Z2x4L2RldmVsIG1zaQo+Pgo+PiBwU2VyaWVzIGZhaWxzIHRvIGFsbG9jYXRlIE1TSXMgc3RhcnRp bmcgd2l0aCB0aGlzIHBhdGNoIDoKPj4KPj4gICBbUEFUQ0ggMDQ5LzEwMV0gcG93ZXJwYy9wc2Vy aWVzL21zaTogTGV0IGNvcmUgY29kZSBjaGVjayBmb3IgY29udGlndW91cyAuLi4KPj4KPj4gSSB3 aWxsIGRpZyBpbiBsYXRlciBvbi4KPgo+IExldCBtZSBzdGFyZSBhdCB0aGUgY29yZSBmdW5jdGlv bi4uCgpJdCdzIG5vdCB0aGUgY29yZSBmdW5jdGlvbi4gSXQncyB0aGUgcGF0Y2ggYWJvdmUgYW5k IEknbSBhIG1vcm9uLgoKLS0tIGEvYXJjaC9wb3dlcnBjL3BsYXRmb3Jtcy9wc2VyaWVzL21zaS5j CisrKyBiL2FyY2gvcG93ZXJwYy9wbGF0Zm9ybXMvcHNlcmllcy9tc2kuYwpAQCAtMzU5LDkgKzM1 OSw2IEBAIHN0YXRpYyBpbnQgcnRhc19wcmVwYXJlX21zaV9pcnFzKHN0cnVjdAogCWlmIChxdW90 YSAmJiBxdW90YSA8IG52ZWMpCiAJCXJldHVybiBxdW90YTsKIAotCWlmICh0eXBlID09IFBDSV9D QVBfSURfTVNJWCkKLQkJcmV0dXJuIC1FSU5WQUw7Ci0KIAkvKgogCSAqIEZpcm13YXJlIGN1cnJl bnRseSByZWZ1c2UgYW55IG5vbiBwb3dlciBvZiB0d28gYWxsb2NhdGlvbgogCSAqIHNvIHdlIHJv dW5kIHVwIGlmIHRoZSBxdW90YSB3aWxsIGFsbG93IGl0LgoKLS0gCmF0aDExayBtYWlsaW5nIGxp c3QKYXRoMTFrQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcv bWFpbG1hbi9saXN0aW5mby9hdGgxMWsK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0AD9C433FE for ; Tue, 30 Nov 2021 22:41:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344845AbhK3WpQ (ORCPT ); Tue, 30 Nov 2021 17:45:16 -0500 Received: from Galois.linutronix.de ([193.142.43.55]:36276 "EHLO galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345079AbhK3Wov (ORCPT ); Tue, 30 Nov 2021 17:44:51 -0500 From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1638312089; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1bOw8HEe7jHxyt1BTzbWx6wvk9iJpbF5Gn0Kg7y1Blo=; b=2IrmNv3Iea3b/0P87xEGqZAZmwL1onSUMGqd0zxtDIRJLTynmNSC7uxIH8L/l5dtLj/5OD JagFWx3aJMiS1LFIeYftEfo0Ur2kNjTtrOTkBnBmsBzvAxM9ucbFfqPVN5bViblbdfTyHh DmsunGG30VGceQJj3KLRF3KIyBTUwjdi6+cIFEZFOGwVLxR6/Qv+GDEs3kZsbO3Sb5vEY4 CGDmi02z+2/4fP0CRSLAGmUXhnn/6DLG04oqIJtIelaVlS8RIp1r9e2Sxk09e7hCcOFzEs b9sVLSs/CWxPIfpw834x9ILDVWh3TWdsOj5JuMEeZ6q+sN/NVCvFkfOxPIzp8w== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1638312089; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1bOw8HEe7jHxyt1BTzbWx6wvk9iJpbF5Gn0Kg7y1Blo=; b=wP+0RlPVEZMaKpggmpseYFDjn/awmzpDeY9BMit0WIgaUAvSVTefpWgNK6fro3P2SJv3Ar 0+sa+FEk57SExTAA== To: =?utf-8?Q?C=C3=A9dric?= Le Goater , LKML Cc: linux-hyperv@vger.kernel.org, Paul Mackerras , sparclinux@vger.kernel.org, Wei Liu , Ashok Raj , Marc Zygnier , x86@kernel.org, Christian Borntraeger , Bjorn Helgaas , Jason Gunthorpe , linux-pci@vger.kernel.org, xen-devel@lists.xenproject.org, ath11k@lists.infradead.org, Kevin Tian , Heiko Carstens , Alex Williamson , Megha Dey , Juergen Gross , Thomas Bogendoerfer , Greg Kroah-Hartman , linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [patch 05/22] genirq/msi: Fixup includes In-Reply-To: <87czmhb8gq.ffs@tglx> References: <20211126222700.862407977@linutronix.de> <20211126223824.382273262@linutronix.de> <87tufud4m3.ffs@tglx> <524d9b84-caa8-dd6f-bb5e-9fc906d279c0@kaod.org> <87czmhb8gq.ffs@tglx> Date: Tue, 30 Nov 2021 23:41:28 +0100 Message-ID: <875ys9b71j.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-hyperv@vger.kernel.org On Tue, Nov 30 2021 at 23:10, Thomas Gleixner wrote: > On Tue, Nov 30 2021 at 22:48, C=C3=A9dric Le Goater wrote: >> On 11/29/21 22:38, Thomas Gleixner wrote: >>> On Mon, Nov 29 2021 at 08:33, C=C3=A9dric Le Goater wrote: >>> thanks for having a look. I fixed up this and other fallout and pushed = out an >>> updated series (all 4 parts) to: >>>=20 >>> git://git.kernel.org/pub/scm/linux/kernel/git/tglx/devel msi >> >> pSeries fails to allocate MSIs starting with this patch : >> >> [PATCH 049/101] powerpc/pseries/msi: Let core code check for contiguou= s ... >> >> I will dig in later on. > > Let me stare at the core function.. It's not the core function. It's the patch above and I'm a moron. --- a/arch/powerpc/platforms/pseries/msi.c +++ b/arch/powerpc/platforms/pseries/msi.c @@ -359,9 +359,6 @@ static int rtas_prepare_msi_irqs(struct if (quota && quota < nvec) return quota; =20 - if (type =3D=3D PCI_CAP_ID_MSIX) - return -EINVAL; - /* * Firmware currently refuse any non power of two allocation * so we round up if the quota will allow it. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5B9F1C433EF for ; Tue, 30 Nov 2021 22:42:12 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4J3cfV58Ynz3cQj for ; Wed, 1 Dec 2021 09:42:10 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=linutronix.de header.i=@linutronix.de header.a=rsa-sha256 header.s=2020 header.b=2IrmNv3I; dkim=fail reason="signature verification failed" header.d=linutronix.de header.i=@linutronix.de header.a=ed25519-sha256 header.s=2020e header.b=wP+0RlPV; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linutronix.de (client-ip=2a0a:51c0:0:12e:550::1; helo=galois.linutronix.de; envelope-from=tglx@linutronix.de; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=linutronix.de header.i=@linutronix.de header.a=rsa-sha256 header.s=2020 header.b=2IrmNv3I; dkim=pass header.d=linutronix.de header.i=@linutronix.de header.a=ed25519-sha256 header.s=2020e header.b=wP+0RlPV; dkim-atps=neutral Received: from galois.linutronix.de (unknown [IPv6:2a0a:51c0:0:12e:550::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4J3cdm54Wnz2ybD for ; Wed, 1 Dec 2021 09:41:32 +1100 (AEDT) From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1638312089; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1bOw8HEe7jHxyt1BTzbWx6wvk9iJpbF5Gn0Kg7y1Blo=; b=2IrmNv3Iea3b/0P87xEGqZAZmwL1onSUMGqd0zxtDIRJLTynmNSC7uxIH8L/l5dtLj/5OD JagFWx3aJMiS1LFIeYftEfo0Ur2kNjTtrOTkBnBmsBzvAxM9ucbFfqPVN5bViblbdfTyHh DmsunGG30VGceQJj3KLRF3KIyBTUwjdi6+cIFEZFOGwVLxR6/Qv+GDEs3kZsbO3Sb5vEY4 CGDmi02z+2/4fP0CRSLAGmUXhnn/6DLG04oqIJtIelaVlS8RIp1r9e2Sxk09e7hCcOFzEs b9sVLSs/CWxPIfpw834x9ILDVWh3TWdsOj5JuMEeZ6q+sN/NVCvFkfOxPIzp8w== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1638312089; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1bOw8HEe7jHxyt1BTzbWx6wvk9iJpbF5Gn0Kg7y1Blo=; b=wP+0RlPVEZMaKpggmpseYFDjn/awmzpDeY9BMit0WIgaUAvSVTefpWgNK6fro3P2SJv3Ar 0+sa+FEk57SExTAA== To: =?utf-8?Q?C=C3=A9dric?= Le Goater , LKML Subject: Re: [patch 05/22] genirq/msi: Fixup includes In-Reply-To: <87czmhb8gq.ffs@tglx> References: <20211126222700.862407977@linutronix.de> <20211126223824.382273262@linutronix.de> <87tufud4m3.ffs@tglx> <524d9b84-caa8-dd6f-bb5e-9fc906d279c0@kaod.org> <87czmhb8gq.ffs@tglx> Date: Tue, 30 Nov 2021 23:41:28 +0100 Message-ID: <875ys9b71j.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-hyperv@vger.kernel.org, linux-pci@vger.kernel.org, Paul Mackerras , sparclinux@vger.kernel.org, Wei Liu , Ashok Raj , Marc Zygnier , x86@kernel.org, Christian Borntraeger , Bjorn Helgaas , Jason Gunthorpe , xen-devel@lists.xenproject.org, ath11k@lists.infradead.org, Kevin Tian , Heiko Carstens , Alex Williamson , Megha Dey , Juergen Gross , Thomas Bogendoerfer , Greg Kroah-Hartman , linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Tue, Nov 30 2021 at 23:10, Thomas Gleixner wrote: > On Tue, Nov 30 2021 at 22:48, C=C3=A9dric Le Goater wrote: >> On 11/29/21 22:38, Thomas Gleixner wrote: >>> On Mon, Nov 29 2021 at 08:33, C=C3=A9dric Le Goater wrote: >>> thanks for having a look. I fixed up this and other fallout and pushed = out an >>> updated series (all 4 parts) to: >>>=20 >>> git://git.kernel.org/pub/scm/linux/kernel/git/tglx/devel msi >> >> pSeries fails to allocate MSIs starting with this patch : >> >> [PATCH 049/101] powerpc/pseries/msi: Let core code check for contiguou= s ... >> >> I will dig in later on. > > Let me stare at the core function.. It's not the core function. It's the patch above and I'm a moron. --- a/arch/powerpc/platforms/pseries/msi.c +++ b/arch/powerpc/platforms/pseries/msi.c @@ -359,9 +359,6 @@ static int rtas_prepare_msi_irqs(struct if (quota && quota < nvec) return quota; =20 - if (type =3D=3D PCI_CAP_ID_MSIX) - return -EINVAL; - /* * Firmware currently refuse any non power of two allocation * so we round up if the quota will allow it.