From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:ac2:5f6a:0:0:0:0:0 with SMTP id c10csp2767160lfc; Wed, 13 Oct 2021 03:29:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzC7go1v4Ccley60TdnkpzA7Wyd8xchr8cRnW1oxNuy5P29+hKZZTRkH6lut5i64tA37uwM X-Received: by 2002:a67:df07:: with SMTP id s7mr36934412vsk.42.1634120985327; Wed, 13 Oct 2021 03:29:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634120985; cv=none; d=google.com; s=arc-20160816; b=HZicKbAwc0G/8rGIrDVfSMnbNUTSxv1YcvATzM15/DhIbT7kTYDy8mP4Lo/TeCx1TO YoLzAVMdqBHl6phtbTDHxDcmuRlHm1gSqrWEEX1c9jL8jQUwsgC3A00ii/3QUz0QSmRh h5KR7DkmT0bu3lqsvxF96dKsNru8KbfsdDDad15i1eVU0hpeyCBw743yI6ADnlSEAcvT Gnc+eYrGBMLQrOAf4SkZOWfnQ4XM8QAHZNOxyBms8ONRIjlDcqJhn8h8O+BD8QT5HjX8 Epg1weo9P0UIrtlWxZGxYEATXWxF9u3C34ximsOIONnoC5GXaeqkf4gkSJ3aIYb0bd+d tATw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:mime-version:message-id:date :user-agent:references:organization:in-reply-to:subject:to:from :dkim-signature; bh=Cc9Yr6Ivo5YgbZym8EPisfM2zuvkGCC6lw8x1GY5CmU=; b=v5eJhAmF35EkmKDnBlqSFgdYCFAs+Oerwdn548xTgQYFno4XsuQbHFXgoMEwuduMMM k6vsu0sSYPohZa021lOu0vI8Dmr4B1Tl8N32SMCP0i8H1PlOp3L7m60Ky0DEeiMNdXyI kri9MIpTo92Npc0lZMkoh7zImWjR4fmbcipoQaIAZmCpe3gucC1NeJYxKX+pHKlkKc8U 6CzP1ck6d3rk27nr5T66mRmZ2Lgeo8hBJqbmsDNazfen2Bcs+8FlMDoGQdtOaOJN8No/ 8q5NAB4oV0AhC1ti4Q86fc/IO/TcCaesvLHnuk6N3FocswohhtfrtoryhQIgIaD8P1Ec Tq8Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="RwJMMD7/"; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id p18si13391249vsj.329.2021.10.13.03.29.45 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 13 Oct 2021 03:29:45 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="RwJMMD7/"; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1]:39384 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mabW4-0002yi-E0 for alex.bennee@linaro.org; Wed, 13 Oct 2021 06:29:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44654) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mabVk-0002xn-Ax for qemu-arm@nongnu.org; Wed, 13 Oct 2021 06:29:24 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:29606) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mabVg-0005d0-7f for qemu-arm@nongnu.org; Wed, 13 Oct 2021 06:29:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1634120956; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Cc9Yr6Ivo5YgbZym8EPisfM2zuvkGCC6lw8x1GY5CmU=; b=RwJMMD7/L76/g5BjnfhO4yF+QXzJIGRKe9CXmrEw3jPDoOU02smiRHvtgxUGb890Ai5Gqc vuKIVGDstRosYWiWOVEbYVwfeHz4TmTba0+cwebMZzjI6Pk1/KnahUw6n6LXbJdM3aGFw1 3q4rCm7rKUJE+hCCALWrH7LiobQV2w0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-500-m55McQ8DMBmbn9WmtuTzlQ-1; Wed, 13 Oct 2021 06:29:14 -0400 X-MC-Unique: m55McQ8DMBmbn9WmtuTzlQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C1599100CCC0; Wed, 13 Oct 2021 10:29:12 +0000 (UTC) Received: from localhost (unknown [10.39.193.85]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 09BB362A41; Wed, 13 Oct 2021 10:28:46 +0000 (UTC) From: Cornelia Huck To: Eric Auger , eric.auger.pro@gmail.com, eric.auger@redhat.com, qemu-arm@nongnu.org, qemu-devel@nongnu.org, mst@redhat.com, peter.maydell@linaro.org Subject: Re: [PATCH] virtio-iommu: Remove non transitional name In-Reply-To: <20211013095554.758806-1-eric.auger@redhat.com> Organization: Red Hat GmbH References: <20211013095554.758806-1-eric.auger@redhat.com> User-Agent: Notmuch/0.32.1 (https://notmuchmail.org) Date: Wed, 13 Oct 2021 12:28:44 +0200 Message-ID: <875yu1w74z.fsf@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=cohuck@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Received-SPF: pass client-ip=170.10.133.124; envelope-from=cohuck@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.049, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jean-philippe@linaro.org, abologna@redhat.com Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-arm" X-TUID: +ymjPpGR2l8g On Wed, Oct 13 2021, Eric Auger wrote: > Remove non transitional name for virtio iommu. Like other > devices introduced after 1.0 spec, the virtio-iommu does > not need it. > > Signed-off-by: Eric Auger > Reported-by: Andrea Bolognani > --- > hw/virtio/virtio-iommu-pci.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/hw/virtio/virtio-iommu-pci.c b/hw/virtio/virtio-iommu-pci.c > index 770c286be7..86fa4e6c28 100644 > --- a/hw/virtio/virtio-iommu-pci.c > +++ b/hw/virtio/virtio-iommu-pci.c > @@ -100,7 +100,6 @@ static void virtio_iommu_pci_instance_init(Object *obj) > static const VirtioPCIDeviceTypeInfo virtio_iommu_pci_info = { > .base_name = TYPE_VIRTIO_IOMMU_PCI, > .generic_name = "virtio-iommu-pci", > - .non_transitional_name = "virtio-iommu-pci-non-transitional", > .instance_size = sizeof(VirtIOIOMMUPCI), > .instance_init = virtio_iommu_pci_instance_init, > .class_init = virtio_iommu_pci_class_init, No objections, but I'm a bit confused regarding base_name and generic_name here. Can you drop base_name, re-define TYPE_VIRTIO_IOMMU_PCI to "virtio-iommu-pci", and switch generic_name over to it? I think that would be more in line with other modern-only devices. AFAICS, the places using the #define should continue to work.