From: Jani Nikula <jani.nikula@linux.intel.com>
To: Kai Vehmanen <kai.vehmanen@linux.intel.com>,
Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc: joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com,
"David Airlie" <airlied@linux.ie>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
"Lucas De Marchi" <lucas.demarchi@intel.com>,
"Imre Deak" <imre.deak@intel.com>,
"Uma Shankar" <uma.shankar@intel.com>,
"Matt Roper" <matthew.d.roper@intel.com>,
"Kai Vehmanen" <kai.vehmanen@linux.intel.com>,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915/audio: Use BIOS provided value for RKL HDA link
Date: Mon, 27 Sep 2021 14:44:59 +0300 [thread overview]
Message-ID: <875yums0n8.fsf@intel.com> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2109061031450.3554566@eliteleevi.tm.intel.com>
On Mon, 06 Sep 2021, Kai Vehmanen <kai.vehmanen@linux.intel.com> wrote:
> Hi,
>
> On Mon, 6 Sep 2021, Kai-Heng Feng wrote:
>
>> Commit 989634fb49ad ("drm/i915/audio: set HDA link parameters in
>> driver") makes HDMI audio on Lenovo P350 disappear.
>>
>> So in addition to TGL, extend the logic to RKL to use BIOS provided
>> value to fix the regression.
>
> thanks Kai-Heng! We were not aware of commercial RKL systems following the
> old BIOS guidance, but given you just hit one, then this definitely is
> needed:
>
> Reviewed-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
This had fallen between the cracks, pushed now. Thanks for the patch and
review.
BR,
Jani.
>
> Br, Kai
--
Jani Nikula, Intel Open Source Graphics Center
WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Kai Vehmanen <kai.vehmanen@linux.intel.com>,
Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc: joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com,
"David Airlie" <airlied@linux.ie>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
"Lucas De Marchi" <lucas.demarchi@intel.com>,
"Imre Deak" <imre.deak@intel.com>,
"Uma Shankar" <uma.shankar@intel.com>,
"Matt Roper" <matthew.d.roper@intel.com>,
"Kai Vehmanen" <kai.vehmanen@linux.intel.com>,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/i915/audio: Use BIOS provided value for RKL HDA link
Date: Mon, 27 Sep 2021 14:44:59 +0300 [thread overview]
Message-ID: <875yums0n8.fsf@intel.com> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2109061031450.3554566@eliteleevi.tm.intel.com>
On Mon, 06 Sep 2021, Kai Vehmanen <kai.vehmanen@linux.intel.com> wrote:
> Hi,
>
> On Mon, 6 Sep 2021, Kai-Heng Feng wrote:
>
>> Commit 989634fb49ad ("drm/i915/audio: set HDA link parameters in
>> driver") makes HDMI audio on Lenovo P350 disappear.
>>
>> So in addition to TGL, extend the logic to RKL to use BIOS provided
>> value to fix the regression.
>
> thanks Kai-Heng! We were not aware of commercial RKL systems following the
> old BIOS guidance, but given you just hit one, then this definitely is
> needed:
>
> Reviewed-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
This had fallen between the cracks, pushed now. Thanks for the patch and
review.
BR,
Jani.
>
> Br, Kai
--
Jani Nikula, Intel Open Source Graphics Center
next prev parent reply other threads:[~2021-09-27 11:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-06 4:12 [Intel-gfx] [PATCH] drm/i915/audio: Use BIOS provided value for RKL HDA link Kai-Heng Feng
2021-09-06 4:12 ` Kai-Heng Feng
2021-09-06 5:23 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2021-09-06 6:53 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2021-09-06 7:32 ` [Intel-gfx] [PATCH] " Kai Vehmanen
2021-09-06 7:32 ` Kai Vehmanen
2021-09-27 11:44 ` Jani Nikula [this message]
2021-09-27 11:44 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875yums0n8.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=joonas.lahtinen@linux.intel.com \
--cc=kai.heng.feng@canonical.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lucas.demarchi@intel.com \
--cc=matthew.d.roper@intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=uma.shankar@intel.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.