All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Bjørn Mork" <bjorn@mork.no>
To: Slark Xiao <slark_xiao@163.com>
Cc: johan@kernel.org, gregkh@linuxfoundation.org,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [v2,1/1] This aims to support Foxconn SDX55
Date: Wed, 11 Aug 2021 14:01:57 +0200	[thread overview]
Message-ID: <875ywcfave.fsf@miraculix.mork.no> (raw)
In-Reply-To: <20210811085635.4699-1-slark_xiao@163.com> (Slark Xiao's message of "Wed, 11 Aug 2021 16:56:35 +0800")

Slark Xiao <slark_xiao@163.com> writes:

> diff --git a/drivers/usb/serial/qcserial.c b/drivers/usb/serial/qcserial.c
> index 83da8236e3c8..d8b58aea3c60 100644
> --- a/drivers/usb/serial/qcserial.c
> +++ b/drivers/usb/serial/qcserial.c
> @@ -111,6 +111,7 @@ static const struct usb_device_id id_table[] = {
>  	{USB_DEVICE(0x16d8, 0x8002)},	/* CMDTech Gobi 2000 Modem device (VU922) */
>  	{USB_DEVICE(0x05c6, 0x9204)},	/* Gobi 2000 QDL device */
>  	{USB_DEVICE(0x05c6, 0x9205)},	/* Gobi 2000 Modem device */
> +	{USB_DEVICE(0x05c6, 0x901d)},	/* Foxconn SDX55 QDL */

I assume this device will expose other serial functions when booted in
application USB mode?  But probably not with a Gobi 2k layout... Maybe
add the application device ID to some USB serial driver too, and include
the QDL device ID there as well to reduce confusion?

Could you provide a view of the default USB descriptors in both QDL and
application mode?  E.g from lsusb -v or  /sys/kernel/debug/usb/devices?


Bjørn


  parent reply	other threads:[~2021-08-11 12:02 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-11  8:56 [PATCH] [v2,1/1] This aims to support Foxconn SDX55 Slark Xiao
2021-08-11 10:58 ` Sergei Shtylyov
2021-08-12  1:46   ` Slark Xiao
     [not found]   ` <4e38db09.53c.17b37e7bc99.Coremail.slark_xiao@163.com>
2021-08-12 10:00     ` Sergei Shtylyov
2021-08-11 11:42 ` Greg KH
2021-08-12  1:52   ` Slark Xiao
2021-08-12  6:46     ` Greg KH
2021-08-12 10:51       ` Slark Xiao
2021-08-11 12:01 ` Bjørn Mork [this message]
2021-08-12  2:07   ` Slark Xiao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875ywcfave.fsf@miraculix.mork.no \
    --to=bjorn@mork.no \
    --cc=gregkh@linuxfoundation.org \
    --cc=johan@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=slark_xiao@163.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.