From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C41BAC433ED for ; Fri, 7 May 2021 16:24:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8E79B61463 for ; Fri, 7 May 2021 16:24:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236723AbhEGQZ3 convert rfc822-to-8bit (ORCPT ); Fri, 7 May 2021 12:25:29 -0400 Received: from mail.kernel.org ([198.145.29.99]:47628 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236719AbhEGQZ2 (ORCPT ); Fri, 7 May 2021 12:25:28 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 275BB6144F; Fri, 7 May 2021 16:24:28 +0000 (UTC) Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1lf3H7-00BUnl-VB; Fri, 07 May 2021 17:24:26 +0100 Date: Fri, 07 May 2021 17:24:25 +0100 Message-ID: <875yzupl52.wl-maz@kernel.org> From: Marc Zyngier To: Pali =?UTF-8?B?Um9ow6Fy?= Cc: Lorenzo Pieralisi , Thomas Petazzoni , Rob Herring , Bjorn Helgaas , Russell King , Marek =?UTF-8?B?QmVow7pu?= , Remi Pommarel , Xogium , Tomasz Maciej Nowak , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 17/42] PCI: aardvark: Fix support for MSI interrupts In-Reply-To: <20210507144420.24aess56cc7ie2x2@pali> References: <20210506153153.30454-1-pali@kernel.org> <20210506153153.30454-18-pali@kernel.org> <87czu2q25h.wl-maz@kernel.org> <20210507144420.24aess56cc7ie2x2@pali> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: pali@kernel.org, lorenzo.pieralisi@arm.com, thomas.petazzoni@bootlin.com, robh@kernel.org, bhelgaas@google.com, rmk+kernel@armlinux.org.uk, kabel@kernel.org, repk@triplefau.lt, contact@xogium.me, tmn505@gmail.com, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Fri, 07 May 2021 15:44:20 +0100, Pali Rohár wrote: > > On Friday 07 May 2021 11:16:58 Marc Zyngier wrote: > > On Thu, 06 May 2021 16:31:28 +0100, > > Pali Rohár wrote: > > > > > > MSI domain callback .alloc (implemented by advk_msi_irq_domain_alloc() > > > function) should return zero on success. Returning non-zero value indicates > > > failure. Fix return value of this function as in many cases it now returns > > > failure while allocating IRQs. > > > > > > Aardvark hardware supports Multi-MSI and MSI_FLAG_MULTI_PCI_MSI is already > > > set. But when allocating MSI interrupt numbers for Multi-MSI, they need to > > > be properly aligned, otherwise endpoint devices send MSI interrupt with > > > incorrect numbers. Fix this issue by using function bitmap_find_free_region() > > > instead of bitmap_find_next_zero_area(). > > > > > > To ensure that aligned MSI interrupt numbers are used by endpoint devices, > > > we cannot use Linux virtual irq numbers (as they are random and not > > > properly aligned). So use hwirq numbers allocated by the function > > > bitmap_find_free_region(), which are aligned. This needs an update in > > > advk_msi_irq_compose_msi_msg() and advk_pcie_handle_msi() functions to do > > > proper mapping between Linux virtual irq numbers and hwirq MSI inner domain > > > numbers. > > > > > > Also the whole 16-bit MSI number is stored in the PCIE_MSI_PAYLOAD_REG > > > register, not only lower 8 bits. Fix reading content of this register. > > > > > > This change fixes receiving MSI interrupts on Armada 3720 boards and allows > > > using NVMe disks which use Multi-MSI feature with 3 interrupts. > > > > > > Without this change, NVMe disks just freeze booting Linux on Armada 3720 > > > boards as linux nvme-core.c driver is waiting 60s for an interrupt. > > > > > > Signed-off-by: Pali Rohár > > > Reviewed-by: Marek Behún > > > Cc: stable@vger.kernel.org # f21a8b1b6837 ("PCI: aardvark: Move to MSI handling using generic MSI support") > > > --- > > > drivers/pci/controller/pci-aardvark.c | 32 ++++++++++++++++----------- > > > 1 file changed, 19 insertions(+), 13 deletions(-) > > > > > > diff --git a/drivers/pci/controller/pci-aardvark.c b/drivers/pci/controller/pci-aardvark.c > > > index 366d7480bc1b..498810c00b6d 100644 > > > --- a/drivers/pci/controller/pci-aardvark.c > > > +++ b/drivers/pci/controller/pci-aardvark.c > > > @@ -118,6 +118,7 @@ > > > #define PCIE_MSI_STATUS_REG (CONTROL_BASE_ADDR + 0x58) > > > #define PCIE_MSI_MASK_REG (CONTROL_BASE_ADDR + 0x5C) > > > #define PCIE_MSI_PAYLOAD_REG (CONTROL_BASE_ADDR + 0x9C) > > > +#define PCIE_MSI_DATA_MASK GENMASK(15, 0) > > > > See my comment below about this addition. > > > > > /* LMI registers base address and register offsets */ > > > #define LMI_BASE_ADDR 0x6000 > > > @@ -861,7 +862,7 @@ static void advk_msi_irq_compose_msi_msg(struct irq_data *data, > > > > > > msg->address_lo = lower_32_bits(msi_msg); > > > msg->address_hi = upper_32_bits(msi_msg); > > > - msg->data = data->irq; > > > + msg->data = data->hwirq; > > > } > > > > > > static int advk_msi_set_affinity(struct irq_data *irq_data, > > > @@ -878,15 +879,11 @@ static int advk_msi_irq_domain_alloc(struct irq_domain *domain, > > > int hwirq, i; > > > > > > mutex_lock(&pcie->msi_used_lock); > > > - hwirq = bitmap_find_next_zero_area(pcie->msi_used, MSI_IRQ_NUM, > > > - 0, nr_irqs, 0); > > > - if (hwirq >= MSI_IRQ_NUM) { > > > - mutex_unlock(&pcie->msi_used_lock); > > > - return -ENOSPC; > > > - } > > > - > > > - bitmap_set(pcie->msi_used, hwirq, nr_irqs); > > > + hwirq = bitmap_find_free_region(pcie->msi_used, MSI_IRQ_NUM, > > > + order_base_2(nr_irqs)); > > > mutex_unlock(&pcie->msi_used_lock); > > > + if (hwirq < 0) > > > + return -ENOSPC; > > > > > > for (i = 0; i < nr_irqs; i++) > > > irq_domain_set_info(domain, virq + i, hwirq + i, > > > @@ -894,7 +891,7 @@ static int advk_msi_irq_domain_alloc(struct irq_domain *domain, > > > domain->host_data, handle_simple_irq, > > > NULL, NULL); > > > > > > - return hwirq; > > > + return 0; > > > } > > > > > > static void advk_msi_irq_domain_free(struct irq_domain *domain, > > > @@ -904,7 +901,7 @@ static void advk_msi_irq_domain_free(struct irq_domain *domain, > > > struct advk_pcie *pcie = domain->host_data; > > > > > > mutex_lock(&pcie->msi_used_lock); > > > - bitmap_clear(pcie->msi_used, d->hwirq, nr_irqs); > > > + bitmap_release_region(pcie->msi_used, d->hwirq, order_base_2(nr_irqs)); > > > mutex_unlock(&pcie->msi_used_lock); > > > } > > > > > > @@ -1048,6 +1045,7 @@ static void advk_pcie_handle_msi(struct advk_pcie *pcie) > > > { > > > u32 msi_val, msi_mask, msi_status, msi_idx; > > > u16 msi_data; > > > + int virq; > > > > > > msi_mask = advk_readl(pcie, PCIE_MSI_MASK_REG); > > > msi_val = advk_readl(pcie, PCIE_MSI_STATUS_REG); > > > @@ -1057,9 +1055,17 @@ static void advk_pcie_handle_msi(struct advk_pcie *pcie) > > > if (!(BIT(msi_idx) & msi_status)) > > > continue; > > > > > > + /* > > > + * msi_idx contains bits [4:0] of the msi_data and msi_data > > > + * contains 16bit MSI interrupt number from MSI inner domain > > > + */ > > > advk_writel(pcie, BIT(msi_idx), PCIE_MSI_STATUS_REG); > > > - msi_data = advk_readl(pcie, PCIE_MSI_PAYLOAD_REG) & 0xFF; > > > - generic_handle_irq(msi_data); > > > + msi_data = advk_readl(pcie, PCIE_MSI_PAYLOAD_REG) & PCIE_MSI_DATA_MASK; > > > > Can this be moved to a separate patch? It seems like this patch should > > only focus on correctly dealing with the irq/hwirq issues. > > Well, hwirq is read from PCIE_MSI_PAYLOAD_REG register and it is 16-bit. > That is why I included this change in this patch, to fix also reading > IRQ number, not only setting IRQ number. But this irq number still is a 5 bit quantity at this stage, and the support for more than 32 MSIs only come in 3 patches later. So this doesn't fix anything in this patch, and should be moved to patch 20. Thanks, M. -- Without deviation from the norm, progress is not possible. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19ED2C433ED for ; Fri, 7 May 2021 16:26:23 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6E2BD6144F for ; Fri, 7 May 2021 16:26:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6E2BD6144F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Subject:Cc:To: From:Message-ID:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=x2MvmuE7vEnXgVzqaSm/g8CR8sXKPp1pjkPX3oUpmKU=; b=dKA4S567zK1Krc5EvbQXOA6UB OInzNAfLBiKkS5W2MCMDC+Kt0ojpHKxifOdNKmmrdd0JqFRj/hlL8tlS3A0o0vseyBjcGaNczvWtZ aHONDbo5KrHQqpuC6Qj15vufAw0TJCvSnBJGj6Vfeg/9cqtJfh099tDfp4og0A5KKAQETWLXDcce8 8l20EFQ4bxA3fGuByk4IdXks0lWd0/zeQjjY9UCnDtZc4dhjRVjfk/OVtSFG8BvhLfACvr78L8AER Zp1mo91ublpQ85JMASf2B1bLGHztC0VzTBlprf41n1ti54QNYEGLZqwldR/ZmER4gySv/V92oJA1n uZtvezqsA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lf3HG-007XZD-EG; Fri, 07 May 2021 16:24:35 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lf3HD-007XYD-Px for linux-arm-kernel@desiato.infradead.org; Fri, 07 May 2021 16:24:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Subject:Cc:To:From: Message-ID:Date:Sender:Reply-To:Content-ID:Content-Description; bh=zux2xuGKXxgbXq/csOHXmER/Hxb3U+FcZ9JwpnbjgWQ=; b=UOzGiCqvyhULHnZEUJYJ/uFLM3 00YfQRRzbhETK64sj2CLKLfvTESlyvzLKfNCNTpYOzcBDEVNOwWv/gKpHCXIvDrVj6tP+sFfe2amr cIY9NmwPuesFRKc1zByZHMMJSxk+X8tHcNqB/u4mD2hQ0bwiAu8nKeIWm/K2vvAC5GxdR+h0BoDyV 7VW4MrMLH4Ev0UAsnngnWKZCSvSo+aaDlGZdUrcTt1s5HvHQsWT4QCzWpAbPUBbrHeZVZmgrOnwSw 8kNswgmv1/OcLk33+nImrmpPDbDoQkMx2admSpRFKpxw/6s4z1UyVZmWWC1HV4w1KDMt9hw8ZJ1Jr ZOuxjnSA==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lf3HA-00704Z-Qp for linux-arm-kernel@lists.infradead.org; Fri, 07 May 2021 16:24:30 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 275BB6144F; Fri, 7 May 2021 16:24:28 +0000 (UTC) Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1lf3H7-00BUnl-VB; Fri, 07 May 2021 17:24:26 +0100 Date: Fri, 07 May 2021 17:24:25 +0100 Message-ID: <875yzupl52.wl-maz@kernel.org> From: Marc Zyngier To: Pali =?UTF-8?B?Um9ow6Fy?= Cc: Lorenzo Pieralisi , Thomas Petazzoni , Rob Herring , Bjorn Helgaas , Russell King , Marek =?UTF-8?B?QmVow7pu?= , Remi Pommarel , Xogium , Tomasz Maciej Nowak , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 17/42] PCI: aardvark: Fix support for MSI interrupts In-Reply-To: <20210507144420.24aess56cc7ie2x2@pali> References: <20210506153153.30454-1-pali@kernel.org> <20210506153153.30454-18-pali@kernel.org> <87czu2q25h.wl-maz@kernel.org> <20210507144420.24aess56cc7ie2x2@pali> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: pali@kernel.org, lorenzo.pieralisi@arm.com, thomas.petazzoni@bootlin.com, robh@kernel.org, bhelgaas@google.com, rmk+kernel@armlinux.org.uk, kabel@kernel.org, repk@triplefau.lt, contact@xogium.me, tmn505@gmail.com, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210507_092428_969361_2CDAD0FE X-CRM114-Status: GOOD ( 45.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCAwNyBNYXkgMjAyMSAxNTo0NDoyMCArMDEwMCwKUGFsaSBSb2jDoXIgPHBhbGlAa2Vy bmVsLm9yZz4gd3JvdGU6Cj4gCj4gT24gRnJpZGF5IDA3IE1heSAyMDIxIDExOjE2OjU4IE1hcmMg WnluZ2llciB3cm90ZToKPiA+IE9uIFRodSwgMDYgTWF5IDIwMjEgMTY6MzE6MjggKzAxMDAsCj4g PiBQYWxpIFJvaMOhciA8cGFsaUBrZXJuZWwub3JnPiB3cm90ZToKPiA+ID4gCj4gPiA+IE1TSSBk b21haW4gY2FsbGJhY2sgLmFsbG9jIChpbXBsZW1lbnRlZCBieSBhZHZrX21zaV9pcnFfZG9tYWlu X2FsbG9jKCkKPiA+ID4gZnVuY3Rpb24pIHNob3VsZCByZXR1cm4gemVybyBvbiBzdWNjZXNzLiBS ZXR1cm5pbmcgbm9uLXplcm8gdmFsdWUgaW5kaWNhdGVzCj4gPiA+IGZhaWx1cmUuIEZpeCByZXR1 cm4gdmFsdWUgb2YgdGhpcyBmdW5jdGlvbiBhcyBpbiBtYW55IGNhc2VzIGl0IG5vdyByZXR1cm5z Cj4gPiA+IGZhaWx1cmUgd2hpbGUgYWxsb2NhdGluZyBJUlFzLgo+ID4gPiAKPiA+ID4gQWFyZHZh cmsgaGFyZHdhcmUgc3VwcG9ydHMgTXVsdGktTVNJIGFuZCBNU0lfRkxBR19NVUxUSV9QQ0lfTVNJ IGlzIGFscmVhZHkKPiA+ID4gc2V0LiBCdXQgd2hlbiBhbGxvY2F0aW5nIE1TSSBpbnRlcnJ1cHQg bnVtYmVycyBmb3IgTXVsdGktTVNJLCB0aGV5IG5lZWQgdG8KPiA+ID4gYmUgcHJvcGVybHkgYWxp Z25lZCwgb3RoZXJ3aXNlIGVuZHBvaW50IGRldmljZXMgc2VuZCBNU0kgaW50ZXJydXB0IHdpdGgK PiA+ID4gaW5jb3JyZWN0IG51bWJlcnMuIEZpeCB0aGlzIGlzc3VlIGJ5IHVzaW5nIGZ1bmN0aW9u IGJpdG1hcF9maW5kX2ZyZWVfcmVnaW9uKCkKPiA+ID4gaW5zdGVhZCBvZiBiaXRtYXBfZmluZF9u ZXh0X3plcm9fYXJlYSgpLgo+ID4gPiAKPiA+ID4gVG8gZW5zdXJlIHRoYXQgYWxpZ25lZCBNU0kg aW50ZXJydXB0IG51bWJlcnMgYXJlIHVzZWQgYnkgZW5kcG9pbnQgZGV2aWNlcywKPiA+ID4gd2Ug Y2Fubm90IHVzZSBMaW51eCB2aXJ0dWFsIGlycSBudW1iZXJzIChhcyB0aGV5IGFyZSByYW5kb20g YW5kIG5vdAo+ID4gPiBwcm9wZXJseSBhbGlnbmVkKS4gU28gdXNlIGh3aXJxIG51bWJlcnMgYWxs b2NhdGVkIGJ5IHRoZSBmdW5jdGlvbgo+ID4gPiBiaXRtYXBfZmluZF9mcmVlX3JlZ2lvbigpLCB3 aGljaCBhcmUgYWxpZ25lZC4gVGhpcyBuZWVkcyBhbiB1cGRhdGUgaW4KPiA+ID4gYWR2a19tc2lf aXJxX2NvbXBvc2VfbXNpX21zZygpIGFuZCBhZHZrX3BjaWVfaGFuZGxlX21zaSgpIGZ1bmN0aW9u cyB0byBkbwo+ID4gPiBwcm9wZXIgbWFwcGluZyBiZXR3ZWVuIExpbnV4IHZpcnR1YWwgaXJxIG51 bWJlcnMgYW5kIGh3aXJxIE1TSSBpbm5lciBkb21haW4KPiA+ID4gbnVtYmVycy4KPiA+ID4gCj4g PiA+IEFsc28gdGhlIHdob2xlIDE2LWJpdCBNU0kgbnVtYmVyIGlzIHN0b3JlZCBpbiB0aGUgUENJ RV9NU0lfUEFZTE9BRF9SRUcKPiA+ID4gcmVnaXN0ZXIsIG5vdCBvbmx5IGxvd2VyIDggYml0cy4g Rml4IHJlYWRpbmcgY29udGVudCBvZiB0aGlzIHJlZ2lzdGVyLgo+ID4gPiAKPiA+ID4gVGhpcyBj aGFuZ2UgZml4ZXMgcmVjZWl2aW5nIE1TSSBpbnRlcnJ1cHRzIG9uIEFybWFkYSAzNzIwIGJvYXJk cyBhbmQgYWxsb3dzCj4gPiA+IHVzaW5nIE5WTWUgZGlza3Mgd2hpY2ggdXNlIE11bHRpLU1TSSBm ZWF0dXJlIHdpdGggMyBpbnRlcnJ1cHRzLgo+ID4gPiAKPiA+ID4gV2l0aG91dCB0aGlzIGNoYW5n ZSwgTlZNZSBkaXNrcyBqdXN0IGZyZWV6ZSBib290aW5nIExpbnV4IG9uIEFybWFkYSAzNzIwCj4g PiA+IGJvYXJkcyBhcyBsaW51eCBudm1lLWNvcmUuYyBkcml2ZXIgaXMgd2FpdGluZyA2MHMgZm9y IGFuIGludGVycnVwdC4KPiA+ID4gCj4gPiA+IFNpZ25lZC1vZmYtYnk6IFBhbGkgUm9ow6FyIDxw YWxpQGtlcm5lbC5vcmc+Cj4gPiA+IFJldmlld2VkLWJ5OiBNYXJlayBCZWjDum4gPGthYmVsQGtl cm5lbC5vcmc+Cj4gPiA+IENjOiBzdGFibGVAdmdlci5rZXJuZWwub3JnICMgZjIxYThiMWI2ODM3 ICgiUENJOiBhYXJkdmFyazogTW92ZSB0byBNU0kgaGFuZGxpbmcgdXNpbmcgZ2VuZXJpYyBNU0kg c3VwcG9ydCIpCj4gPiA+IC0tLQo+ID4gPiAgZHJpdmVycy9wY2kvY29udHJvbGxlci9wY2ktYWFy ZHZhcmsuYyB8IDMyICsrKysrKysrKysrKysrKystLS0tLS0tLS0tLQo+ID4gPiAgMSBmaWxlIGNo YW5nZWQsIDE5IGluc2VydGlvbnMoKyksIDEzIGRlbGV0aW9ucygtKQo+ID4gPiAKPiA+ID4gZGlm ZiAtLWdpdCBhL2RyaXZlcnMvcGNpL2NvbnRyb2xsZXIvcGNpLWFhcmR2YXJrLmMgYi9kcml2ZXJz L3BjaS9jb250cm9sbGVyL3BjaS1hYXJkdmFyay5jCj4gPiA+IGluZGV4IDM2NmQ3NDgwYmMxYi4u NDk4ODEwYzAwYjZkIDEwMDY0NAo+ID4gPiAtLS0gYS9kcml2ZXJzL3BjaS9jb250cm9sbGVyL3Bj aS1hYXJkdmFyay5jCj4gPiA+ICsrKyBiL2RyaXZlcnMvcGNpL2NvbnRyb2xsZXIvcGNpLWFhcmR2 YXJrLmMKPiA+ID4gQEAgLTExOCw2ICsxMTgsNyBAQAo+ID4gPiAgI2RlZmluZSBQQ0lFX01TSV9T VEFUVVNfUkVHCQkJKENPTlRST0xfQkFTRV9BRERSICsgMHg1OCkKPiA+ID4gICNkZWZpbmUgUENJ RV9NU0lfTUFTS19SRUcJCQkoQ09OVFJPTF9CQVNFX0FERFIgKyAweDVDKQo+ID4gPiAgI2RlZmlu ZSBQQ0lFX01TSV9QQVlMT0FEX1JFRwkJCShDT05UUk9MX0JBU0VfQUREUiArIDB4OUMpCj4gPiA+ ICsjZGVmaW5lICAgICBQQ0lFX01TSV9EQVRBX01BU0sJCQlHRU5NQVNLKDE1LCAwKQo+ID4gCj4g PiBTZWUgbXkgY29tbWVudCBiZWxvdyBhYm91dCB0aGlzIGFkZGl0aW9uLgo+ID4gCj4gPiA+ICAv KiBMTUkgcmVnaXN0ZXJzIGJhc2UgYWRkcmVzcyBhbmQgcmVnaXN0ZXIgb2Zmc2V0cyAqLwo+ID4g PiAgI2RlZmluZSBMTUlfQkFTRV9BRERSCQkJCTB4NjAwMAo+ID4gPiBAQCAtODYxLDcgKzg2Miw3 IEBAIHN0YXRpYyB2b2lkIGFkdmtfbXNpX2lycV9jb21wb3NlX21zaV9tc2coc3RydWN0IGlycV9k YXRhICpkYXRhLAo+ID4gPiAgCj4gPiA+ICAJbXNnLT5hZGRyZXNzX2xvID0gbG93ZXJfMzJfYml0 cyhtc2lfbXNnKTsKPiA+ID4gIAltc2ctPmFkZHJlc3NfaGkgPSB1cHBlcl8zMl9iaXRzKG1zaV9t c2cpOwo+ID4gPiAtCW1zZy0+ZGF0YSA9IGRhdGEtPmlycTsKPiA+ID4gKwltc2ctPmRhdGEgPSBk YXRhLT5od2lycTsKPiA+ID4gIH0KPiA+ID4gIAo+ID4gPiAgc3RhdGljIGludCBhZHZrX21zaV9z ZXRfYWZmaW5pdHkoc3RydWN0IGlycV9kYXRhICppcnFfZGF0YSwKPiA+ID4gQEAgLTg3OCwxNSAr ODc5LDExIEBAIHN0YXRpYyBpbnQgYWR2a19tc2lfaXJxX2RvbWFpbl9hbGxvYyhzdHJ1Y3QgaXJx X2RvbWFpbiAqZG9tYWluLAo+ID4gPiAgCWludCBod2lycSwgaTsKPiA+ID4gIAo+ID4gPiAgCW11 dGV4X2xvY2soJnBjaWUtPm1zaV91c2VkX2xvY2spOwo+ID4gPiAtCWh3aXJxID0gYml0bWFwX2Zp bmRfbmV4dF96ZXJvX2FyZWEocGNpZS0+bXNpX3VzZWQsIE1TSV9JUlFfTlVNLAo+ID4gPiAtCQkJ CQkgICAwLCBucl9pcnFzLCAwKTsKPiA+ID4gLQlpZiAoaHdpcnEgPj0gTVNJX0lSUV9OVU0pIHsK PiA+ID4gLQkJbXV0ZXhfdW5sb2NrKCZwY2llLT5tc2lfdXNlZF9sb2NrKTsKPiA+ID4gLQkJcmV0 dXJuIC1FTk9TUEM7Cj4gPiA+IC0JfQo+ID4gPiAtCj4gPiA+IC0JYml0bWFwX3NldChwY2llLT5t c2lfdXNlZCwgaHdpcnEsIG5yX2lycXMpOwo+ID4gPiArCWh3aXJxID0gYml0bWFwX2ZpbmRfZnJl ZV9yZWdpb24ocGNpZS0+bXNpX3VzZWQsIE1TSV9JUlFfTlVNLAo+ID4gPiArCQkJCQlvcmRlcl9i YXNlXzIobnJfaXJxcykpOwo+ID4gPiAgCW11dGV4X3VubG9jaygmcGNpZS0+bXNpX3VzZWRfbG9j ayk7Cj4gPiA+ICsJaWYgKGh3aXJxIDwgMCkKPiA+ID4gKwkJcmV0dXJuIC1FTk9TUEM7Cj4gPiA+ ICAKPiA+ID4gIAlmb3IgKGkgPSAwOyBpIDwgbnJfaXJxczsgaSsrKQo+ID4gPiAgCQlpcnFfZG9t YWluX3NldF9pbmZvKGRvbWFpbiwgdmlycSArIGksIGh3aXJxICsgaSwKPiA+ID4gQEAgLTg5NCw3 ICs4OTEsNyBAQCBzdGF0aWMgaW50IGFkdmtfbXNpX2lycV9kb21haW5fYWxsb2Moc3RydWN0IGly cV9kb21haW4gKmRvbWFpbiwKPiA+ID4gIAkJCQkgICAgZG9tYWluLT5ob3N0X2RhdGEsIGhhbmRs ZV9zaW1wbGVfaXJxLAo+ID4gPiAgCQkJCSAgICBOVUxMLCBOVUxMKTsKPiA+ID4gIAo+ID4gPiAt CXJldHVybiBod2lycTsKPiA+ID4gKwlyZXR1cm4gMDsKPiA+ID4gIH0KPiA+ID4gIAo+ID4gPiAg c3RhdGljIHZvaWQgYWR2a19tc2lfaXJxX2RvbWFpbl9mcmVlKHN0cnVjdCBpcnFfZG9tYWluICpk b21haW4sCj4gPiA+IEBAIC05MDQsNyArOTAxLDcgQEAgc3RhdGljIHZvaWQgYWR2a19tc2lfaXJx X2RvbWFpbl9mcmVlKHN0cnVjdCBpcnFfZG9tYWluICpkb21haW4sCj4gPiA+ICAJc3RydWN0IGFk dmtfcGNpZSAqcGNpZSA9IGRvbWFpbi0+aG9zdF9kYXRhOwo+ID4gPiAgCj4gPiA+ICAJbXV0ZXhf bG9jaygmcGNpZS0+bXNpX3VzZWRfbG9jayk7Cj4gPiA+IC0JYml0bWFwX2NsZWFyKHBjaWUtPm1z aV91c2VkLCBkLT5od2lycSwgbnJfaXJxcyk7Cj4gPiA+ICsJYml0bWFwX3JlbGVhc2VfcmVnaW9u KHBjaWUtPm1zaV91c2VkLCBkLT5od2lycSwgb3JkZXJfYmFzZV8yKG5yX2lycXMpKTsKPiA+ID4g IAltdXRleF91bmxvY2soJnBjaWUtPm1zaV91c2VkX2xvY2spOwo+ID4gPiAgfQo+ID4gPiAgCj4g PiA+IEBAIC0xMDQ4LDYgKzEwNDUsNyBAQCBzdGF0aWMgdm9pZCBhZHZrX3BjaWVfaGFuZGxlX21z aShzdHJ1Y3QgYWR2a19wY2llICpwY2llKQo+ID4gPiAgewo+ID4gPiAgCXUzMiBtc2lfdmFsLCBt c2lfbWFzaywgbXNpX3N0YXR1cywgbXNpX2lkeDsKPiA+ID4gIAl1MTYgbXNpX2RhdGE7Cj4gPiA+ ICsJaW50IHZpcnE7Cj4gPiA+ICAKPiA+ID4gIAltc2lfbWFzayA9IGFkdmtfcmVhZGwocGNpZSwg UENJRV9NU0lfTUFTS19SRUcpOwo+ID4gPiAgCW1zaV92YWwgPSBhZHZrX3JlYWRsKHBjaWUsIFBD SUVfTVNJX1NUQVRVU19SRUcpOwo+ID4gPiBAQCAtMTA1Nyw5ICsxMDU1LDE3IEBAIHN0YXRpYyB2 b2lkIGFkdmtfcGNpZV9oYW5kbGVfbXNpKHN0cnVjdCBhZHZrX3BjaWUgKnBjaWUpCj4gPiA+ICAJ CWlmICghKEJJVChtc2lfaWR4KSAmIG1zaV9zdGF0dXMpKQo+ID4gPiAgCQkJY29udGludWU7Cj4g PiA+ICAKPiA+ID4gKwkJLyoKPiA+ID4gKwkJICogbXNpX2lkeCBjb250YWlucyBiaXRzIFs0OjBd IG9mIHRoZSBtc2lfZGF0YSBhbmQgbXNpX2RhdGEKPiA+ID4gKwkJICogY29udGFpbnMgMTZiaXQg TVNJIGludGVycnVwdCBudW1iZXIgZnJvbSBNU0kgaW5uZXIgZG9tYWluCj4gPiA+ICsJCSAqLwo+ ID4gPiAgCQlhZHZrX3dyaXRlbChwY2llLCBCSVQobXNpX2lkeCksIFBDSUVfTVNJX1NUQVRVU19S RUcpOwo+ID4gPiAtCQltc2lfZGF0YSA9IGFkdmtfcmVhZGwocGNpZSwgUENJRV9NU0lfUEFZTE9B RF9SRUcpICYgMHhGRjsKPiA+ID4gLQkJZ2VuZXJpY19oYW5kbGVfaXJxKG1zaV9kYXRhKTsKPiA+ ID4gKwkJbXNpX2RhdGEgPSBhZHZrX3JlYWRsKHBjaWUsIFBDSUVfTVNJX1BBWUxPQURfUkVHKSAm IFBDSUVfTVNJX0RBVEFfTUFTSzsKPiA+IAo+ID4gQ2FuIHRoaXMgYmUgbW92ZWQgdG8gYSBzZXBh cmF0ZSBwYXRjaD8gSXQgc2VlbXMgbGlrZSB0aGlzIHBhdGNoIHNob3VsZAo+ID4gb25seSBmb2N1 cyBvbiBjb3JyZWN0bHkgZGVhbGluZyB3aXRoIHRoZSBpcnEvaHdpcnEgaXNzdWVzLgo+IAo+IFdl bGwsIGh3aXJxIGlzIHJlYWQgZnJvbSBQQ0lFX01TSV9QQVlMT0FEX1JFRyByZWdpc3RlciBhbmQg aXQgaXMgMTYtYml0Lgo+IFRoYXQgaXMgd2h5IEkgaW5jbHVkZWQgdGhpcyBjaGFuZ2UgaW4gdGhp cyBwYXRjaCwgdG8gZml4IGFsc28gcmVhZGluZwo+IElSUSBudW1iZXIsIG5vdCBvbmx5IHNldHRp bmcgSVJRIG51bWJlci4KCkJ1dCB0aGlzIGlycSBudW1iZXIgc3RpbGwgaXMgYSA1IGJpdCBxdWFu dGl0eSBhdCB0aGlzIHN0YWdlLCBhbmQgdGhlCnN1cHBvcnQgZm9yIG1vcmUgdGhhbiAzMiBNU0lz IG9ubHkgY29tZSBpbiAzIHBhdGNoZXMgbGF0ZXIuCgpTbyB0aGlzIGRvZXNuJ3QgZml4IGFueXRo aW5nIGluIHRoaXMgcGF0Y2gsIGFuZCBzaG91bGQgYmUgbW92ZWQgdG8KcGF0Y2ggMjAuCgpUaGFu a3MsCgoJTS4KCi0tIApXaXRob3V0IGRldmlhdGlvbiBmcm9tIHRoZSBub3JtLCBwcm9ncmVzcyBp cyBub3QgcG9zc2libGUuCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxp c3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0 aW5mby9saW51eC1hcm0ta2VybmVsCg==