Re: [PATCH v2] arm64: boot: dts: qcom: sm8150: add SPI nodes

[Felipe Balbi <balbi@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1135 bytes --]


Hi,

Konrad Dybcio <konrad.dybcio@somainline.org> writes:
> Hi!
>
>
>> Tested on Microsoft Surface Duo (DTS will be sent after -rc1). 
>
> Cool, along with the Lumias we'll now have all the MSFT arm64 qcom devices supported :)

:)

>> +			qup_spi0_default: qup-spi0-default {
>> +				mux {
>> +					pins = "gpio0", "gpio1", "gpio2", "gpio3";
>> +					function = "qup0";
>> +				};
>> +
>> +				config {
>> +					pins = "gpio0", "gpio1", "gpio2", "gpio3";
>> +					drive-strength = <6>;
>> +					bias-disable;
>> +				};
>> +			};
>> +
>
> This format - while technically still correct - is now considered
> obsolete. Please move the pin definitions into a more concise one,
> like so:
>
>
> qup_spi0_default: qup-spi0-default {
>     pins = "gpio0", "gpio1", "gpio2", "gpio3";
>     function = "qup0";
>     drive-strength = <6>;
>     bias-disable;
> };

aaa, pretty cool. I'll send v3 shortly.

> (hopefully Thunderbird didn't mess up newlines here..)

heh, it did :)

> Overall, the patch - while on the large side - looks correct to
> me. Thanks!

thanks

-- 
balbi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 857 bytes --]