From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D27CC433ED for ; Wed, 31 Mar 2021 13:44:30 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 23BB061A94 for ; Wed, 31 Mar 2021 13:44:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 23BB061A94 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:In-reply-to:Subject:Cc:To:From: Message-ID:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=911q9bLBjV4XlvkIwg3HXDzIZNNNVmAzbRRUb/GqgdM=; b=btf/LzvKA01HB4 jOdIFvw3qIA1DjZHXIKdLGUPu+4SHPac7CNVlWqmO2QloOduaH+sym14429C2eeY3SND41oRP2IC7 Rt5htnRADBG4zG3ezUPnVBBYjlPkkX+crkVvgeZhfpXwt+fzDn26tLHGEZ1LY0AdPGB9QtYnkC2N6 j/NJmCKFuN6MrEcaR/oOGozzYAr7sUkoCaHXX1Pwfo5rwPV/5Bdd0A4CMMS/drjDLr1jb4QhrCnh3 BSdSrRPjTI1QSbje87D/srtDont6sqdZKPt/ZEA1NTCPBZWyVmjvexBeJtr92pmymtOkhzVCRSElS pg7a8JzozzIM3fWp9LOQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lRb7g-006iMl-59; Wed, 31 Mar 2021 13:43:04 +0000 Received: from mail.kernel.org ([198.145.29.99]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lRb7b-006iGv-UI for linux-arm-kernel@lists.infradead.org; Wed, 31 Mar 2021 13:43:01 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E025361994; Wed, 31 Mar 2021 13:42:54 +0000 (UTC) Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1lRb7U-004uXd-TC; Wed, 31 Mar 2021 14:42:53 +0100 Date: Wed, 31 Mar 2021 14:42:52 +0100 Message-ID: <875z17qw0z.wl-maz@kernel.org> From: Marc Zyngier To: Fredrik Strupe Cc: Russell King , Rabin Vincent , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm: uprobes: Don't hook on thumb instructions In-reply-to: <20200518125948.25315-1-fredrik@strupe.net> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: fredrik@strupe.net, linux@armlinux.org.uk, rabin@rab.in, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210331_144300_160085_54932BF5 X-CRM114-Status: GOOD ( 18.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Fredrik, On Mon, 18 May 2020, Fredrik Strupe wrote: > Since uprobes is not supported for thumb, check that the thumb bit is > not set when matching the uprobes instruction hooks. > > The Arm UDF instructions used for uprobes triggering > (UPROBE_SWBP_ARM_INSN and UPROBE_SS_ARM_INSN) coincidentally share the > same encoding as a pair of unallocated 32-bit thumb instructions (not > UDF) when the condition code is 0b1111 (0xf). This in effect makes it > possible to trigger the uprobes functionality from thumb, and at that > using two unallocated instructions which are not permanently > undefined. > > Signed-off-by: Fredrik Strupe Fixes: c7edc9e326d5 ("ARM: add uprobes support") It looks like we dropped the ball on this patch. Could you please add it to Russell's patch system, together with a Cc: stable? Otherwise, just say the word and I'll do it for you. Thanks, M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C41AC433B4 for ; Wed, 31 Mar 2021 13:43:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D89016199A for ; Wed, 31 Mar 2021 13:43:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235808AbhCaNnN (ORCPT ); Wed, 31 Mar 2021 09:43:13 -0400 Received: from mail.kernel.org ([198.145.29.99]:59840 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235879AbhCaNmz (ORCPT ); Wed, 31 Mar 2021 09:42:55 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E025361994; Wed, 31 Mar 2021 13:42:54 +0000 (UTC) Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1lRb7U-004uXd-TC; Wed, 31 Mar 2021 14:42:53 +0100 Date: Wed, 31 Mar 2021 14:42:52 +0100 Message-ID: <875z17qw0z.wl-maz@kernel.org> From: Marc Zyngier To: Fredrik Strupe Cc: Russell King , Rabin Vincent , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm: uprobes: Don't hook on thumb instructions In-reply-to: <20200518125948.25315-1-fredrik@strupe.net> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: fredrik@strupe.net, linux@armlinux.org.uk, rabin@rab.in, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Fredrik, On Mon, 18 May 2020, Fredrik Strupe wrote: > Since uprobes is not supported for thumb, check that the thumb bit is > not set when matching the uprobes instruction hooks. > > The Arm UDF instructions used for uprobes triggering > (UPROBE_SWBP_ARM_INSN and UPROBE_SS_ARM_INSN) coincidentally share the > same encoding as a pair of unallocated 32-bit thumb instructions (not > UDF) when the condition code is 0b1111 (0xf). This in effect makes it > possible to trigger the uprobes functionality from thumb, and at that > using two unallocated instructions which are not permanently > undefined. > > Signed-off-by: Fredrik Strupe Fixes: c7edc9e326d5 ("ARM: add uprobes support") It looks like we dropped the ball on this patch. Could you please add it to Russell's patch system, together with a Cc: stable? Otherwise, just say the word and I'll do it for you. Thanks, M. -- Without deviation from the norm, progress is not possible.