All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Peter Zijlstra <peterz@infradead.org>
Cc: x86@kernel.org, tdevries@suse.de, linux-kernel@vger.kernel.org,
	andrew.cooper3@citrix.com,
	Frederic Weisbecker <fweisbec@gmail.com>
Subject: Re: [PATCH] selftests: breakpoints: Add "WINE" test for x86
Date: Fri, 29 Jan 2021 20:09:47 +0100	[thread overview]
Message-ID: <875z3fd0g4.fsf@nanos.tec.linutronix.de> (raw)
In-Reply-To: <YBPQq6ccKL68aIZg@hirez.programming.kicks-ass.net>

On Fri, Jan 29 2021 at 10:08, Peter Zijlstra wrote:
> On Fri, Jan 29, 2021 at 12:28:41AM +0100, Thomas Gleixner wrote:
>
>> Add a test case which covers this scenario. This is modeled after the
>> WINE testcase, but changes the expect in step #2 to:
>> 
>>    - Expect DR6::BS == 1 and DR6::BR0 == 1 and IP == second instruction
>> 
>> to ensure that the GDB expectations are met as well.
>
>> +	/*
>> +	 * Expect: DR6::BS == 1 DR6::BR0 == 1  IP == instr[1]
>> +	 * Wine does not care about BR0 here but GDB does ...
>> +	 */
>> +	wine_test_step(1, addr, 1, 1, buf);
>
>
> So my v2 patch will fail this, while it will pass the actual gdb
> testcase.
>
> The thing it does is process _data_ breakpoints along with TF, but it
> will exclude instruction breakpoints and TF.
>
> Since the above test is using instruction breakpoints, it will report
> 0x4000 and 0x0001 respectively for two consequtive exceptions.

Yes, I'm a moron....

  parent reply	other threads:[~2021-01-29 19:11 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-28 18:20 [PATCH] x86/debug: 'Fix' ptrace dr6 output Peter Zijlstra
2021-01-28 18:45 ` Andrew Cooper
2021-01-28 20:21 ` Tom de Vries
2021-01-28 21:16 ` [PATCH v2] x86/debug: Fix DR6 handling Peter Zijlstra
2021-01-28 23:28   ` [PATCH] selftests: breakpoints: Add "WINE" test for x86 Thomas Gleixner
     [not found]     ` <YBPQq6ccKL68aIZg@hirez.programming.kicks-ass.net>
2021-01-29 19:09       ` Thomas Gleixner [this message]
     [not found]   ` <20210129154109.GA1391@redhat.com>
2021-01-29 16:27     ` [PATCH v2] x86/debug: Fix DR6 handling Borislav Petkov
     [not found]   ` <20210129144816.GB27841@zn.tnic>
2021-01-29 16:59     ` Tom de Vries

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875z3fd0g4.fsf@nanos.tec.linutronix.de \
    --to=tglx@linutronix.de \
    --cc=andrew.cooper3@citrix.com \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=tdevries@suse.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.