From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 116CBC433DB for ; Thu, 14 Jan 2021 13:24:56 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9514923A05 for ; Thu, 14 Jan 2021 13:24:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9514923A05 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:60124 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l02cQ-0005RK-Aw for qemu-devel@archiver.kernel.org; Thu, 14 Jan 2021 08:24:54 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:46006) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l02My-0007LW-RN for qemu-devel@nongnu.org; Thu, 14 Jan 2021 08:08:56 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:52635) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l02Mx-000205-1O for qemu-devel@nongnu.org; Thu, 14 Jan 2021 08:08:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610629734; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=g03uVKaC28Pp2p0ECGlZjGmkxI04BUtZ0zKQ2A39pH4=; b=dBdZ+NWenVg9PWm5CGTX1Tv3H22saPqFrFqqIuhfIPPZI3zYDuNSF1Ce/+0Kg2T+I512kW P/jT/zOz+3MtWQBKvOW/PuTfVPQFgvYLcje+xfY2s5yCkag5zQvs3WVNA+/vgHQuAauabK tkvNSBdsInD5xZdNyfMXNZqPHOpqb2U= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-28-dy7DISZ_NpOZcU_4PGw1Zw-1; Thu, 14 Jan 2021 08:08:50 -0500 X-MC-Unique: dy7DISZ_NpOZcU_4PGw1Zw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 715DF107ACF7; Thu, 14 Jan 2021 13:08:49 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-112-172.ams2.redhat.com [10.36.112.172]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9145D60C47; Thu, 14 Jan 2021 13:08:34 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 21BB711386A7; Thu, 14 Jan 2021 14:08:33 +0100 (CET) From: Markus Armbruster To: Eric Blake Subject: Re: [PATCH v4 5/5] qapi: More complex uses of QAPI_LIST_APPEND References: <20210113221013.390592-1-eblake@redhat.com> <20210113221013.390592-6-eblake@redhat.com> Date: Thu, 14 Jan 2021 14:08:33 +0100 In-Reply-To: <20210113221013.390592-6-eblake@redhat.com> (Eric Blake's message of "Wed, 13 Jan 2021 16:10:13 -0600") Message-ID: <875z3zbr8u.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=armbru@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Received-SPF: pass client-ip=63.128.21.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.248, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , vsementsov@virtuozzo.com, Eduardo Habkost , "open list:GLUSTER" , "Michael S. Tsirkin" , Michael Roth , Jason Wang , Juan Quintela , qemu-devel@nongnu.org, Max Reitz , "open list:GLUSTER" , Gerd Hoffmann , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Igor Mammedov , "Dr. David Alan Gilbert" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Eric Blake writes: > These cases require a bit more thought to review; in each case, the > code was appending to a list, but not with a FOOList **tail variable. > > Signed-off-by: Eric Blake > Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Markus Armbruster