From: Markus Armbruster <armbru@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: "Kevin Wolf" <kwolf@redhat.com>,
qemu-block@nongnu.org, qemu-devel@nongnu.org,
"Markus Armbruster" <armbru@redhat.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Max Reitz" <mreitz@redhat.com>
Subject: Re: [PATCH v6 1/8] monitor: simplify functions for getting a dup'd fdset entry
Date: Fri, 04 Sep 2020 09:33:15 +0200 [thread overview]
Message-ID: <875z8udmis.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <20200903152210.1917355-2-berrange@redhat.com> ("Daniel P. Berrangé"'s message of "Thu, 3 Sep 2020 16:22:03 +0100")
Daniel P. Berrangé <berrange@redhat.com> writes:
> Currently code has to call monitor_fdset_get_fd, then dup
> the return fd, and then add the duplicate FD back into the
> fdset. This dance is overly verbose for the caller and
> introduces extra failure modes which can be avoided by
> folding all the logic into monitor_fdset_dup_fd_add and
> removing monitor_fdset_get_fd entirely.
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
next prev parent reply other threads:[~2020-09-04 7:33 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-03 15:22 [PATCH v6 0/8] block: improve error reporting for unsupported O_DIRECT Daniel P. Berrangé
2020-09-03 15:22 ` [PATCH v6 1/8] monitor: simplify functions for getting a dup'd fdset entry Daniel P. Berrangé
2020-09-03 16:51 ` Richard Henderson
2020-09-04 7:33 ` Markus Armbruster [this message]
2020-09-03 15:22 ` [PATCH v6 2/8] util: split off a helper for dealing with O_CLOEXEC flag Daniel P. Berrangé
2020-09-03 16:51 ` Richard Henderson
2020-09-03 15:22 ` [PATCH v6 3/8] util: rename qemu_open() to qemu_open_old() Daniel P. Berrangé
2020-09-03 16:51 ` Richard Henderson
2020-09-03 15:22 ` [PATCH v6 4/8] util: refactor qemu_open_old to split off variadic args handling Daniel P. Berrangé
2020-09-03 16:52 ` Richard Henderson
2020-09-03 15:22 ` [PATCH v6 5/8] util: add Error object for qemu_open_internal error reporting Daniel P. Berrangé
2020-09-03 16:53 ` Richard Henderson
2020-09-03 15:22 ` [PATCH v6 6/8] util: introduce qemu_open and qemu_create with " Daniel P. Berrangé
2020-09-03 16:54 ` Richard Henderson
2020-09-03 15:22 ` [PATCH v6 7/8] util: give a specific error message when O_DIRECT doesn't work Daniel P. Berrangé
2020-09-03 16:55 ` Richard Henderson
2020-09-03 15:22 ` [PATCH v6 8/8] block/file: switch to use qemu_open/qemu_create for improved errors Daniel P. Berrangé
2020-09-03 16:56 ` Richard Henderson
2020-09-10 13:07 ` [PATCH v6 0/8] block: improve error reporting for unsupported O_DIRECT Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875z8udmis.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=f4bug@amsat.org \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.