Re: [Linux-kernel-mentees] [PATCH v1 0/2] ipw2x00: use generic power management

From: Kalle Valo <kvalo@codeaurora.org>
To: Vaibhav Gupta <vaibhavgupta40@gmail.com>
Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
	Bjorn Helgaas <helgaas@kernel.org>,
	netdev@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
	Jakub Kicinski <kuba@kernel.org>,
	linux-kernel-mentees@lists.linuxfoundation.org,
	"David S. Miller" <davem@davemloft.net>,
	Stanislav Yakovlev <stas.yakovlev@gmail.com>
Subject: Re: [Linux-kernel-mentees] [PATCH v1 0/2] ipw2x00: use generic power management
Date: Mon, 13 Jul 2020 17:56:36 +0300	[thread overview]
Message-ID: <875zarxy3f.fsf@codeaurora.org> (raw)
In-Reply-To: <CAP+cEONk=XKqw4FWkBgTTaudGewJb832OjHutUpAKYpnY-uJ3A@mail.gmail.com> (Vaibhav Gupta's message of "Mon, 13 Jul 2020 20:15:56 +0530")

Vaibhav Gupta <vaibhavgupta40@gmail.com> writes:

> On Mon, Jul 13, 2020, 8:12 PM Kalle Valo <kvalo@codeaurora.org> wrote:
>
>     Vaibhav Gupta <vaibhavgupta40@gmail.com> writes:
>     
>     > Linux Kernel Mentee: Remove Legacy Power Management.
>     >
>     > The purpose of this patch series is to remove legacy power
>     management callbacks
>     > from amd ethernet drivers.
>     >
>     > The callbacks performing suspend() and resume() operations are
>     still calling
>     > pci_save_state(), pci_set_power_state(), etc. and handling the
>     power management
>     > themselves, which is not recommended.
>     >
>     > The conversion requires the removal of the those function calls
>     and change the
>     > callback definition accordingly and make use of dev_pm_ops
>     structure.
>     >
>     > All patches are compile-tested only.
>     >
>     > Vaibhav Gupta (2):
>     > ipw2100: use generic power management
>     > ipw2200: use generic power management
>     >
>     > drivers/net/wireless/intel/ipw2x00/ipw2100.c | 31
>     +++++---------------
>     > drivers/net/wireless/intel/ipw2x00/ipw2200.c | 30
>     +++++--------------
>     
>     amd ethernet drivers? That must be a copy paste error. But no need
>     to
>     resend because of this.
>     
>
> Yes. I am genuinely sorry for this. My two patch-series had same
> changes, so I copy-pasted the cover letter. Forgot to replace the
> name.

No worries. But PLEASE don't send HTML email, lists filter those out:

Content-Type: text/html; charset="UTF-8"

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees