From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vitaly Kuznetsov Date: Wed, 10 Jun 2020 08:32:55 +0000 Subject: Re: [PATCH] kvm: i8254: remove redundant assignment to pointer s Message-Id: <875zbzb9s8.fsf@vitty.brq.redhat.com> List-Id: References: <20200609233121.1118683-1-colin.king@canonical.com> In-Reply-To: <20200609233121.1118683-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Colin King Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Paolo Bonzini , Sean Christopherson , Wanpeng Li , Jim Mattson , Joerg Roedel , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H . Peter Anvin" , kvm@vger.kernel.org Colin King writes: > From: Colin Ian King > > The pointer s is being assigned a value that is never read, the > assignment is redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King It seems it wasn't used since the very beginning, Fixes: 7837699fa6d7 ("KVM: In kernel PIT model") QEMU code (from where KVM's implementation originates), however, does make use of 's' here as it open codes pit_latch_status(). > --- > arch/x86/kvm/i8254.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/x86/kvm/i8254.c b/arch/x86/kvm/i8254.c > index febca334c320..a6e218c6140d 100644 > --- a/arch/x86/kvm/i8254.c > +++ b/arch/x86/kvm/i8254.c > @@ -462,7 +462,6 @@ static int pit_ioport_write(struct kvm_vcpu *vcpu, > if (channel = 3) { > /* Read-Back Command. */ > for (channel = 0; channel < 3; channel++) { > - s = &pit_state->channels[channel]; > if (val & (2 << channel)) { > if (!(val & 0x20)) > pit_latch_count(pit, channel); Reviewed-by: Vitaly Kuznetsov -- Vitaly From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24742C433DF for ; Wed, 10 Jun 2020 08:33:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E700C2064C for ; Wed, 10 Jun 2020 08:33:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="R3aZvon1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726814AbgFJIdB (ORCPT ); Wed, 10 Jun 2020 04:33:01 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:37463 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726699AbgFJIdB (ORCPT ); Wed, 10 Jun 2020 04:33:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1591777980; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/CzDQqYRGgoycRXVjpGii7I26mAUdaOWbacFoesUyuU=; b=R3aZvon1E294tGk8eeqTC+pM9y2GzzTwdGpgLNxyneB7jWhNJOpEdLBbRCgHxdZ+T00evt AIzT3qXwptekTYx9zWHx3KoL7PmMae4qTTISecX3rwHWTYh8WTDBINo92pqZ/2bHxgu0+S tVu71RztIYpVk96MNWMqPrMF85oWnL8= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-18-UjwqAGtuMJu9atVeqQn3YQ-1; Wed, 10 Jun 2020 04:32:58 -0400 X-MC-Unique: UjwqAGtuMJu9atVeqQn3YQ-1 Received: by mail-ej1-f70.google.com with SMTP id t4so745985ejj.12 for ; Wed, 10 Jun 2020 01:32:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=/CzDQqYRGgoycRXVjpGii7I26mAUdaOWbacFoesUyuU=; b=G/u7O9SzHPfw3e6TVwBc0EsUBINTMOeuwCOC8hdbZu+nybmRxhTIPwY0RzB32fqCNR 47dNyBKqo9xT4MlvnaZyEN4uQVntjVYEn2L8+9YbsmFQhgtAtzh7JhC5MPksiiXGQkVb jKpwa1uHv4f7ONpUYcY2aLm4tyGilLLkv8yzcA8z8s43PSrcs3SyCDc1Th/W1bkkCwgV Q0KTUddB7jsHZKfv4XLNCkp39rDCE6BYXt+3wKnuzFeS+cLars/oVgL1vnQXHdq3F++M 8dQ7VYKZgbW4MPLipAZpHc0UPzNua+hz7zVs3xB+mzcDtw5HLiHBC3xBmePWe6t2OWAa USgA== X-Gm-Message-State: AOAM532igNo05f83Z8GSpgDih18EWieXTjIT5NDwpLo9f+JZH0gMFeQE ICbuPls8+FbQvt2qKJKDBDCOcAJl8RnI//iam8RDfQm+zp0Y9xXUk7ZrvTyz3RBEKBouorXHdUW rRr6fjsmbHvCZ X-Received: by 2002:aa7:c4c7:: with SMTP id p7mr1548530edr.271.1591777977417; Wed, 10 Jun 2020 01:32:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyRDXVgnf8jf3KQtAoZpcPajfcKWk4OSBUiV1BVsb+L5Lx8Bk89ta016RNTLmlCPlXXZtcimg== X-Received: by 2002:aa7:c4c7:: with SMTP id p7mr1548507edr.271.1591777977145; Wed, 10 Jun 2020 01:32:57 -0700 (PDT) Received: from vitty.brq.redhat.com (g-server-2.ign.cz. [91.219.240.2]) by smtp.gmail.com with ESMTPSA id ok21sm14043099ejb.82.2020.06.10.01.32.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jun 2020 01:32:56 -0700 (PDT) From: Vitaly Kuznetsov To: Colin King Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Paolo Bonzini , Sean Christopherson , Wanpeng Li , Jim Mattson , Joerg Roedel , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H . Peter Anvin" , kvm@vger.kernel.org Subject: Re: [PATCH] kvm: i8254: remove redundant assignment to pointer s In-Reply-To: <20200609233121.1118683-1-colin.king@canonical.com> References: <20200609233121.1118683-1-colin.king@canonical.com> Date: Wed, 10 Jun 2020 10:32:55 +0200 Message-ID: <875zbzb9s8.fsf@vitty.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Colin King writes: > From: Colin Ian King > > The pointer s is being assigned a value that is never read, the > assignment is redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King It seems it wasn't used since the very beginning, Fixes: 7837699fa6d7 ("KVM: In kernel PIT model") QEMU code (from where KVM's implementation originates), however, does make use of 's' here as it open codes pit_latch_status(). > --- > arch/x86/kvm/i8254.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/x86/kvm/i8254.c b/arch/x86/kvm/i8254.c > index febca334c320..a6e218c6140d 100644 > --- a/arch/x86/kvm/i8254.c > +++ b/arch/x86/kvm/i8254.c > @@ -462,7 +462,6 @@ static int pit_ioport_write(struct kvm_vcpu *vcpu, > if (channel == 3) { > /* Read-Back Command. */ > for (channel = 0; channel < 3; channel++) { > - s = &pit_state->channels[channel]; > if (val & (2 << channel)) { > if (!(val & 0x20)) > pit_latch_count(pit, channel); Reviewed-by: Vitaly Kuznetsov -- Vitaly