From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AEFFC2BA19 for ; Tue, 14 Apr 2020 14:32:21 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id C3C2820787 for ; Tue, 14 Apr 2020 14:32:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="g32HVsh7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C3C2820787 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 3FF314B206; Tue, 14 Apr 2020 10:32:20 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@redhat.com Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id w5q-hd9RGpFR; Tue, 14 Apr 2020 10:32:19 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 05F2F4B1F6; Tue, 14 Apr 2020 10:32:19 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 88C144B1C3 for ; Tue, 14 Apr 2020 10:26:10 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CkKNNOq-aJ8q for ; Tue, 14 Apr 2020 10:26:09 -0400 (EDT) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 9E7014B12C for ; Tue, 14 Apr 2020 10:26:09 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1586874369; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nQ2s1P43pMD0iJunnsFh4bxmcRIUFZr+i4fF45MPy9Q=; b=g32HVsh7f1jr6gP4jzSly6UWmDJ8TFJrzPemV1PAOvdjmiHOS2A7nXvqcXvnd5t8QNEdVL 0vFFUEQciOXdGSShIjcxU1NTQ//wCHhoudjvOXc+Xi0mYLREQokErmWVfG/boapLxqLBnK TG0I/8n12/LZT6wBKT7Qp5wE2/NBVpM= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-219-Gmay7Yk2PVKlz3iMldr4aQ-1; Tue, 14 Apr 2020 10:26:05 -0400 X-MC-Unique: Gmay7Yk2PVKlz3iMldr4aQ-1 Received: by mail-wr1-f72.google.com with SMTP id s11so3905212wru.6 for ; Tue, 14 Apr 2020 07:26:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=uSEGx3gNn1oGf/i6GkkhJSWUv9DBqbvzJo4hv43gN+I=; b=GZlHhmLkqXOfSByMWTTcHjkbxsn9Jlzatts1MnEjaxdieP+4P+ncLB3jcvnL6DcjCF qJi9eNRQFRSfVPOZwY9KWdyMqZmr6kYcDKg3o+g1ECVjQubeMWi9hrej3VAybc7yMGRF MsKzUcll6vj1Jtb8QWBdmsFmQxFa9JiPv9BL3xsVz7z3OZTyJkDaV2mKRwD75W5J0mdM ftua4EwrqIciYFD+9HFa2KcJeJ7A5oLFd64mpiTWhYYbVbd8HT+yDOaj0DxHtX//d18w 9cuBtPfkoH2SRqY3INcdB0xG5GkMk6LMCI2cusxLnWcyCHP4eUDWyLHy/KfWVup021Op PBrw== X-Gm-Message-State: AGi0PubpHYIMmJPmkGu6E6DjOhlMiLprNTx1KabzFzFB+qJcr43O7ES4 AdbvLJ7ar4imxj82bdeH4ikJ9a/RDOptcXdYTTep5XIzkP1I+zyHCiERGOkrR+7HVDADUtzmI9J 1W0ZCRjRgeL+kiTUXRkQwVcl8 X-Received: by 2002:a1c:4409:: with SMTP id r9mr102737wma.165.1586874363919; Tue, 14 Apr 2020 07:26:03 -0700 (PDT) X-Google-Smtp-Source: APiQypJqgbBq9xhT1LszvRzgjgWUmQyELrXGBlfZ5uFizKdfdTJlTiXTCHR6m1nvQHHbl9Aa0nzYPg== X-Received: by 2002:a1c:4409:: with SMTP id r9mr102702wma.165.1586874363651; Tue, 14 Apr 2020 07:26:03 -0700 (PDT) Received: from vitty.brq.redhat.com (g-server-2.ign.cz. [91.219.240.2]) by smtp.gmail.com with ESMTPSA id v10sm7145993wrq.45.2020.04.14.07.26.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Apr 2020 07:26:03 -0700 (PDT) From: Vitaly Kuznetsov To: Tianjia Zhang Subject: Re: [PATCH] KVM: Optimize kvm_arch_vcpu_ioctl_run function In-Reply-To: <20200413034523.110548-1-tianjia.zhang@linux.alibaba.com> References: <20200413034523.110548-1-tianjia.zhang@linux.alibaba.com> Date: Tue, 14 Apr 2020 16:26:01 +0200 Message-ID: <875ze2ywhy.fsf@vitty.brq.redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Mailman-Approved-At: Tue, 14 Apr 2020 10:32:17 -0400 Cc: wanpengli@tencent.com, kvm@vger.kernel.org, tianjia.zhang@linux.alibaba.com, maz@kernel.org, joro@8bytes.org, x86@kernel.org, linux-kernel@vger.kernel.org, sean.j.christopherson@intel.com, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, pbonzini@redhat.com, tglx@linutronix.de, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, jmattson@google.com X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu Tianjia Zhang writes: > kvm_arch_vcpu_ioctl_run() is only called in the file kvm_main.c, > where vcpu->run is the kvm_run parameter, so it has been replaced. > > Signed-off-by: Tianjia Zhang > --- > arch/x86/kvm/x86.c | 8 ++++---- > virt/kvm/arm/arm.c | 2 +- > 2 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c > index 3bf2ecafd027..70e3f4abbd4d 100644 > --- a/arch/x86/kvm/x86.c > +++ b/arch/x86/kvm/x86.c > @@ -8726,18 +8726,18 @@ int kvm_arch_vcpu_ioctl_run(struct kvm_vcpu *vcpu, struct kvm_run *kvm_run) > r = -EAGAIN; > if (signal_pending(current)) { > r = -EINTR; > - vcpu->run->exit_reason = KVM_EXIT_INTR; > + kvm_run->exit_reason = KVM_EXIT_INTR; I have a more generic question: why do we need to pass 'kvm_run' to kvm_arch_vcpu_ioctl_run() if it can be extracted from 'struct kvm_vcpu'? The only call site looks like virt/kvm/kvm_main.c: r = kvm_arch_vcpu_ioctl_run(vcpu, vcpu->run); > ++vcpu->stat.signal_exits; > } > goto out; > } > > - if (vcpu->run->kvm_valid_regs & ~KVM_SYNC_X86_VALID_FIELDS) { > + if (kvm_run->kvm_valid_regs & ~KVM_SYNC_X86_VALID_FIELDS) { > r = -EINVAL; > goto out; > } > > - if (vcpu->run->kvm_dirty_regs) { > + if (kvm_run->kvm_dirty_regs) { > r = sync_regs(vcpu); > if (r != 0) > goto out; > @@ -8767,7 +8767,7 @@ int kvm_arch_vcpu_ioctl_run(struct kvm_vcpu *vcpu, struct kvm_run *kvm_run) > > out: > kvm_put_guest_fpu(vcpu); > - if (vcpu->run->kvm_valid_regs) > + if (kvm_run->kvm_valid_regs) > store_regs(vcpu); > post_kvm_run_save(vcpu); > kvm_sigset_deactivate(vcpu); > diff --git a/virt/kvm/arm/arm.c b/virt/kvm/arm/arm.c > index 48d0ec44ad77..ab9d7966a4c8 100644 > --- a/virt/kvm/arm/arm.c > +++ b/virt/kvm/arm/arm.c > @@ -659,7 +659,7 @@ int kvm_arch_vcpu_ioctl_run(struct kvm_vcpu *vcpu, struct kvm_run *run) > return ret; > > if (run->exit_reason == KVM_EXIT_MMIO) { > - ret = kvm_handle_mmio_return(vcpu, vcpu->run); > + ret = kvm_handle_mmio_return(vcpu, run); > if (ret) > return ret; > } -- Vitaly _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Vitaly Kuznetsov Subject: Re: [PATCH] KVM: Optimize kvm_arch_vcpu_ioctl_run function In-Reply-To: <20200413034523.110548-1-tianjia.zhang@linux.alibaba.com> References: <20200413034523.110548-1-tianjia.zhang@linux.alibaba.com> Date: Tue, 14 Apr 2020 16:26:01 +0200 Message-ID: <875ze2ywhy.fsf@vitty.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: To: Tianjia Zhang Cc: kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, pbonzini@redhat.com, sean.j.christopherson@intel.com, wanpengli@tencent.com, jmattson@google.com, joro@8bytes.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, x86@kernel.org, hpa@zytor.com, maz@kernel.org, james.morse@arm.com, julien.thierry.kdev@gmail.com, suzuki.poulose@arm.com Tianjia Zhang writes: > kvm_arch_vcpu_ioctl_run() is only called in the file kvm_main.c, > where vcpu->run is the kvm_run parameter, so it has been replaced. > > Signed-off-by: Tianjia Zhang > --- > arch/x86/kvm/x86.c | 8 ++++---- > virt/kvm/arm/arm.c | 2 +- > 2 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c > index 3bf2ecafd027..70e3f4abbd4d 100644 > --- a/arch/x86/kvm/x86.c > +++ b/arch/x86/kvm/x86.c > @@ -8726,18 +8726,18 @@ int kvm_arch_vcpu_ioctl_run(struct kvm_vcpu *vcpu, struct kvm_run *kvm_run) > r = -EAGAIN; > if (signal_pending(current)) { > r = -EINTR; > - vcpu->run->exit_reason = KVM_EXIT_INTR; > + kvm_run->exit_reason = KVM_EXIT_INTR; I have a more generic question: why do we need to pass 'kvm_run' to kvm_arch_vcpu_ioctl_run() if it can be extracted from 'struct kvm_vcpu'? The only call site looks like virt/kvm/kvm_main.c: r = kvm_arch_vcpu_ioctl_run(vcpu, vcpu->run); > ++vcpu->stat.signal_exits; > } > goto out; > } > > - if (vcpu->run->kvm_valid_regs & ~KVM_SYNC_X86_VALID_FIELDS) { > + if (kvm_run->kvm_valid_regs & ~KVM_SYNC_X86_VALID_FIELDS) { > r = -EINVAL; > goto out; > } > > - if (vcpu->run->kvm_dirty_regs) { > + if (kvm_run->kvm_dirty_regs) { > r = sync_regs(vcpu); > if (r != 0) > goto out; > @@ -8767,7 +8767,7 @@ int kvm_arch_vcpu_ioctl_run(struct kvm_vcpu *vcpu, struct kvm_run *kvm_run) > > out: > kvm_put_guest_fpu(vcpu); > - if (vcpu->run->kvm_valid_regs) > + if (kvm_run->kvm_valid_regs) > store_regs(vcpu); > post_kvm_run_save(vcpu); > kvm_sigset_deactivate(vcpu); > diff --git a/virt/kvm/arm/arm.c b/virt/kvm/arm/arm.c > index 48d0ec44ad77..ab9d7966a4c8 100644 > --- a/virt/kvm/arm/arm.c > +++ b/virt/kvm/arm/arm.c > @@ -659,7 +659,7 @@ int kvm_arch_vcpu_ioctl_run(struct kvm_vcpu *vcpu, struct kvm_run *run) > return ret; > > if (run->exit_reason == KVM_EXIT_MMIO) { > - ret = kvm_handle_mmio_return(vcpu, vcpu->run); > + ret = kvm_handle_mmio_return(vcpu, run); > if (ret) > return ret; > } -- Vitaly From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82049C3815B for ; Tue, 14 Apr 2020 14:26:37 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 57AF3206D5 for ; Tue, 14 Apr 2020 14:26:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="dYSulnY2"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="bo9AEOBz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 57AF3206D5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EIIIPS0rzUHZaL01zhABpRxr2V69mTjYkMrR6kC2hc0=; b=dYSulnY251w3vL +o/TTu6AKr/RxA/91OAtQTzelqkjMPMaPK5vOsihfqaquisn4bX15gynGpHlm3loyBSJKQTNnXQxW H6LSTuFoY7t+l8ci6g7W4l3s8SloecAcLHRa8M1sMsnop5CPGFJ7XhxeTv4oxcOr8UB1D7eicPKBX gwkPfp1BRF44ddEdM6PU5/5GHRJ7UefazWAYtWsYqWQ8cZEc56eYSvajm0UaJgAZPxJ25fKija7h7 78ZOQjX+ax0SD1eYlaFOe38BYUeJL37lLIrPObtiEKKtMWtsYbJ70Eswq3MQTsW6cITO6c9O8w4E/ 0E6qUw98Zypd3VNW8veQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jOMWK-0006Zg-BY; Tue, 14 Apr 2020 14:26:36 +0000 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120] helo=us-smtp-1.mimecast.com) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jOMWH-0006Sw-2J for linux-arm-kernel@lists.infradead.org; Tue, 14 Apr 2020 14:26:34 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1586874389; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nQ2s1P43pMD0iJunnsFh4bxmcRIUFZr+i4fF45MPy9Q=; b=bo9AEOBzu3YS2RtMb5If0uxvTKK+t9VgFF2IERidpIl3dyoGmcYqGH4nfqViLMYPAYH39P aUWNUN8Fdx1BRbPXa87lOkJ78bhAB06uQafGpQjxb6+O9zDxPsQfHyv5H2VG6Bhjw/oJ5u AhVoYoqSt7xTYr2PurTIbQYOQAnkOOw= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-219-IfhiTLKIP66Lfm6ma5_b1g-1; Tue, 14 Apr 2020 10:26:05 -0400 X-MC-Unique: IfhiTLKIP66Lfm6ma5_b1g-1 Received: by mail-wm1-f69.google.com with SMTP id q5so2440314wmc.9 for ; Tue, 14 Apr 2020 07:26:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=uSEGx3gNn1oGf/i6GkkhJSWUv9DBqbvzJo4hv43gN+I=; b=LwysYr9wkr+XJHOgTIRDx6xBFrlT0O+EMYqz+teOVQjw1Pcj/lhoiRfDATgKRo4Grh rSjV+CfKjQIg5qBrCIjX/iwJNjxzkItfH2r90RFAmlzOa2SKbwr/rhLFN1QhwPlZo104 rnAlO5dtMMq77+GHfMARpqIM4bfwWrYdP9FYuah+PjFaI7MF9KfVn2Qf6wvbGxkhI8+1 uk3aXpLFLGqNrsLtyXplyG0FicqxZ4lKRuKoCa3OVUXLUua5/dRVGG/vk8a/JytELNBj MOWYSop6mh/wmwvQ2vvZNl+poJqlXVfdN4+/H1ThrPJmqg/6f+L+QY0PX09RoNOmboL5 cBHw== X-Gm-Message-State: AGi0PubUT+2YVDwA7ka5h+du0379MXnBxRNjuyQJAhY/qKMqzDnw6Vp3 imEqQTkNr4/pTwI/wNgUVgp9vWGuI4FvhCZUm4utkr9qt+R9nUnuE+18l2jQEoS1htAXd2pGdmg 1nhgNmJ8OXRg5rOenszHiPdfBQxhyu0TikV4= X-Received: by 2002:a1c:4409:: with SMTP id r9mr102733wma.165.1586874363881; Tue, 14 Apr 2020 07:26:03 -0700 (PDT) X-Google-Smtp-Source: APiQypJqgbBq9xhT1LszvRzgjgWUmQyELrXGBlfZ5uFizKdfdTJlTiXTCHR6m1nvQHHbl9Aa0nzYPg== X-Received: by 2002:a1c:4409:: with SMTP id r9mr102702wma.165.1586874363651; Tue, 14 Apr 2020 07:26:03 -0700 (PDT) Received: from vitty.brq.redhat.com (g-server-2.ign.cz. [91.219.240.2]) by smtp.gmail.com with ESMTPSA id v10sm7145993wrq.45.2020.04.14.07.26.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Apr 2020 07:26:03 -0700 (PDT) From: Vitaly Kuznetsov To: Tianjia Zhang Subject: Re: [PATCH] KVM: Optimize kvm_arch_vcpu_ioctl_run function In-Reply-To: <20200413034523.110548-1-tianjia.zhang@linux.alibaba.com> References: <20200413034523.110548-1-tianjia.zhang@linux.alibaba.com> Date: Tue, 14 Apr 2020 16:26:01 +0200 Message-ID: <875ze2ywhy.fsf@vitty.brq.redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200414_072633_197240_008E11DC X-CRM114-Status: GOOD ( 12.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: wanpengli@tencent.com, kvm@vger.kernel.org, tianjia.zhang@linux.alibaba.com, suzuki.poulose@arm.com, maz@kernel.org, joro@8bytes.org, x86@kernel.org, linux-kernel@vger.kernel.org, sean.j.christopherson@intel.com, mingo@redhat.com, bp@alien8.de, james.morse@arm.com, hpa@zytor.com, pbonzini@redhat.com, tglx@linutronix.de, julien.thierry.kdev@gmail.com, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, jmattson@google.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Tianjia Zhang writes: > kvm_arch_vcpu_ioctl_run() is only called in the file kvm_main.c, > where vcpu->run is the kvm_run parameter, so it has been replaced. > > Signed-off-by: Tianjia Zhang > --- > arch/x86/kvm/x86.c | 8 ++++---- > virt/kvm/arm/arm.c | 2 +- > 2 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c > index 3bf2ecafd027..70e3f4abbd4d 100644 > --- a/arch/x86/kvm/x86.c > +++ b/arch/x86/kvm/x86.c > @@ -8726,18 +8726,18 @@ int kvm_arch_vcpu_ioctl_run(struct kvm_vcpu *vcpu, struct kvm_run *kvm_run) > r = -EAGAIN; > if (signal_pending(current)) { > r = -EINTR; > - vcpu->run->exit_reason = KVM_EXIT_INTR; > + kvm_run->exit_reason = KVM_EXIT_INTR; I have a more generic question: why do we need to pass 'kvm_run' to kvm_arch_vcpu_ioctl_run() if it can be extracted from 'struct kvm_vcpu'? The only call site looks like virt/kvm/kvm_main.c: r = kvm_arch_vcpu_ioctl_run(vcpu, vcpu->run); > ++vcpu->stat.signal_exits; > } > goto out; > } > > - if (vcpu->run->kvm_valid_regs & ~KVM_SYNC_X86_VALID_FIELDS) { > + if (kvm_run->kvm_valid_regs & ~KVM_SYNC_X86_VALID_FIELDS) { > r = -EINVAL; > goto out; > } > > - if (vcpu->run->kvm_dirty_regs) { > + if (kvm_run->kvm_dirty_regs) { > r = sync_regs(vcpu); > if (r != 0) > goto out; > @@ -8767,7 +8767,7 @@ int kvm_arch_vcpu_ioctl_run(struct kvm_vcpu *vcpu, struct kvm_run *kvm_run) > > out: > kvm_put_guest_fpu(vcpu); > - if (vcpu->run->kvm_valid_regs) > + if (kvm_run->kvm_valid_regs) > store_regs(vcpu); > post_kvm_run_save(vcpu); > kvm_sigset_deactivate(vcpu); > diff --git a/virt/kvm/arm/arm.c b/virt/kvm/arm/arm.c > index 48d0ec44ad77..ab9d7966a4c8 100644 > --- a/virt/kvm/arm/arm.c > +++ b/virt/kvm/arm/arm.c > @@ -659,7 +659,7 @@ int kvm_arch_vcpu_ioctl_run(struct kvm_vcpu *vcpu, struct kvm_run *run) > return ret; > > if (run->exit_reason == KVM_EXIT_MMIO) { > - ret = kvm_handle_mmio_return(vcpu, vcpu->run); > + ret = kvm_handle_mmio_return(vcpu, run); > if (ret) > return ret; > } -- Vitaly _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4261C2BA19 for ; Tue, 14 Apr 2020 14:26:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8E410206D5 for ; Tue, 14 Apr 2020 14:26:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="MiO6kYWp" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390552AbgDNO0M (ORCPT ); Tue, 14 Apr 2020 10:26:12 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:42680 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2390544AbgDNO0J (ORCPT ); Tue, 14 Apr 2020 10:26:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1586874367; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=uSEGx3gNn1oGf/i6GkkhJSWUv9DBqbvzJo4hv43gN+I=; b=MiO6kYWpZd39GQL673Mv2f46lY7jJcd6duW2hrO8ONp1egGrckndauvYXd3L3dC7yzOBhd iLPLPLwxmMqqb49mCvwMn6TNcXlZgWScFlR/SfMXeMf/5tiwuxWaRbDO2GpMKMlQr6BiUF BAhI1o8KO8ELBCYGgdzRdz9947oPB4U= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-282-Lqh4IpKiOma_mL_JJHsnng-1; Tue, 14 Apr 2020 10:26:05 -0400 X-MC-Unique: Lqh4IpKiOma_mL_JJHsnng-1 Received: by mail-wr1-f72.google.com with SMTP id g6so8755095wru.8 for ; Tue, 14 Apr 2020 07:26:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=uSEGx3gNn1oGf/i6GkkhJSWUv9DBqbvzJo4hv43gN+I=; b=r8BnWPfsl67EnpyAbX1U5JJXoqdrpzHY0BYJN44D4gOzhsrJatRwfULUuHdiN0BAn0 vVk2SNEVajMxd6txC/Tkpco6wnZ6Px+0n8YOI523eYUAp8o06huUXeTFeYzgzFGir7SO icwFBddTMqrZmTvCaWUulfVkmYVGZSx1Dr0aQ/lahurbDoVChxkMYZn0ckh9HOHp2G57 uY5jMUipPAqNVx2NsYgA5Vp18mPzQrTeox/JV7pVJT7t0eUn0wnodszspQoZ3nMJiAjN RsYlYRGvTlwBBvrfP0rq/Qs93NCCdRzryQrhroUzZ2mwGWrSF7a3C+bXr++zAL47xzRq mt2Q== X-Gm-Message-State: AGi0PuY3F0kd4THIY6iPzd2En2FShiC7icgabe3D4OUIZ6jlr4ipPbEe E0Sjs8OkghfngNnOQZjeBhUPVPrLqhvaSvoL6UqW1qrxRQxMPsNa/crRKFlJD9YYmh7RRdYIX6j jC7S+9Yom9fYn X-Received: by 2002:a1c:4409:: with SMTP id r9mr102726wma.165.1586874363879; Tue, 14 Apr 2020 07:26:03 -0700 (PDT) X-Google-Smtp-Source: APiQypJqgbBq9xhT1LszvRzgjgWUmQyELrXGBlfZ5uFizKdfdTJlTiXTCHR6m1nvQHHbl9Aa0nzYPg== X-Received: by 2002:a1c:4409:: with SMTP id r9mr102702wma.165.1586874363651; Tue, 14 Apr 2020 07:26:03 -0700 (PDT) Received: from vitty.brq.redhat.com (g-server-2.ign.cz. [91.219.240.2]) by smtp.gmail.com with ESMTPSA id v10sm7145993wrq.45.2020.04.14.07.26.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Apr 2020 07:26:03 -0700 (PDT) From: Vitaly Kuznetsov To: Tianjia Zhang Cc: kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, tianjia.zhang@linux.alibaba.com, pbonzini@redhat.com, sean.j.christopherson@intel.com, wanpengli@tencent.com, jmattson@google.com, joro@8bytes.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, x86@kernel.org, hpa@zytor.com, maz@kernel.org, james.morse@arm.com, julien.thierry.kdev@gmail.com, suzuki.poulose@arm.com Subject: Re: [PATCH] KVM: Optimize kvm_arch_vcpu_ioctl_run function In-Reply-To: <20200413034523.110548-1-tianjia.zhang@linux.alibaba.com> References: <20200413034523.110548-1-tianjia.zhang@linux.alibaba.com> Date: Tue, 14 Apr 2020 16:26:01 +0200 Message-ID: <875ze2ywhy.fsf@vitty.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Tianjia Zhang writes: > kvm_arch_vcpu_ioctl_run() is only called in the file kvm_main.c, > where vcpu->run is the kvm_run parameter, so it has been replaced. > > Signed-off-by: Tianjia Zhang > --- > arch/x86/kvm/x86.c | 8 ++++---- > virt/kvm/arm/arm.c | 2 +- > 2 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c > index 3bf2ecafd027..70e3f4abbd4d 100644 > --- a/arch/x86/kvm/x86.c > +++ b/arch/x86/kvm/x86.c > @@ -8726,18 +8726,18 @@ int kvm_arch_vcpu_ioctl_run(struct kvm_vcpu *vcpu, struct kvm_run *kvm_run) > r = -EAGAIN; > if (signal_pending(current)) { > r = -EINTR; > - vcpu->run->exit_reason = KVM_EXIT_INTR; > + kvm_run->exit_reason = KVM_EXIT_INTR; I have a more generic question: why do we need to pass 'kvm_run' to kvm_arch_vcpu_ioctl_run() if it can be extracted from 'struct kvm_vcpu'? The only call site looks like virt/kvm/kvm_main.c: r = kvm_arch_vcpu_ioctl_run(vcpu, vcpu->run); > ++vcpu->stat.signal_exits; > } > goto out; > } > > - if (vcpu->run->kvm_valid_regs & ~KVM_SYNC_X86_VALID_FIELDS) { > + if (kvm_run->kvm_valid_regs & ~KVM_SYNC_X86_VALID_FIELDS) { > r = -EINVAL; > goto out; > } > > - if (vcpu->run->kvm_dirty_regs) { > + if (kvm_run->kvm_dirty_regs) { > r = sync_regs(vcpu); > if (r != 0) > goto out; > @@ -8767,7 +8767,7 @@ int kvm_arch_vcpu_ioctl_run(struct kvm_vcpu *vcpu, struct kvm_run *kvm_run) > > out: > kvm_put_guest_fpu(vcpu); > - if (vcpu->run->kvm_valid_regs) > + if (kvm_run->kvm_valid_regs) > store_regs(vcpu); > post_kvm_run_save(vcpu); > kvm_sigset_deactivate(vcpu); > diff --git a/virt/kvm/arm/arm.c b/virt/kvm/arm/arm.c > index 48d0ec44ad77..ab9d7966a4c8 100644 > --- a/virt/kvm/arm/arm.c > +++ b/virt/kvm/arm/arm.c > @@ -659,7 +659,7 @@ int kvm_arch_vcpu_ioctl_run(struct kvm_vcpu *vcpu, struct kvm_run *run) > return ret; > > if (run->exit_reason == KVM_EXIT_MMIO) { > - ret = kvm_handle_mmio_return(vcpu, vcpu->run); > + ret = kvm_handle_mmio_return(vcpu, run); > if (ret) > return ret; > } -- Vitaly