From: Adrian Ratiu <adrian.ratiu@collabora.com>
To: Philipp Zabel <pza@pengutronix.de>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
Ezequiel Garcia <ezequiel@collabora.com>,
kernel@collabora.com, kernel@pengutronix.de,
Tim Harvey <tharvey@gateworks.com>
Subject: Re: [PATCH 2/2] media: coda: be more flexible wrt jpeg dimensions
Date: Tue, 24 Mar 2020 13:14:37 +0200 [thread overview]
Message-ID: <875zeugg2q.fsf@collabora.com> (raw)
In-Reply-To: <20200324092131.GB12488@pengutronix.de>
On Tue, 24 Mar 2020, Philipp Zabel <pza@pengutronix.de> wrote:
> Hi Adrian,
>
> On Mon, Mar 23, 2020 at 03:09:37PM +0200, Adrian Ratiu wrote:
>> Don't require jpeg dimensions to exactly match format
>> dimensions, so we are able to decode and display a wider range
>> jpegs instead of outright rejecting the ones which don't match.
>
> I don't think this is right. If userspace feeds us an
> incomatible JPEG we should probably stop decoding and send a
> source change event instead [1].
Please ignore this second patch as it abuses the spec as Ezequiel
mentioned in the other reply. The correct approach would be to
do a format renegotiation in userspace so the test can be passed.
I will send an updated v2 of the huffman table patch based on
your feedback.
Thank you,
Adrian
>
> [1] https://linuxtv.org/downloads/v4l-dvb-apis-new/uapi/v4l/dev-decoder.html#dynamic-resolution-change
>
> regards
> Philipp
prev parent reply other threads:[~2020-03-24 11:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-23 13:09 [PATCH 0/2] media: coda: Add ability to decode wider range of jpegs Adrian Ratiu
2020-03-23 13:09 ` [PATCH 1/2] media: coda: jpeg: support optimized huffman tables Adrian Ratiu
2020-03-24 9:11 ` Philipp Zabel
2020-03-23 13:09 ` [PATCH 2/2] media: coda: be more flexible wrt jpeg dimensions Adrian Ratiu
2020-03-23 14:27 ` Ezequiel Garcia
2020-03-24 9:21 ` Philipp Zabel
2020-03-24 11:14 ` Adrian Ratiu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875zeugg2q.fsf@collabora.com \
--to=adrian.ratiu@collabora.com \
--cc=ezequiel@collabora.com \
--cc=kernel@collabora.com \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=pza@pengutronix.de \
--cc=tharvey@gateworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.