From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 517A2C3F2D1 for ; Wed, 4 Mar 2020 15:11:08 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1A8FA20848 for ; Wed, 4 Mar 2020 15:11:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Zf4X4zIl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1A8FA20848 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1j9Vff-00013a-C9; Wed, 04 Mar 2020 15:10:51 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1j9Vfd-00012i-8b for xen-devel@lists.xenproject.org; Wed, 04 Mar 2020 15:10:49 +0000 X-Inumbo-ID: 53a1d4c7-5e2a-11ea-a418-12813bfff9fa Received: from us-smtp-delivery-1.mimecast.com (unknown [207.211.31.120]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTP id 53a1d4c7-5e2a-11ea-a418-12813bfff9fa; Wed, 04 Mar 2020 15:10:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583334647; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aV2ERlSJsI2FpkwWQpWb1+QW/Sr6AY0k5wGVtgwLXns=; b=Zf4X4zIl6xIDCu7Qi6TyhPf4LKaIpwVBVfvwyyIno/DSSX2uW4dFceES69jq6EU/oEEQzo 64hEjy5YogWPQ3pAoFtm8FYMBu+Zfwj3iFMgGnKB5MGPssJc3Pec9GiRVMM0Ra9e+NBBrG 3oRuuL5WZjzVdaDXjOko0mbheZDaIS4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-25-gAmdQMw4PJWbeUsQonhiBA-1; Wed, 04 Mar 2020 10:10:43 -0500 X-MC-Unique: gAmdQMw4PJWbeUsQonhiBA-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0CAD51005F7A; Wed, 4 Mar 2020 15:10:41 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-116-129.ams2.redhat.com [10.36.116.129]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 515B490CC3; Wed, 4 Mar 2020 15:10:35 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id CB22D11386A6; Wed, 4 Mar 2020 16:10:33 +0100 (CET) From: Markus Armbruster To: Vladimir Sementsov-Ogievskiy References: <20200131130118.1716-1-vsementsov@virtuozzo.com> <20200131130118.1716-4-vsementsov@virtuozzo.com> <87v9nxwulz.fsf@dusky.pond.sub.org> Date: Wed, 04 Mar 2020 16:10:33 +0100 In-Reply-To: (Vladimir Sementsov-Ogievskiy's message of "Wed, 4 Mar 2020 16:40:13 +0300") Message-ID: <875zfki2ae.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Subject: Re: [Xen-devel] [PATCH v7 03/11] scripts: add coccinelle script to use auto propagated errp X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Stefano Stabellini , qemu-block@nongnu.org, Paul Durrant , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Michael Roth , qemu-devel@nongnu.org, Greg Kurz , Gerd Hoffmann , Stefan Hajnoczi , Anthony Perard , xen-devel@lists.xenproject.org, Max Reitz , Laszlo Ersek , Stefan Berger Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" VmxhZGltaXIgU2VtZW50c292LU9naWV2c2tpeSA8dnNlbWVudHNvdkB2aXJ0dW96em8uY29tPiB3 cml0ZXM6Cgo+IDIzLjAyLjIwMjAgMTE6NTUsIE1hcmt1cyBBcm1icnVzdGVyIHdyb3RlOgo+PiBW bGFkaW1pciBTZW1lbnRzb3YtT2dpZXZza2l5IDx2c2VtZW50c292QHZpcnR1b3p6by5jb20+IHdy aXRlczoKPj4KPj4+IFNjcmlwdCBhZGRzIEVSUlBfQVVUT19QUk9QQUdBVEUgbWFjcm8gaW52b2Nh dGlvbiB3aGVyZSBhcHByb3ByaWF0ZSBhbmQKPj4+IGRvZXMgY29ycmVzcG9uZGluZyBjaGFuZ2Vz IGluIGNvZGUgKGxvb2sgZm9yIGRldGFpbHMgaW4KPj4+IGluY2x1ZGUvcWFwaS9lcnJvci5oKQo+ Pj4KPj4+IFVzYWdlIGV4YW1wbGU6Cj4+PiBzcGF0Y2ggLS1zcC1maWxlIHNjcmlwdHMvY29jY2lu ZWxsZS9hdXRvLXByb3BhZ2F0ZWQtZXJycC5jb2NjaSBcCj4+PiAgIC0tbWFjcm8tZmlsZSBzY3Jp cHRzL2NvY2NpLW1hY3JvLWZpbGUuaCAtLWluLXBsYWNlIC0tbm8tc2hvdy1kaWZmIFwKPj4+ICAg YmxvY2tkZXYtbmJkLmMgcWVtdS1uYmQuYyB7YmxvY2svbmJkKixuYmQvKixpbmNsdWRlL2Jsb2Nr L25iZCp9LltoY10KPj4+Cj4+PiBTaWduZWQtb2ZmLWJ5OiBWbGFkaW1pciBTZW1lbnRzb3YtT2dp ZXZza2l5IDx2c2VtZW50c292QHZpcnR1b3p6by5jb20+Cj4+PiAtLS0KPj4+Cj4+PiBDQzogRXJp YyBCbGFrZSA8ZWJsYWtlQHJlZGhhdC5jb20+Cj4+PiBDQzogS2V2aW4gV29sZiA8a3dvbGZAcmVk aGF0LmNvbT4KPj4+IENDOiBNYXggUmVpdHogPG1yZWl0ekByZWRoYXQuY29tPgo+Pj4gQ0M6IEdy ZWcgS3VyeiA8Z3JvdWdAa2FvZC5vcmc+Cj4+PiBDQzogU3RlZmFubyBTdGFiZWxsaW5pIDxzc3Rh YmVsbGluaUBrZXJuZWwub3JnPgo+Pj4gQ0M6IEFudGhvbnkgUGVyYXJkIDxhbnRob255LnBlcmFy ZEBjaXRyaXguY29tPgo+Pj4gQ0M6IFBhdWwgRHVycmFudCA8cGF1bEB4ZW4ub3JnPgo+Pj4gQ0M6 IFN0ZWZhbiBIYWpub2N6aSA8c3RlZmFuaGFAcmVkaGF0LmNvbT4KPj4+IENDOiAiUGhpbGlwcGUg TWF0aGlldS1EYXVkw6kiIDxwaGlsbWRAcmVkaGF0LmNvbT4KPj4+IENDOiBMYXN6bG8gRXJzZWsg PGxlcnNla0ByZWRoYXQuY29tPgo+Pj4gQ0M6IEdlcmQgSG9mZm1hbm4gPGtyYXhlbEByZWRoYXQu Y29tPgo+Pj4gQ0M6IFN0ZWZhbiBCZXJnZXIgPHN0ZWZhbmJAbGludXguaWJtLmNvbT4KPj4+IEND OiBNYXJrdXMgQXJtYnJ1c3RlciA8YXJtYnJ1QHJlZGhhdC5jb20+Cj4+PiBDQzogTWljaGFlbCBS b3RoIDxtZHJvdGhAbGludXgudm5ldC5pYm0uY29tPgo+Pj4gQ0M6IHFlbXUtYmxvY2tAbm9uZ251 Lm9yZwo+Pj4gQ0M6IHhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZwo+Pj4KPj4+ICAgaW5j bHVkZS9xYXBpL2Vycm9yLmggICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAzICsKPj4+ICAg c2NyaXB0cy9jb2NjaW5lbGxlL2F1dG8tcHJvcGFnYXRlZC1lcnJwLmNvY2NpIHwgMTU4ICsrKysr KysrKysrKysrKysrKwo+Pj4gICAyIGZpbGVzIGNoYW5nZWQsIDE2MSBpbnNlcnRpb25zKCspCj4+ PiAgIGNyZWF0ZSBtb2RlIDEwMDY0NCBzY3JpcHRzL2NvY2NpbmVsbGUvYXV0by1wcm9wYWdhdGVk LWVycnAuY29jY2kKPj4+Cj4+PiBkaWZmIC0tZ2l0IGEvaW5jbHVkZS9xYXBpL2Vycm9yLmggYi9p bmNsdWRlL3FhcGkvZXJyb3IuaAo+Pj4gaW5kZXggYjk0NTJkNDgwNi4uNzlmOGU5NTIxNCAxMDA2 NDQKPj4+IC0tLSBhL2luY2x1ZGUvcWFwaS9lcnJvci5oCj4+PiArKysgYi9pbmNsdWRlL3FhcGkv ZXJyb3IuaAo+Pj4gQEAgLTE0MSw2ICsxNDEsOSBAQAo+Pj4gICAgKiAgICAgICAgIC4uLgo+Pj4g ICAgKiAgICAgfQo+Pj4gICAgKgo+Pj4gKyAqIEZvciBtYXNzIGNvbnZlcnNpb24gdXNlIHNjcmlw dAo+Pj4gKyAqICAgc2NyaXB0cy9jb2NjaW5lbGxlL2F1dG8tcHJvcGFnYXRlZC1lcnJwLmNvY2Np Cj4+PiArICoKPj4+ICAgICoKPj4+ICAgICogUmVjZWl2ZSBhbmQgYWNjdW11bGF0ZSBtdWx0aXBs ZSBlcnJvcnMgKGZpcnN0IG9uZSB3aW5zKToKPj4+ICAgICogICAgIEVycm9yICplcnIgPSBOVUxM LCAqbG9jYWxfZXJyID0gTlVMTDsKPj4KPj4gRXh0cmEgYmxhbmsgbGluZS4KPj4KPj4+IGRpZmYg LS1naXQgYS9zY3JpcHRzL2NvY2NpbmVsbGUvYXV0by1wcm9wYWdhdGVkLWVycnAuY29jY2kgYi9z Y3JpcHRzL2NvY2NpbmVsbGUvYXV0by1wcm9wYWdhdGVkLWVycnAuY29jY2kKPj4+IG5ldyBmaWxl IG1vZGUgMTAwNjQ0Cj4+PiBpbmRleCAwMDAwMDAwMDAwLi5mYjAzYzg3MWNiCj4+PiAtLS0gL2Rl di9udWxsCj4+PiArKysgYi9zY3JpcHRzL2NvY2NpbmVsbGUvYXV0by1wcm9wYWdhdGVkLWVycnAu Y29jY2kKPj4+IEBAIC0wLDAgKzEsMTU4IEBACj4+PiArLy8gVXNlIEVSUlBfQVVUT19QUk9QQUdB VEUgKHNlZSBpbmNsdWRlL3FhcGkvZXJyb3IuaCkKPj4+ICsvLwo+Pj4gKy8vIENvcHlyaWdodCAo YykgMjAyMCBWaXJ0dW96em8gSW50ZXJuYXRpb25hbCBHbWJILgo+Pj4gKy8vCj4+PiArLy8gVGhp cyBwcm9ncmFtIGlzIGZyZWUgc29mdHdhcmU7IHlvdSBjYW4gcmVkaXN0cmlidXRlIGl0IGFuZC9v ciBtb2RpZnkKPj4+ICsvLyBpdCB1bmRlciB0aGUgdGVybXMgb2YgdGhlIEdOVSBHZW5lcmFsIFB1 YmxpYyBMaWNlbnNlIGFzIHB1Ymxpc2hlZCBieQo+Pj4gKy8vIHRoZSBGcmVlIFNvZnR3YXJlIEZv dW5kYXRpb247IGVpdGhlciB2ZXJzaW9uIDIgb2YgdGhlIExpY2Vuc2UsIG9yCj4+PiArLy8gKGF0 IHlvdXIgb3B0aW9uKSBhbnkgbGF0ZXIgdmVyc2lvbi4KPj4+ICsvLwo+Pj4gKy8vIFRoaXMgcHJv Z3JhbSBpcyBkaXN0cmlidXRlZCBpbiB0aGUgaG9wZSB0aGF0IGl0IHdpbGwgYmUgdXNlZnVsLAo+ Pj4gKy8vIGJ1dCBXSVRIT1VUIEFOWSBXQVJSQU5UWTsgd2l0aG91dCBldmVuIHRoZSBpbXBsaWVk IHdhcnJhbnR5IG9mCj4+PiArLy8gTUVSQ0hBTlRBQklMSVRZIG9yIEZJVE5FU1MgRk9SIEEgUEFS VElDVUxBUiBQVVJQT1NFLiAgU2VlIHRoZQo+Pj4gKy8vIEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNl bnNlIGZvciBtb3JlIGRldGFpbHMuCj4+PiArLy8KPj4+ICsvLyBZb3Ugc2hvdWxkIGhhdmUgcmVj ZWl2ZWQgYSBjb3B5IG9mIHRoZSBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZQo+Pj4gKy8vIGFs b25nIHdpdGggdGhpcyBwcm9ncmFtLiAgSWYgbm90LCBzZWUgPGh0dHA6Ly93d3cuZ251Lm9yZy9s aWNlbnNlcy8+Lgo+Pj4gKy8vCj4+PiArLy8gVXNhZ2UgZXhhbXBsZToKPj4+ICsvLyBzcGF0Y2gg LS1zcC1maWxlIHNjcmlwdHMvY29jY2luZWxsZS9hdXRvLXByb3BhZ2F0ZWQtZXJycC5jb2NjaSBc Cj4+PiArLy8gIC0tbWFjcm8tZmlsZSBzY3JpcHRzL2NvY2NpLW1hY3JvLWZpbGUuaCAtLWluLXBs YWNlIC0tbm8tc2hvdy1kaWZmIFwKPj4+ICsvLyAgYmxvY2tkZXYtbmJkLmMgcWVtdS1uYmQuYyB7 YmxvY2svbmJkKixuYmQvKixpbmNsdWRlL2Jsb2NrL25iZCp9LltoY10KPj4+ICsKPj4+ICtAcnVs ZTBACj4+PiArLy8gQWRkIGludm9jYXRpb24gdG8gZXJycC1mdW5jdGlvbnMgd2hlcmUgbmVjZXNz YXJ5Cj4+PiArLy8gV2Ugc2hvdWxkIHNraXAgZnVuY3Rpb25zIHdpdGggIkVycm9yICpjb25zdCAq ZXJycCIKPj4+ICsvLyBwYXJhbWV0ZXIsIGJ1dCBob3cgdG8gZG8gaXQgd2l0aCBjb2NjaW5lbGxl Pwo+Pj4gKy8vIEkgZG9uJ3Qga25vdywgc28sIEkgc2tpcCB0aGVtIGJ5IGZ1bmN0aW9uIG5hbWUg cmVnZXguCj4+PiArLy8gSXQncyBzYWZlOiBpZiB3ZSBkaWQgbm90IHNraXAgc29tZSBmdW5jdGlv bnMgd2l0aAo+Pj4gKy8vICJFcnJvciAqY29uc3QgKmVycnAiLCBFUlJQX0FVVE9fUFJPUEFHQVRF IGludm9jYXRpb24KPj4+ICsvLyB3aWxsIGZhaWwgdG8gY29tcGlsZSwgYmVjYXVzZSBvZiBjb25z dCB2aW9sYXRpb24uCj4+Cj4+IE5vdCBza2lwcGluZyBhIGZ1bmN0aW9uIHdlIHNob3VsZCBza2lw IGZhaWxzIHRvIGNvbXBpbGUuCj4+Cj4+IFdoYXQgYWJvdXQgc2tpcHBpbmcgYSBmdW5jdGlvbiB3 ZSBzaG91bGQgbm90IHNraXA/Cj4+Cj4+PiAraWRlbnRpZmllciBmbiAhfiAiZXJyb3JfYXBwZW5k Xy4qX2hpbnQiOwo+Pj4gK2lkZW50aWZpZXIgbG9jYWxfZXJyLCBFUlJQOwo+Pgo+PiBBIGZldyBv ZiBvdXIgY29jY2luZWxsZSBzY3JpcHRzIHVzZSBBTExfQ0FQUyBmb3IgbWV0YS12YXJpYWJsZXMu ICBNb3N0Cj4+IGRvbid0LiAgRWl0aGVyIGlzIGZpbmUgd2l0aCBtZS4gIE1peGluZyB0aGUgdHdv IHN0eWxlcyBmZWVscyBhIGJpdAo+PiBjb25mdXNpbmcsIHRob3VnaC4KPj4KPj4+ICtAQAo+Pj4g Kwo+Pj4gKyBmbiguLi4sIEVycm9yICoqRVJSUCwgLi4uKQo+Pj4gKyB7Cj4+PiArKyAgIEVSUlBf QVVUT19QUk9QQUdBVEUoKTsKPj4+ICsgICAgPCsuLi4KPj4+ICsgICAgICAgIHdoZW4gIT0gRVJS UF9BVVRPX1BST1BBR0FURSgpOwo+Pj4gKygKPj4+ICsgICAgZXJyb3JfYXBwZW5kX2hpbnQoRVJS UCwgLi4uKTsKPj4+ICt8Cj4+PiArICAgIGVycm9yX3ByZXBlbmQoRVJSUCwgLi4uKTsKPj4+ICt8 Cj4+PiArICAgIEVycm9yICpsb2NhbF9lcnIgPSBOVUxMOwo+Pj4gKykKPj4+ICsgICAgLi4uKz4K Pj4+ICsgfQo+Pgo+PiBNaXNzZXMgZXJyb3JfdnByZXBlbmQoKS4gIEN1cnJlbnRseSBoYXJtbGVz cywgYnV0IGFzIGxvbmcgYXMgd2UgY29tbWl0Cj4+IHRoZSBzY3JpcHQsIHdlIGJldHRlciBtYWtl IGl0IGFzIHJvYnVzdCBhcyB3ZSByZWFzb25hYmx5IGNhbi4KPj4KPj4gVGhlIHByZXZpb3VzIHBh dGNoIGV4cGxhaW5zIHRoaXMgQ29jY2luZWxsZSBzY3JpcHQncyBpbnRlbnQ6Cj4+Cj4+ICAgIFRv IGFjaGlldmUgdGhlc2UgZ29hbHMsIGxhdGVyIHBhdGNoZXMgd2lsbCBhZGQgaW52b2NhdGlvbnMK Pj4gICAgb2YgdGhpcyBtYWNybyBhdCB0aGUgc3RhcnQgb2YgZnVuY3Rpb25zIHdpdGggZWl0aGVy IHVzZQo+PiAgICBlcnJvcl9wcmVwZW5kL2Vycm9yX2FwcGVuZF9oaW50IChzb2x2aW5nIDEpIG9y IHdoaWNoIHVzZQo+PiAgICBsb2NhbF9lcnIrZXJyb3JfcHJvcGFnYXRlIHRvIGNoZWNrIGVycm9y cywgc3dpdGNoaW5nIHRob3NlCj4+ICAgIGZ1bmN0aW9ucyB0byB1c2UgKmVycnAgaW5zdGVhZCAo c29sdmluZyAyIGFuZCAzKS4KPj4KPj4gVGhpcyBydWxlIG1hdGNoZXMgInVzZSBlcnJvcl9wcmVw ZW5kL2Vycm9yX2FwcGVuZF9oaW50IiBkaXJlY3RseS4gIEl0Cj4+IGFwcGVhcnMgdG8gdXNlIHBy ZXNlbmNlIG9mIGEgbG9jYWwgRXJyb3IgKiB2YXJpYWJsZSBhcyBwcm94eSBmb3IgInVzZQo+PiBs b2NhbF9lcnIrZXJyb3JfcHJvcGFnYXRlIHRvIGNoZWNrIGVycm9ycyIuICBIbW0uCj4+Cj4+IFdl IG9idmlvdXNseSBoYXZlIHN1Y2ggYSB2YXJpYWJsZSB3aGVuIHdlIHVzZSAibG9jYWxfZXJyK2Vy cm9yX3Byb3BhZ2F0ZQo+PiB0byBjaGVjayBlcnJvcnMiLiAgQnV0IHdlIGNvdWxkIGFsc28gaGF2 ZSBzdWNoIHZhcmlhYmxlcyB3aXRob3V0IHVzZSBvZgo+PiBlcnJvcl9wcm9wYWdhdGUoKS4gIElu IGZhY3QsIGVycm9yLmggZG9jdW1lbnRzIHN1Y2ggdXNlOgo+Pgo+PiAgICogQ2FsbCBhIGZ1bmN0 aW9uIGFuZCByZWNlaXZlIGFuIGVycm9yIGZyb20gaXQ6Cj4+ICAgKiAgICAgRXJyb3IgKmVyciA9 IE5VTEw7Cj4+ICAgKiAgICAgZm9vKGFyZywgJmVycik7Cj4+ICAgKiAgICAgaWYgKGVycikgewo+ PiAgICogICAgICAgICBoYW5kbGUgdGhlIGVycm9yLi4uCj4+ICAgKiAgICAgfQo+Pgo+PiB3aGVy ZSAiaGFuZGxlIHRoZSBlcnJvciIgZnJlZXMgaXQuCj4+Cj4+IEkgZmlndXJlIHN1Y2ggdXNlcyB0 eXBpY2FsbHkgb2NjdXIgaW4gZnVuY3Rpb25zIHdpdGhvdXQgYW4gRXJyb3IgKiplcnJwCj4+IHBh cmFtZXRlci4gIFRoaXMgcnVsZSBkb2Vzbid0IGFwcGx5IHRoZW4uICBCdXQgdGhleSBjb3VsZCBv Y2N1ciBldmVuIGluCj4+IGZ1bmN0aW9ucyB3aXRoIHN1Y2ggYSBwYXJhbWV0ZXIuICBDb25zaWRl cjoKPj4KPj4gICAgICB2b2lkIGZvbyhFcnJvciAqKmVycnApCj4+ICAgICAgewo+PiAgICAgICAg ICBFcnJvciAqZXJyID0gTlVMTDsKPj4KPj4gICAgICAgICAgYmFyKCZlcnIpOwo+PiAgICAgICAg ICBpZiAoZXJyKSB7Cj4+ICAgICAgICAgICAgICBlcnJvcl9mcmVlKGVycik7Cj4+ICAgICAgICAg ICAgICBlcnJvcl9zZXRnKGVycnAsICJjb21wbGV0ZWx5IGRpZmZlcmVudCBlcnJvciIpOwo+PiAg ICAgICAgICB9Cj4+ICAgICAgfQo+Pgo+PiBSZWFzb25hYmxlIGVub3VnaCB3aGVuIGJhcigpIGdp dmVzIHVzIGFuIGVycm9yIHRoYXQncyBtaXNsZWFkaW5nIGluIHRoaXMKPj4gY29udGV4dCwgaXNu J3QgaXQ/Cj4+Cj4+IFRoZSBzY3JpcHQgdHJhbnNmb3JtcyBpdCBsaWtlIHRoaXM6Cj4+Cj4+ICAg ICAgdm9pZCBmb28oRXJyb3IgKiplcnJwKQo+PiAgICAgIHsKPj4gICAgIC0gICAgRXJyb3IgKmVy ciA9IE5VTEw7Cj4+ICAgICArICAgIEVSUlBfQVVUT19QUk9QQUdBVEUoKTsKPj4KPj4gICAgIC0g ICAgYmFyKCZlcnIpOwo+PiAgICAgLSAgICBpZiAoZXJyKSB7Cj4+ICAgICAtICAgICAgICBlcnJv cl9mcmVlKGVycik7Cj4+ICAgICArICAgIGJhcihlcnJwKTsKPj4gICAgICsgICAgaWYgKCplcnJw KSB7Cj4+ICAgICArICAgICAgICBlcnJvcl9mcmVlX2VycnAoZXJycCk7Cj4+ICAgICAgICAgICAg ICBlcnJvcl9zZXRnKGVycnAsICJjb21wbGV0ZWx5IGRpZmZlcmVudCBlcnJvciIpOwo+PiAgICAg ICAgICB9Cj4+ICAgICAgfQo+Pgo+PiBVbndhbnRlZC4KPj4KPj4gTm93LCBpZiB0aGlzIHNjcmlw dCBhcHBsaWVkIGluIGp1c3QgYSBmZXcgZG96ZW4gcGxhY2VzLCB3ZSBjb3VsZCByZWx5IG9uCj4+ IGV5ZWJhbGxpbmcgaXRzIG91dHB1dCB0byBjYXRjaCB1bndhbnRlZCB0cmFuc2Zvcm1hdGlvbnMu ICBTaW5jZSBpdAo+PiBhcHBsaWVzIGluIHNvIG1hbnkgbW9yZSwgSSBkb24ndCBmZWVsIGNvbWZv cnRhYmxlIHJlbHlpbmcgb24gcmV2aWV3ZXIKPj4gZXllYmFsbHMuCj4+Cj4+IENhbiB3ZSBtYWtl IHJ1bGUwIGRpcmVjdGx5IG1hdGNoIGVycm9yX3Byb3BhZ2F0ZShlcnJwLCBsb2NhbF9lcnIpCj4+ IHNvbWVob3c/Cj4+Cj4+IEFub3RoZXIgb2JzZXJ2YXRpb246IHRoZSBydWxlIGRvZXMgbm90IG1h dGNoIGVycm9yX3JlcG9ydGZfZXJyKCkgYW5kCj4+IHdhcm5fcmVwb3J0Zl9lcnIoKS4KPgo+IFRo ZXkgYXJlIHVucmVsYXRlZCwgYXMgdGhleSB0YWtlIEVycm9yKiBhcmd1bWVudCwgbm90IEVycm9y KioKPgo+PiBUaGVzZSBjb21iaW5lIGVycm9yX3ByZXBlbmQoKSwKPj4gZXJyb3JfcmVwb3J0KCkv d2Fybl9yZXBvcnQoKSBhbmQgZXJyb3JfZnJlZSgpLCBmb3IgY29udmVuaWVuY2UuICBEb24ndAo+ PiB0aGVpciB1c2VycyBuZWVkIEVSUlBfQVVUT19QUk9QQUdBVEUoKSBqdXN0IGxpa2UgZXJyb3Jf cHJlcGVuZCgpJ3MKPj4gdXNlcnM/CgpSaWdodCwgd2UgbmV2ZXIgcGFzcyAqZXJycCB0byBlcnJv cl9yZXBvcnRmX2VycigpIGFuZAp3YXJuX3JlcG9ydGZfZXJyKCksIHNvIHRoZXJlJ3Mgbm8gbmVl ZCB0byB3cmFwIGl0LgoKQnV0IHNlZSBiZWxvdy4KCj4+Cj4+PiArCj4+PiArQEAKPj4+ICsvLyBT d2l0Y2ggdW51c3VhbCAoRXJyb3IgKiopIHBhcmFtZXRlciBuYW1lcyB0byBlcnJwCj4+PiArLy8g KHRoaXMgaXMgbmVjZXNzYXJ5IHRvIHVzZSBFUlJQX0FVVE9fUFJPUEFHQVRFKS4KPj4KPj4gUGxl YXNlIHB1dCB5b3VyIHJ1bGUgY29tbWVudHMgcmlnaHQgYmVmb3JlIHRoZSBydWxlLCBpLmUuIGJl Zm9yZSB0aGUKPj4gQC1saW5lIGludHJvZHVjaW5nIG1ldGF2YXJpYWJsZSBkZWNsYXJhdGlvbnMs IG5vdCBhZnRlci4gIFNhbWUKPj4gZWxzZXdoZXJlLgo+Pgo+Pj4gK2lkZW50aWZpZXIgcnVsZTAu Zm47Cj4+PiAraWRlbnRpZmllciBydWxlMC5FUlJQICE9IGVycnA7Cj4+PiArQEAKPj4+ICsKPj4+ ICsgZm4oLi4uLAo+Pj4gKy0gICBFcnJvciAqKkVSUlAKPj4+ICsrICAgRXJyb3IgKiplcnJwCj4+ PiArICAgICwuLi4pCj4+PiArIHsKPj4+ICsgICAgIDwuLi4KPj4+ICstICAgIEVSUlAKPj4+ICsr ICAgIGVycnAKPj4+ICsgICAgIC4uLj4KPj4+ICsgfQo+Pgo+PiBUaGlzIG5vcm1hbGl6ZXMgZXJy cCBwYXJhbWV0ZXIgbmFtaW5nLiAgSXQgbWF0Y2hlcyBleGFjdGx5IHdoZW4gcnVsZTAKPj4gbWF0 Y2hlcyAoYW5kIGluc2VydHMgRVJSUF9BVVRPX1BST1BBR0FURSgpKSBhbmQgdGhlIEVycm9yICoq IHBhcmFtZXRlcgo+PiBpcyB1bnVzdWFsLiAgR29vZC4KPj4KPj4+ICsKPj4+ICtAcnVsZTFACj4+ PiArLy8gV2Ugd2FudCB0byBwYXRjaCBlcnJvciBwcm9wYWdhdGlvbiBpbiBmdW5jdGlvbnMgcmVn YXJkbGVzcyBvZgo+Pj4gKy8vIHdoZXRoZXIgdGhlIGZ1bmN0aW9uIGFscmVhZHkgdXNlcyBFUlJQ X0FVVE9fUFJPUEFHQVRFIHByaW9yIHRvCj4+PiArLy8gYXBwbHlpbmcgcnVsZTAsIGhlbmNlIHRo aXMgb25lIGRvZXMgbm90IGluaGVyaXQgZnJvbSBpdC4KPj4KPj4gSSdtIG5vdCBzdXJlIEkgZ2V0 IHRoaXMgY29tbWVudC4gIExldCdzIHNlZSB3aGF0IHRoZSBydWxlIGRvZXMuCj4+Cj4+PiAraWRl bnRpZmllciBmbiAhfiAiZXJyb3JfYXBwZW5kXy4qX2hpbnQiOwo+Pj4gK2lkZW50aWZpZXIgbG9j YWxfZXJyOwo+Pj4gK3N5bWJvbCBlcnJwOwo+Pj4gK0BACj4+PiArCj4+PiArIGZuKC4uLiwgRXJy b3IgKiplcnJwLCAuLi4pCj4+PiArIHsKPj4+ICsgICAgIDwuLi4KPj4+ICstICAgIEVycm9yICps b2NhbF9lcnIgPSBOVUxMOwo+Pj4gKyAgICAgLi4uPgo+Pj4gKyB9Cj4+Cj4+IHJ1bGUxIG1hdGNo ZXMgbGlrZSBydWxlMCwgZXhjZXB0IHRoZSBFcnJvciAqKiBwYXJhbWV0ZXIgbWF0Y2ggaXMKPj4g dGlnaHRlbmVkIGZyb20gYW55IEMgaWRlbnRpZmllciB0byB0aGUgQyBpZGVudGlmaWVyIGVycnAs IGFuZCB0aGUKPj4gZnVuY3Rpb24gYm9keSBtYXRjaCB0aWdodGVuZWQgZnJvbSAiZWl0aGVyIHVz ZQo+PiBlcnJvcl9wcmVwZW5kL2Vycm9yX2FwcGVuZF9oaW50IG9yIHdoaWNoIHVzZSBsb2NhbF9l cnIrZXJyb3JfcHJvcGFnYXRlCj4+IHRvIGNoZWNrIGVycm9ycyIgdG8ganVzdCB0aGUgbGF0dGVy Lgo+Pgo+PiBJIGZpZ3VyZSB0aWdodGVuaW5nIHRoZSBFcnJvciAqKiBwYXJhbWV0ZXIgbWF0Y2gg aGFzIG5vIGVmZmVjdCwgYmVjYXVzZQo+PiB3ZSBhbHJlYWR5IG5vcm1hbGl6ZWQgdGhlIHBhcmFt ZXRlciBuYW1lLgo+Pgo+PiBTbyBydWxlMSBkZWxldGVzIHZhcmlhYmxlIGxvY2FsX2VyciB3aGVy ZSBydWxlMCBhcHBsaWVkLiAgQ29ycmVjdD8KPj4KPj4+ICsKPj4+ICtAQAo+Pj4gKy8vIEhhbmRs ZSBwYXR0ZXJuIHdpdGggZ290bywgb3RoZXJ3aXNlIHdlJ2xsIGZpbmlzaCB1cAo+Pj4gKy8vIHdp dGggbGFiZWxzIGF0IGZ1bmN0aW9uIGVuZCB3aGljaCB3aWxsIG5vdCBjb21waWxlLgo+Pj4gK2lk ZW50aWZpZXIgcnVsZTEuZm4sIHJ1bGUxLmxvY2FsX2VycjsKPj4+ICtpZGVudGlmaWVyIE9VVDsK Pj4+ICtAQAo+Pj4gKwo+Pj4gKyBmbiguLi4pCj4+PiArIHsKPj4+ICsgICAgIDwuLi4KPj4+ICst ICAgIGdvdG8gT1VUOwo+Pj4gKysgICAgcmV0dXJuOwo+Pj4gKyAgICAgLi4uPgo+Pj4gKy0gT1VU Ogo+Pj4gKy0gICAgZXJyb3JfcHJvcGFnYXRlKGVycnAsIGxvY2FsX2Vycik7Cj4+PiArIH0KPj4K Pj4gVGhpcyBpcyBvbmUgc3BlY2lhbCBjYXNlIG9mIGVycm9yX3Byb3BhZ2F0ZSgpIGRlbGV0aW9u LiAgSXQgYWRkaXRpb25hbGx5Cj4+IGdldHMgcmlkIG9mIGEgZ290byB3ZSBubyBsb25nZXIgd2Fu dC4gIEZvciB0aGUgZ2VuZXJhbCBjYXNlLCBzZWUgYmVsb3cuCj4+Cj4+IFRoZSBydWxlIGFwcGxp ZXMgb25seSB3aGVyZSBydWxlMSBqdXN0IGRlbGV0ZWQgdGhlIHZhcmlhYmxlLiAgVGh1cywgdGhl Cj4+IHR3byBydWxlcyB3b3JrIGluIHRhbmRlbS4gIE1ha2VzIHNlbnNlLgo+Pgo+Pj4gKwo+Pj4g K0BACj4+PiAraWRlbnRpZmllciBydWxlMS5mbiwgcnVsZTEubG9jYWxfZXJyOwo+Pgo+PiBUaGlz IHJ1bGUgYWxzbyB3b3JrcyBpbiB0YW5kZW0gd2l0aCBydWxlMS4KPj4KPj4+ICtleHByZXNzaW9u IGxpc3QgYXJnczsgLy8gdG8gcmVpbmRlbnQgZXJyb3JfcHJvcGFnYXRlX3ByZXBlbmQKPj4KPj4g V2hhdCBpcyB0aGUgY29tbWVudCB0cnlpbmcgdG8gdGVsbCBtZT8KPj4KPj4+ICtAQAo+Pj4gKwo+ Pj4gKyBmbiguLi4pCj4+PiArIHsKPj4+ICsgICAgIDwuLi4KPj4+ICsoCj4+PiArLSAgICBlcnJv cl9mcmVlKGxvY2FsX2Vycik7Cj4+PiArLSAgICBsb2NhbF9lcnIgPSBOVUxMOwo+Pj4gKysgICAg ZXJyb3JfZnJlZV9lcnJwKGVycnApOwo+Pgo+PiBSZW1pbmRlcjoKPj4KPj4gICAgICBzdGF0aWMg aW5saW5lIHZvaWQgZXJyb3JfZnJlZV9lcnJwKEVycm9yICoqZXJycCkKPj4gICAgICB7Cj4+ICAg ICAgICAgIGFzc2VydChlcnJwICYmICplcnJwKTsKPj4gICAgICAgICAgZXJyb3JfZnJlZSgqZXJy cCk7Cj4+ICAgICAgICAgICplcnJwID0gTlVMTDsKPj4gICAgICB9Cj4+Cj4+IE5vdyBsZXQncyBl eGFtaW5lIHRoZSBhY3R1YWwgY2hhbmdlLgo+Pgo+PiBUaGUgYXNzZXJ0aW9uJ3MgZmlyc3QgaGFs ZiB0cml2aWFsbHkgaG9sZHMsIEVSUlBfQVVUT19QUk9QQUdBVEUoKQo+PiBlbnN1cmVzIGl0Lgo+ Pgo+PiBUaGUgc2Vjb25kIGhhbGYgaXMgbmV3LiAgV2Ugbm93IGNyYXNoIHdoZW4gd2UgaGF2ZW4n dCBzZXQgYW4gZXJyb3IuICBXaHkKPj4gaXMgdGhpcyBzYWZlPyAgTm90ZSB0aGF0IGVycm9yX2Zy ZWUobG9jYWxfZXJyKSBkb2VzIG5vdGhpbmcgd2hlbgo+PiAhbG9jYWxfZXJyLgo+Pgo+PiBUaGUg emFwcGluZyBvZiB0aGUgdmFyaWFibGUgcG9pbnRpbmcgdG8gdGhlIEVycm9yIGp1c3QgZnJlZWQg aXMKPj4gdW5jaGFuZ2VkLgo+Pgo+Pj4gK3wKPj4+ICstICAgIGVycm9yX2ZyZWUobG9jYWxfZXJy KTsKPj4+ICsrICAgIGVycm9yX2ZyZWVfZXJycChlcnJwKTsKPj4KPj4gSGVyZSwgdGhlIHphcHBp bmcgaXMgbmV3LiAgWmFwcGluZyBkYW5nbGluZyBwb2ludGVycyBpcyBvYnZpb3VzbHkgc2FmZS4K Pj4gTmVlZGVkLCBvciBlbHNlIHRoZSBhdXRvbWF0aWMgZXJyb3JfcHJvcGFnYXRlKCkgZHVlIHRv Cj4+IEVSUlBfQVVUT19QUk9QQUdBVEUoKSB3b3VsZCBwcm9wYWdhdGUgdGhlIGRhbmdsaW5nIHBv aW50ZXIuCj4+Cj4+PiArfAo+Pj4gKy0gICAgZXJyb3JfcmVwb3J0X2Vycihsb2NhbF9lcnIpOwo+ Pj4gKysgICAgZXJyb3JfcmVwb3J0X2VycnAoZXJycCk7CgplcnJvcl9yZXBvcnRmX2VycigpIGlz IGp1c3QgbGlrZSBlcnJvcl9yZXBvcnRfZXJyKCksIGV4Y2VwdCBpdAphZGRpdGlvbmFsbHkgbW9k aWZpZXMgdGhlIGVycm9yIG1lc3NhZ2UuICBEb2VzIGl0IG5lZWQgYSBzaW1pbGFyCnRyYW5zZm9y bWF0aW9uPwoKPj4gVGhlIG9ubHkgZGlmZmVyZW5jZSB0byB0aGUgcHJldmlvdXMgY2FzZSBpcyB0 aGF0IHdlIGFsc28gcmVwb3J0IHRoZQo+PiBlcnJvci4KPj4KPj4gVGhlIHByZXZpb3VzIGNhc2Ug aGFzIGEgYnVkZHkgdGhhdCBhZGRpdGlvbmFsbHkgbWF0Y2hlcyAqZXJycCA9IE5VTEwuCj4+IFdo eSBub3QgdGhpcyBvbmU/Cj4+Cj4+PiArfAo+Pj4gKy0gICAgd2Fybl9yZXBvcnRfZXJyKGxvY2Fs X2Vycik7Cj4+PiArKyAgICB3YXJuX3JlcG9ydF9lcnJwKGVycnApOwoKTGlrZXdpc2UuCgo+PiBM aWtld2lzZS4KPj4KPj4gV2hhdCBhYm91dCBlcnJvcl9yZXBvcnRmX2VycigpLCB3YXJuX3JlcG9y dGZfZXJyKCk/Cj4+Cj4+IFVwIHRvIGhlcmUsIHRoaXMgcnVsZSB0cmFuc2Zvcm1zIHRoZSB2YXJp b3VzIGZvcm1zIG9mIGVycm9yX2ZyZWUoKS4KPj4gTmV4dDogZXJyb3JfcHJvcGFnYXRlKCkuCj4+ Cj4+PiArfAo+Pj4gKy0gICAgZXJyb3JfcHJvcGFnYXRlX3ByZXBlbmQoZXJycCwgbG9jYWxfZXJy LCBhcmdzKTsKPj4+ICsrICAgIGVycm9yX3ByZXBlbmQoZXJycCwgYXJncyk7Cj4+PiArfAo+Pj4g Ky0gICAgZXJyb3JfcHJvcGFnYXRlKGVycnAsIGxvY2FsX2Vycik7Cj4+Cj4+IHJ1bGUwJ3MgYWRk aW5nIG9mIEVSUlBfQVVUT19QUk9QQUdBVEUoKSBtYWRlIGVycm9yX3Byb3BhZ2F0ZSgpCj4+IHJl ZHVuZGFudC4KPj4KPj4gVGhpcyBpcyB0aGUgZ2VuZXJhbCBjYXNlIG9mIGVycm9yX3Byb3BhZ2F0 ZSgpIGRlbGV0aW9uLgo+Pgo+PiBJJ2QgcHV0IHRoZSBwbGFpbiBlcnJvcl9wcm9wYWdhdGUoKSBm aXJzdCwgdmFyaWF0aW9ucyBzZWNvbmQsIGxpa2UgeW91Cj4+IGRvIHdpdGggZXJyb3JfZnJlZSgp Lgo+Pgo+PiBJZiBuZWl0aGVyIG9mIHRoZXNlIHR3byBwYXR0ZXJucyBtYXRjaCBvbiBhIHBhdGgg ZnJvbQo+PiBFUlJQX0FVVE9fUFJPUEFHQVRFKCkgdG8gcmV0dXJuLCB3ZSBlZmZlY3RpdmVseSBp bnNlcnQgZXJyb3JfcHJvcGFnYXRlKCkKPj4gd2hlcmUgaXQgd2Fzbid0IGJlZm9yZS4gIERvZXMg bm90aGluZyB3aGVuIHRoZSBsb2NhbCBlcnJvciBpcyBudWxsCj4+IHRoZXJlLiAgQnVnIGZpeCB3 aGVuIGl0IGlzbid0OiBpdCdzIGF0IGxlYXN0IGEgbWVtb3J5IGxlYWssIGFuZCBxdWl0ZQo+PiBw b3NzaWJseSB3b3JzZS4KPj4KPj4gSWRlbnRpZnlpbmcgdGhlc2UgYnVnIGZpeGVzIHdvdWxkIGJl IG5pY2UsIGJ1dCBJIGRvbid0IGhhdmUgcHJhY3RpY2FsCj4+IGlkZWFzIG9uIGhvdyB0byBkbyB0 aGF0Lgo+Pgo+PiBDYW4gd2UgZXhwbGFpbiB0aGlzIGluIHRoZSBjb21taXQgbWVzc2FnZT8KPj4K Pj4+ICspCj4+PiArICAgICAuLi4+Cj4+PiArIH0KPj4+ICsKPj4+ICtAQAo+Pj4gK2lkZW50aWZp ZXIgcnVsZTEuZm4sIHJ1bGUxLmxvY2FsX2VycjsKPj4+ICtAQAo+Pj4gKwo+Pj4gKyBmbiguLi4p Cj4+PiArIHsKPj4+ICsgICAgIDwuLi4KPj4+ICsoCj4+PiArLSAgICAmbG9jYWxfZXJyCj4+PiAr KyAgICBlcnJwCj4+PiArfAo+Pj4gKy0gICAgbG9jYWxfZXJyCj4+PiArKyAgICAqZXJycAo+Pj4g KykKPj4+ICsgICAgIC4uLj4KPj4+ICsgfQo+Pgo+PiBBbHNvIGluIHRhbmRlbSB3aXRoIHJ1bGUx LCBmaXhlcyB1cCB1c2VzIG9mIGxvY2FsX2Vyci4gIEdvb2QuCj4+Cj4+PiArCj4+PiArQEAKPj4+ ICtpZGVudGlmaWVyIHJ1bGUxLmZuOwo+Pj4gK0BACj4+PiArCj4+PiArIGZuKC4uLikKPj4+ICsg ewo+Pj4gKyAgICAgPC4uLgo+Pj4gKy0gKmVycnAgIT0gTlVMTAo+Pj4gKysgKmVycnAKPj4+ICsg ICAgIC4uLj4KPj4+ICsgfQo+Pgo+PiBTdGlsbCBpbiB0YW5kZW0gd2l0aCBydWxlMSwgbm9ybWFs aXplcyBzdHlsZS4gIEdvb2QuCj4+CgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVu cHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZv L3hlbi1kZXZlbA== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD3BBC3F2D1 for ; Wed, 4 Mar 2020 15:11:37 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 997AD21741 for ; Wed, 4 Mar 2020 15:11:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Zf4X4zIl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 997AD21741 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:35508 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j9VgO-0001Za-NB for qemu-devel@archiver.kernel.org; Wed, 04 Mar 2020 10:11:36 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:39099) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j9Vff-0000oN-5T for qemu-devel@nongnu.org; Wed, 04 Mar 2020 10:10:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j9Vfb-0004jL-Vf for qemu-devel@nongnu.org; Wed, 04 Mar 2020 10:10:50 -0500 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:54037 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j9Vfb-0004i4-Pe for qemu-devel@nongnu.org; Wed, 04 Mar 2020 10:10:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583334647; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aV2ERlSJsI2FpkwWQpWb1+QW/Sr6AY0k5wGVtgwLXns=; b=Zf4X4zIl6xIDCu7Qi6TyhPf4LKaIpwVBVfvwyyIno/DSSX2uW4dFceES69jq6EU/oEEQzo 64hEjy5YogWPQ3pAoFtm8FYMBu+Zfwj3iFMgGnKB5MGPssJc3Pec9GiRVMM0Ra9e+NBBrG 3oRuuL5WZjzVdaDXjOko0mbheZDaIS4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-25-gAmdQMw4PJWbeUsQonhiBA-1; Wed, 04 Mar 2020 10:10:43 -0500 X-MC-Unique: gAmdQMw4PJWbeUsQonhiBA-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0CAD51005F7A; Wed, 4 Mar 2020 15:10:41 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-116-129.ams2.redhat.com [10.36.116.129]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 515B490CC3; Wed, 4 Mar 2020 15:10:35 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id CB22D11386A6; Wed, 4 Mar 2020 16:10:33 +0100 (CET) From: Markus Armbruster To: Vladimir Sementsov-Ogievskiy Subject: Re: [PATCH v7 03/11] scripts: add coccinelle script to use auto propagated errp References: <20200131130118.1716-1-vsementsov@virtuozzo.com> <20200131130118.1716-4-vsementsov@virtuozzo.com> <87v9nxwulz.fsf@dusky.pond.sub.org> Date: Wed, 04 Mar 2020 16:10:33 +0100 In-Reply-To: (Vladimir Sementsov-Ogievskiy's message of "Wed, 4 Mar 2020 16:40:13 +0300") Message-ID: <875zfki2ae.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.81 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Stefano Stabellini , qemu-block@nongnu.org, Paul Durrant , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Michael Roth , qemu-devel@nongnu.org, Greg Kurz , Gerd Hoffmann , Stefan Hajnoczi , Anthony Perard , xen-devel@lists.xenproject.org, Max Reitz , Laszlo Ersek , Stefan Berger Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Vladimir Sementsov-Ogievskiy writes: > 23.02.2020 11:55, Markus Armbruster wrote: >> Vladimir Sementsov-Ogievskiy writes: >> >>> Script adds ERRP_AUTO_PROPAGATE macro invocation where appropriate and >>> does corresponding changes in code (look for details in >>> include/qapi/error.h) >>> >>> Usage example: >>> spatch --sp-file scripts/coccinelle/auto-propagated-errp.cocci \ >>> --macro-file scripts/cocci-macro-file.h --in-place --no-show-diff \ >>> blockdev-nbd.c qemu-nbd.c {block/nbd*,nbd/*,include/block/nbd*}.[hc] >>> >>> Signed-off-by: Vladimir Sementsov-Ogievskiy >>> --- >>> >>> CC: Eric Blake >>> CC: Kevin Wolf >>> CC: Max Reitz >>> CC: Greg Kurz >>> CC: Stefano Stabellini >>> CC: Anthony Perard >>> CC: Paul Durrant >>> CC: Stefan Hajnoczi >>> CC: "Philippe Mathieu-Daud=C3=A9" >>> CC: Laszlo Ersek >>> CC: Gerd Hoffmann >>> CC: Stefan Berger >>> CC: Markus Armbruster >>> CC: Michael Roth >>> CC: qemu-block@nongnu.org >>> CC: xen-devel@lists.xenproject.org >>> >>> include/qapi/error.h | 3 + >>> scripts/coccinelle/auto-propagated-errp.cocci | 158 +++++++++++++++++= + >>> 2 files changed, 161 insertions(+) >>> create mode 100644 scripts/coccinelle/auto-propagated-errp.cocci >>> >>> diff --git a/include/qapi/error.h b/include/qapi/error.h >>> index b9452d4806..79f8e95214 100644 >>> --- a/include/qapi/error.h >>> +++ b/include/qapi/error.h >>> @@ -141,6 +141,9 @@ >>> * ... >>> * } >>> * >>> + * For mass conversion use script >>> + * scripts/coccinelle/auto-propagated-errp.cocci >>> + * >>> * >>> * Receive and accumulate multiple errors (first one wins): >>> * Error *err =3D NULL, *local_err =3D NULL; >> >> Extra blank line. >> >>> diff --git a/scripts/coccinelle/auto-propagated-errp.cocci b/scripts/co= ccinelle/auto-propagated-errp.cocci >>> new file mode 100644 >>> index 0000000000..fb03c871cb >>> --- /dev/null >>> +++ b/scripts/coccinelle/auto-propagated-errp.cocci >>> @@ -0,0 +1,158 @@ >>> +// Use ERRP_AUTO_PROPAGATE (see include/qapi/error.h) >>> +// >>> +// Copyright (c) 2020 Virtuozzo International GmbH. >>> +// >>> +// This program is free software; you can redistribute it and/or modif= y >>> +// it under the terms of the GNU General Public License as published b= y >>> +// the Free Software Foundation; either version 2 of the License, or >>> +// (at your option) any later version. >>> +// >>> +// This program is distributed in the hope that it will be useful, >>> +// but WITHOUT ANY WARRANTY; without even the implied warranty of >>> +// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >>> +// GNU General Public License for more details. >>> +// >>> +// You should have received a copy of the GNU General Public License >>> +// along with this program. If not, see . >>> +// >>> +// Usage example: >>> +// spatch --sp-file scripts/coccinelle/auto-propagated-errp.cocci \ >>> +// --macro-file scripts/cocci-macro-file.h --in-place --no-show-diff = \ >>> +// blockdev-nbd.c qemu-nbd.c {block/nbd*,nbd/*,include/block/nbd*}.[h= c] >>> + >>> +@rule0@ >>> +// Add invocation to errp-functions where necessary >>> +// We should skip functions with "Error *const *errp" >>> +// parameter, but how to do it with coccinelle? >>> +// I don't know, so, I skip them by function name regex. >>> +// It's safe: if we did not skip some functions with >>> +// "Error *const *errp", ERRP_AUTO_PROPAGATE invocation >>> +// will fail to compile, because of const violation. >> >> Not skipping a function we should skip fails to compile. >> >> What about skipping a function we should not skip? >> >>> +identifier fn !~ "error_append_.*_hint"; >>> +identifier local_err, ERRP; >> >> A few of our coccinelle scripts use ALL_CAPS for meta-variables. Most >> don't. Either is fine with me. Mixing the two styles feels a bit >> confusing, though. >> >>> +@@ >>> + >>> + fn(..., Error **ERRP, ...) >>> + { >>> ++ ERRP_AUTO_PROPAGATE(); >>> + <+... >>> + when !=3D ERRP_AUTO_PROPAGATE(); >>> +( >>> + error_append_hint(ERRP, ...); >>> +| >>> + error_prepend(ERRP, ...); >>> +| >>> + Error *local_err =3D NULL; >>> +) >>> + ...+> >>> + } >> >> Misses error_vprepend(). Currently harmless, but as long as we commit >> the script, we better make it as robust as we reasonably can. >> >> The previous patch explains this Coccinelle script's intent: >> >> To achieve these goals, later patches will add invocations >> of this macro at the start of functions with either use >> error_prepend/error_append_hint (solving 1) or which use >> local_err+error_propagate to check errors, switching those >> functions to use *errp instead (solving 2 and 3). >> >> This rule matches "use error_prepend/error_append_hint" directly. It >> appears to use presence of a local Error * variable as proxy for "use >> local_err+error_propagate to check errors". Hmm. >> >> We obviously have such a variable when we use "local_err+error_propagate >> to check errors". But we could also have such variables without use of >> error_propagate(). In fact, error.h documents such use: >> >> * Call a function and receive an error from it: >> * Error *err =3D NULL; >> * foo(arg, &err); >> * if (err) { >> * handle the error... >> * } >> >> where "handle the error" frees it. >> >> I figure such uses typically occur in functions without an Error **errp >> parameter. This rule doesn't apply then. But they could occur even in >> functions with such a parameter. Consider: >> >> void foo(Error **errp) >> { >> Error *err =3D NULL; >> >> bar(&err); >> if (err) { >> error_free(err); >> error_setg(errp, "completely different error"); >> } >> } >> >> Reasonable enough when bar() gives us an error that's misleading in this >> context, isn't it? >> >> The script transforms it like this: >> >> void foo(Error **errp) >> { >> - Error *err =3D NULL; >> + ERRP_AUTO_PROPAGATE(); >> >> - bar(&err); >> - if (err) { >> - error_free(err); >> + bar(errp); >> + if (*errp) { >> + error_free_errp(errp); >> error_setg(errp, "completely different error"); >> } >> } >> >> Unwanted. >> >> Now, if this script applied in just a few dozen places, we could rely on >> eyeballing its output to catch unwanted transformations. Since it >> applies in so many more, I don't feel comfortable relying on reviewer >> eyeballs. >> >> Can we make rule0 directly match error_propagate(errp, local_err) >> somehow? >> >> Another observation: the rule does not match error_reportf_err() and >> warn_reportf_err(). > > They are unrelated, as they take Error* argument, not Error** > >> These combine error_prepend(), >> error_report()/warn_report() and error_free(), for convenience. Don't >> their users need ERRP_AUTO_PROPAGATE() just like error_prepend()'s >> users? Right, we never pass *errp to error_reportf_err() and warn_reportf_err(), so there's no need to wrap it. But see below. >> >>> + >>> +@@ >>> +// Switch unusual (Error **) parameter names to errp >>> +// (this is necessary to use ERRP_AUTO_PROPAGATE). >> >> Please put your rule comments right before the rule, i.e. before the >> @-line introducing metavariable declarations, not after. Same >> elsewhere. >> >>> +identifier rule0.fn; >>> +identifier rule0.ERRP !=3D errp; >>> +@@ >>> + >>> + fn(..., >>> +- Error **ERRP >>> ++ Error **errp >>> + ,...) >>> + { >>> + <... >>> +- ERRP >>> ++ errp >>> + ...> >>> + } >> >> This normalizes errp parameter naming. It matches exactly when rule0 >> matches (and inserts ERRP_AUTO_PROPAGATE()) and the Error ** parameter >> is unusual. Good. >> >>> + >>> +@rule1@ >>> +// We want to patch error propagation in functions regardless of >>> +// whether the function already uses ERRP_AUTO_PROPAGATE prior to >>> +// applying rule0, hence this one does not inherit from it. >> >> I'm not sure I get this comment. Let's see what the rule does. >> >>> +identifier fn !~ "error_append_.*_hint"; >>> +identifier local_err; >>> +symbol errp; >>> +@@ >>> + >>> + fn(..., Error **errp, ...) >>> + { >>> + <... >>> +- Error *local_err =3D NULL; >>> + ...> >>> + } >> >> rule1 matches like rule0, except the Error ** parameter match is >> tightened from any C identifier to the C identifier errp, and the >> function body match tightened from "either use >> error_prepend/error_append_hint or which use local_err+error_propagate >> to check errors" to just the latter. >> >> I figure tightening the Error ** parameter match has no effect, because >> we already normalized the parameter name. >> >> So rule1 deletes variable local_err where rule0 applied. Correct? >> >>> + >>> +@@ >>> +// Handle pattern with goto, otherwise we'll finish up >>> +// with labels at function end which will not compile. >>> +identifier rule1.fn, rule1.local_err; >>> +identifier OUT; >>> +@@ >>> + >>> + fn(...) >>> + { >>> + <... >>> +- goto OUT; >>> ++ return; >>> + ...> >>> +- OUT: >>> +- error_propagate(errp, local_err); >>> + } >> >> This is one special case of error_propagate() deletion. It additionally >> gets rid of a goto we no longer want. For the general case, see below. >> >> The rule applies only where rule1 just deleted the variable. Thus, the >> two rules work in tandem. Makes sense. >> >>> + >>> +@@ >>> +identifier rule1.fn, rule1.local_err; >> >> This rule also works in tandem with rule1. >> >>> +expression list args; // to reindent error_propagate_prepend >> >> What is the comment trying to tell me? >> >>> +@@ >>> + >>> + fn(...) >>> + { >>> + <... >>> +( >>> +- error_free(local_err); >>> +- local_err =3D NULL; >>> ++ error_free_errp(errp); >> >> Reminder: >> >> static inline void error_free_errp(Error **errp) >> { >> assert(errp && *errp); >> error_free(*errp); >> *errp =3D NULL; >> } >> >> Now let's examine the actual change. >> >> The assertion's first half trivially holds, ERRP_AUTO_PROPAGATE() >> ensures it. >> >> The second half is new. We now crash when we haven't set an error. Why >> is this safe? Note that error_free(local_err) does nothing when >> !local_err. >> >> The zapping of the variable pointing to the Error just freed is >> unchanged. >> >>> +| >>> +- error_free(local_err); >>> ++ error_free_errp(errp); >> >> Here, the zapping is new. Zapping dangling pointers is obviously safe. >> Needed, or else the automatic error_propagate() due to >> ERRP_AUTO_PROPAGATE() would propagate the dangling pointer. >> >>> +| >>> +- error_report_err(local_err); >>> ++ error_report_errp(errp); error_reportf_err() is just like error_report_err(), except it additionally modifies the error message. Does it need a similar transformation? >> The only difference to the previous case is that we also report the >> error. >> >> The previous case has a buddy that additionally matches *errp =3D NULL. >> Why not this one? >> >>> +| >>> +- warn_report_err(local_err); >>> ++ warn_report_errp(errp); Likewise. >> Likewise. >> >> What about error_reportf_err(), warn_reportf_err()? >> >> Up to here, this rule transforms the various forms of error_free(). >> Next: error_propagate(). >> >>> +| >>> +- error_propagate_prepend(errp, local_err, args); >>> ++ error_prepend(errp, args); >>> +| >>> +- error_propagate(errp, local_err); >> >> rule0's adding of ERRP_AUTO_PROPAGATE() made error_propagate() >> redundant. >> >> This is the general case of error_propagate() deletion. >> >> I'd put the plain error_propagate() first, variations second, like you >> do with error_free(). >> >> If neither of these two patterns match on a path from >> ERRP_AUTO_PROPAGATE() to return, we effectively insert error_propagate() >> where it wasn't before. Does nothing when the local error is null >> there. Bug fix when it isn't: it's at least a memory leak, and quite >> possibly worse. >> >> Identifying these bug fixes would be nice, but I don't have practical >> ideas on how to do that. >> >> Can we explain this in the commit message? >> >>> +) >>> + ...> >>> + } >>> + >>> +@@ >>> +identifier rule1.fn, rule1.local_err; >>> +@@ >>> + >>> + fn(...) >>> + { >>> + <... >>> +( >>> +- &local_err >>> ++ errp >>> +| >>> +- local_err >>> ++ *errp >>> +) >>> + ...> >>> + } >> >> Also in tandem with rule1, fixes up uses of local_err. Good. >> >>> + >>> +@@ >>> +identifier rule1.fn; >>> +@@ >>> + >>> + fn(...) >>> + { >>> + <... >>> +- *errp !=3D NULL >>> ++ *errp >>> + ...> >>> + } >> >> Still in tandem with rule1, normalizes style. Good. >>