From: "Alex Bennée" <alex.bennee@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>,
Stefan Hajnoczi <stefanha@redhat.com>,
Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [PULL 0/5] Tracing patches
Date: Fri, 31 Jan 2020 15:25:03 +0000 [thread overview]
Message-ID: <875zgr8x80.fsf@linaro.org> (raw)
In-Reply-To: <CAFEAcA_=_8ZFC=DF3UkqvWqvjQsCHjc=_fYcMmbXs=iLp7JrcQ@mail.gmail.com>
Peter Maydell <peter.maydell@linaro.org> writes:
> On Thu, 30 Jan 2020 at 21:38, Stefan Hajnoczi <stefanha@redhat.com> wrote:
>>
>> The following changes since commit 928173659d6e5dc368284f73f90ea1d129e1f57d:
>>
>> Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20200130' into staging (2020-01-30 16:19:04 +0000)
>>
>> are available in the Git repository at:
>>
>> https://github.com/stefanha/qemu.git tags/tracing-pull-request
>>
>> for you to fetch changes up to e144a605a614d22165000c69e8e1dc6986d45cd8:
>>
>> qemu_set_log_filename: filename argument may be NULL (2020-01-30 21:33:50 +0000)
>>
>> ----------------------------------------------------------------
>> Pull request
>>
>> ----------------------------------------------------------------
>>
>> Peter Maydell (3):
>> docs/devel/tracing.txt: Recommend only
>> trace_event_get_state_backends()
>> memory.c: Use trace_event_get_state_backends()
>> hw/display/qxl.c: Use trace_event_get_state_backends()
>>
>> Philippe Mathieu-Daudé (1):
>> Makefile: Keep trace-events-subdirs ordered
>>
>> Salvador Fandino (1):
>> qemu_set_log_filename: filename argument may be NULL
>
> Here's a weird one -- with this pullreq applied I
> see a new warning running check-tcg on the linux-user
> static config build:
>
> TEST linux-test on aarch64
> TEST testthread on aarch64
> TEST float_madds on aarch64
> DIFF float_madds.out with
> /home/petmay01/linaro/qemu-for-merges/tests/tcg/aarch64/float_ma
> dds.ref
> TEST fcvt on aarch64
> warning: TCG temporary leaks before 0000000000400a0c
> DIFF fcvt.out with
> /home/petmay01/linaro/qemu-for-merges/tests/tcg/aarch64/fcvt.ref
> TEST pauth-1 on aarch64
> TEST pauth-2 on aarch64
>
> but I'm not sure why any of the patches here would have
> provoked that, unless they're now causing a log message
> that would previously have been suppressed or directed
> somewhere else to be emitted.
That must be it - before hand we wouldn't have called
qemu_set_log_filename which in turn doesn't call qemu_set_log.
Anyway I have replicated the warning.
>
> thanks
> -- PMM
--
Alex Bennée
next prev parent reply other threads:[~2020-01-31 16:22 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-30 21:38 [PULL 0/5] Tracing patches Stefan Hajnoczi
2020-01-30 21:38 ` [PULL 1/5] Makefile: Keep trace-events-subdirs ordered Stefan Hajnoczi
2020-01-30 21:38 ` [PULL 2/5] docs/devel/tracing.txt: Recommend only trace_event_get_state_backends() Stefan Hajnoczi
2020-01-30 21:38 ` [PULL 3/5] memory.c: Use trace_event_get_state_backends() Stefan Hajnoczi
2020-01-30 21:38 ` [PULL 4/5] hw/display/qxl.c: " Stefan Hajnoczi
2020-01-30 21:38 ` [PULL 5/5] qemu_set_log_filename: filename argument may be NULL Stefan Hajnoczi
2020-02-11 22:51 ` Richard Henderson
2020-02-12 10:45 ` Alex Bennée
2020-02-12 21:41 ` Richard Henderson
2020-01-31 13:57 ` [PULL 0/5] Tracing patches Peter Maydell
2020-01-31 14:38 ` Philippe Mathieu-Daudé
2020-01-31 14:45 ` Philippe Mathieu-Daudé
2020-01-31 15:25 ` Alex Bennée [this message]
2020-01-31 19:05 ` Peter Maydell
-- strict thread matches above, loose matches on Subject: below --
2021-01-04 14:31 Stefan Hajnoczi
2021-01-04 14:42 ` no-reply
2021-01-05 16:18 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875zgr8x80.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=kraxel@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.