From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Imre Deak <imre.deak@intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t 2/3] lib/igt_fb: Use render copy/blit for tiled formats on platforms w/o HW detiling
Date: Tue, 21 Jan 2020 22:02:06 -0800 [thread overview]
Message-ID: <875zh4c9lt.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20200120220320.17092-2-imre.deak@intel.com>
On Mon, 20 Jan 2020 14:03:19 -0800, Imre Deak wrote:
>
> On platforms without HW detiling use render copy or blitting to convert
> between a tiled and a linear framebuffer.
>
> Signed-off-by: Imre Deak <imre.deak@intel.com>
> ---
> lib/igt_fb.c | 16 +++++++++++++---
> 1 file changed, 13 insertions(+), 3 deletions(-)
>
> diff --git a/lib/igt_fb.c b/lib/igt_fb.c
> index c81b9de8..b5b1750e 100644
> --- a/lib/igt_fb.c
> +++ b/lib/igt_fb.c
> @@ -1975,17 +1975,27 @@ static bool blitter_ok(const struct igt_fb *fb)
> return true;
> }
>
> +static bool hw_can_detile(const struct igt_fb *fb)
> +{
> + if (fb->modifier == DRM_FORMAT_MOD_NONE)
> + return true;
The problem with doing this afais is that the code will next try to
mmap_gtt() (i.e. do a linear copy via the aperture) which will also fail
(see igt_get_cairo_surface()). So we may need to use the blitter even for
linear copies (DRM_FORMAT_MOD_NONE).
May want to look at this:
https://patchwork.freedesktop.org/patch/345926/?series=71083&rev=2
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2020-01-22 6:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-20 22:03 [igt-dev] [PATCH i-g-t 1/3] lib/ioctl_wrappers: Query if device supports set/get legacy tiling Imre Deak
2020-01-20 22:03 ` [igt-dev] [PATCH i-g-t 2/3] lib/igt_fb: Use render copy/blit for tiled formats on platforms w/o HW detiling Imre Deak
2020-01-21 16:19 ` Juha-Pekka Heikkila
2020-01-21 16:35 ` Imre Deak
2020-01-21 17:59 ` Juha-Pekka Heikkila
2020-01-22 6:02 ` Dixit, Ashutosh [this message]
2020-01-22 9:34 ` Imre Deak
2020-01-20 22:03 ` [igt-dev] [PATCH i-g-t 3/3] lib/igt_fb: Fix creating FBs " Imre Deak
2020-01-21 16:21 ` Juha-Pekka Heikkila
2020-01-21 4:27 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/3] lib/ioctl_wrappers: Query if device supports set/get legacy tiling Patchwork
2020-01-21 19:26 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875zh4c9lt.wl-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=imre.deak@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.